From 726735c61fcf970f51b1e6bd900d2579897d90c1 Mon Sep 17 00:00:00 2001
From: Thomas Fischer <thomas.fischer@ufz.de>
Date: Mon, 29 Jul 2024 15:23:11 +0200
Subject: [PATCH] [GL/IO] Don't use stringstream in readCoordinates.
This saves almost 40% of run time.
---
GeoLib/IO/AsciiRasterInterface.cpp | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/GeoLib/IO/AsciiRasterInterface.cpp b/GeoLib/IO/AsciiRasterInterface.cpp
index 87433b379f5..3dd895cdaf2 100644
--- a/GeoLib/IO/AsciiRasterInterface.cpp
+++ b/GeoLib/IO/AsciiRasterInterface.cpp
@@ -249,10 +249,16 @@ std::optional<std::array<double, 3>> readCoordinates(std::istream& in)
std::string line("");
if (std::getline(in, line))
{
- std::stringstream str_stream(line);
std::array<double, 3> coords;
- str_stream >> coords[0] >> coords[1] >> coords[2];
- return std::make_optional(coords);
+ if (std::sscanf(line.c_str(), "%lf %lf %lf", &coords[0], &coords[1],
+ &coords[2]) == 3)
+ {
+ return coords;
+ }
+ else
+ {
+ OGS_FATAL("Could not parse coordinates in readCoordinates().");
+ }
}
return std::nullopt;
}
--
GitLab