From 9c6b8c1822ca21d1a968e7b4174360bc247b7519 Mon Sep 17 00:00:00 2001
From: Dmitri Naumov <github@naumov.de>
Date: Sun, 24 Feb 2019 16:51:44 +0100
Subject: [PATCH] [GL/IO] TIN; Fix duplicate if condition.
Original CppCheck message is:
"Same expression on both sides of '&&'.. Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct."
DON'T COPY & PASTE!
---
GeoLib/IO/TINInterface.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/GeoLib/IO/TINInterface.cpp b/GeoLib/IO/TINInterface.cpp
index 20cecd08b40..125446e9236 100644
--- a/GeoLib/IO/TINInterface.cpp
+++ b/GeoLib/IO/TINInterface.cpp
@@ -112,7 +112,8 @@ GeoLib::Surface* TINInterface::readTIN(std::string const& fname,
// create new Triangle
if (pnt_pos_0 != std::numeric_limits<std::size_t>::max() &&
pnt_pos_1 != std::numeric_limits<std::size_t>::max() &&
- pnt_pos_1 != std::numeric_limits<std::size_t>::max()) {
+ pnt_pos_2 != std::numeric_limits<std::size_t>::max())
+ {
sfc->addTriangle(pnt_pos_0, pnt_pos_1, pnt_pos_2);
}
}
--
GitLab