From dce8c9680c663eb940efe60e71e69223372b151f Mon Sep 17 00:00:00 2001
From: Norbert Grunwald <Norbert.Grunwald@ufz.de>
Date: Thu, 12 Sep 2019 08:45:43 +0200
Subject: [PATCH] changes according to review
---
MaterialLib/MPL/Properties/CreateRelPermBrooksCorey.cpp | 2 +-
MaterialLib/MPL/Properties/RelPermBrooksCorey.cpp | 1 -
MaterialLib/MPL/Properties/RelPermBrooksCorey.h | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/MaterialLib/MPL/Properties/CreateRelPermBrooksCorey.cpp b/MaterialLib/MPL/Properties/CreateRelPermBrooksCorey.cpp
index 9cabb0beec3..b9b0f89539e 100644
--- a/MaterialLib/MPL/Properties/CreateRelPermBrooksCorey.cpp
+++ b/MaterialLib/MPL/Properties/CreateRelPermBrooksCorey.cpp
@@ -36,7 +36,7 @@ std::unique_ptr<RelPermBrooksCorey> createRelPermBrooksCorey(
auto const exponent =
//! \ogs_file_param{prj__media__medium__properties__property__RelPermBrooksCorey__lambda}
config.getConfigParameter<double>("lambda");
- if (exponent == 0.)
+ if (exponent <= 0.)
{
OGS_FATAL("Exponent 'lambda' must be positive.");
}
diff --git a/MaterialLib/MPL/Properties/RelPermBrooksCorey.cpp b/MaterialLib/MPL/Properties/RelPermBrooksCorey.cpp
index a2a22c50733..6ff47331871 100644
--- a/MaterialLib/MPL/Properties/RelPermBrooksCorey.cpp
+++ b/MaterialLib/MPL/Properties/RelPermBrooksCorey.cpp
@@ -26,7 +26,6 @@ RelPermBrooksCorey::RelPermBrooksCorey(
const double min_relative_permeability_liquid,
const double min_relative_permeability_gas,
const double exponent)
-
: _residual_liquid_saturation(residual_liquid_saturation),
_residual_gas_saturation(residual_gas_saturation),
_min_relative_permeability_liquid(min_relative_permeability_liquid),
diff --git a/MaterialLib/MPL/Properties/RelPermBrooksCorey.h b/MaterialLib/MPL/Properties/RelPermBrooksCorey.h
index 0f18e81292e..a387ac129a5 100644
--- a/MaterialLib/MPL/Properties/RelPermBrooksCorey.h
+++ b/MaterialLib/MPL/Properties/RelPermBrooksCorey.h
@@ -45,7 +45,7 @@ public:
const double /*_min_relative_permeability_gas*/,
const double /*exponent*/
);
- /// This method assigns a pointer to the meterial object that is the owner
+ /// This method assigns a pointer to the material object that is the owner
/// of this property
void setScale(
std::variant<Medium*, Phase*, Component*> scale_pointer) override
--
GitLab