diff --git a/BaseLib/FileTools.cpp b/BaseLib/FileTools.cpp index f874ba670fe1fa7f2cd9adc4cfd7a1353f005d8d..88ec37f123a80a91036ffbdfac6f06eb4ffe99a9 100644 --- a/BaseLib/FileTools.cpp +++ b/BaseLib/FileTools.cpp @@ -90,7 +90,7 @@ std::string extractBaseNameWithoutExtension(std::string const& pathname) return dropFileExtension(basename); } -std::string getSuffixFromPath(const std::string &path) +std::string getFileExtension(const std::string &path) { const std::string str = extractBaseName(path); const size_t p = findLastDot(str); diff --git a/BaseLib/FileTools.h b/BaseLib/FileTools.h index b33a3571549ed35906b3a400535d652a2ff90892..3153fc6bc1a69298a0a2a3481d223e5fd81bf571 100644 --- a/BaseLib/FileTools.h +++ b/BaseLib/FileTools.h @@ -65,9 +65,9 @@ std::string extractBaseName(std::string const& pathname); std::string extractBaseNameWithoutExtension(std::string const& pathname); /** - * Extract the file type / suffix from a path + * Extract extension from filename */ -std::string getSuffixFromPath(const std::string &str); +std::string getFileExtension(std::string const& filename); /** diff --git a/FileIO/readMeshFromFile.cpp b/FileIO/readMeshFromFile.cpp index faa38a619bf1b10d0f8f8e40b89d53ec60cda4fc..f7f74d1ac4ee0b396b6a8c2433d42841ca5d7bb6 100644 --- a/FileIO/readMeshFromFile.cpp +++ b/FileIO/readMeshFromFile.cpp @@ -24,7 +24,7 @@ namespace FileIO { MeshLib::Mesh* readMeshFromFile(const std::string &file_name) { MeshLib::Mesh* mesh (NULL); - std::string suffix (BaseLib::getSuffixFromPath(file_name)); + std::string suffix (BaseLib::getFileExtension(file_name)); if (suffix.compare("msh") == 0 || suffix.compare("MSH") == 0) { diff --git a/SimpleTests/MeshTests/MeshRead.cpp b/SimpleTests/MeshTests/MeshRead.cpp index a45edf5ffb61a57a238b8c756f06d44b42e65f98..0c47cc4b4ac76fabc2228dab46fa498a9794aff1 100644 --- a/SimpleTests/MeshTests/MeshRead.cpp +++ b/SimpleTests/MeshTests/MeshRead.cpp @@ -55,7 +55,7 @@ int main(int argc, char *argv[]) BaseLib::RunTime run_time; run_time.start(); MeshLib::Mesh* mesh(NULL); - if (BaseLib::getSuffixFromPath(fname).compare("msh") == 0) { + if (BaseLib::getFileExtension(fname).compare("msh") == 0) { mesh = mesh_io.loadMeshFromFile(fname); } else { mesh = FileIO::RapidVtuInterface::readVTUFile(fname); diff --git a/Tests/BaseLib/TestFilePathStringManipulation.cpp b/Tests/BaseLib/TestFilePathStringManipulation.cpp index 3d98d074ea64e160c5c5137d76338df884787b78..03952bdabe74dae4be1edd997bb5768129d69025 100644 --- a/Tests/BaseLib/TestFilePathStringManipulation.cpp +++ b/Tests/BaseLib/TestFilePathStringManipulation.cpp @@ -33,56 +33,56 @@ TEST(BaseLib, FindLastPathSeparatorUnix) ASSERT_EQ ( BaseLib::findLastPathSeparator("/path/path/path/"), 15 ); } -TEST(BaseLib, GetSuffixFromPathWin) +TEST(BaseLib, GetFileExtensionWin) { - ASSERT_EQ ( BaseLib::getSuffixFromPath("file"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("\\file"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("path\\"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("\\path\\"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("path\\file"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("\\path\\file"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("\\path\\path\\file"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("\\path\\path\\path\\"), "" ); - - ASSERT_EQ ( BaseLib::getSuffixFromPath("file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("\\file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("path.ext\\"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("\\path.ext\\"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("path\\file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("\\path\\file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("\\path\\path\\file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("\\path\\path\\path.ext\\"), "" ); - - ASSERT_EQ ( BaseLib::getSuffixFromPath("path.wrong\\file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("\\path.wrong\\file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("\\path.wrong0\\path.wrong\\file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("\\path.wrong0\\path.wrong\\path.ext\\"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("file"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("\\file"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("path\\"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("\\path\\"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("path\\file"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("\\path\\file"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("\\path\\path\\file"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("\\path\\path\\path\\"), "" ); + + ASSERT_EQ ( BaseLib::getFileExtension("file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("\\file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("path.ext\\"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("\\path.ext\\"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("path\\file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("\\path\\file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("\\path\\path\\file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("\\path\\path\\path.ext\\"), "" ); + + ASSERT_EQ ( BaseLib::getFileExtension("path.wrong\\file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("\\path.wrong\\file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("\\path.wrong0\\path.wrong\\file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("\\path.wrong0\\path.wrong\\path.ext\\"), "" ); } -TEST(BaseLib, GetSuffixFromPathUnix) +TEST(BaseLib, getFileExtensionUnix) { - ASSERT_EQ ( BaseLib::getSuffixFromPath("file"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("/file"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("path/"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("/path/"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("path/file"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("/path/file"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("/path/path/file"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("/path/path/path/"), "" ); - - ASSERT_EQ ( BaseLib::getSuffixFromPath("file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("/file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("path.ext/"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("/path.ext/"), "" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("path/file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("/path/file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("/path/path/file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("/path/path/path.ext/"), "" ); - - ASSERT_EQ ( BaseLib::getSuffixFromPath("path.wrong/file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("/path.wrong/file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("/path.wrong0/path.wrong/file.ext"), "ext" ); - ASSERT_EQ ( BaseLib::getSuffixFromPath("/path.wrong0/path.wrong/path.ext/"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("file"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("/file"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("path/"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("/path/"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("path/file"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("/path/file"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("/path/path/file"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("/path/path/path/"), "" ); + + ASSERT_EQ ( BaseLib::getFileExtension("file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("/file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("path.ext/"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("/path.ext/"), "" ); + ASSERT_EQ ( BaseLib::getFileExtension("path/file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("/path/file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("/path/path/file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("/path/path/path.ext/"), "" ); + + ASSERT_EQ ( BaseLib::getFileExtension("path.wrong/file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("/path.wrong/file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("/path.wrong0/path.wrong/file.ext"), "ext" ); + ASSERT_EQ ( BaseLib::getFileExtension("/path.wrong0/path.wrong/path.ext/"), "" ); } TEST(BaseLib, CopyPathToFileNameWin)