From eef66cea5dc64b2536704a85abd949358344fec7 Mon Sep 17 00:00:00 2001
From: Dmitri Naumov <dmitri.naumov@ufz.de>
Date: Mon, 19 Aug 2019 13:52:53 +0200
Subject: [PATCH] google-explicit-constructor
initializer-list constructor should not be declared explicit.
Constructors that take a single std::initializer_list
parameter should also omit explicit, in order to support
copy-initialization.
---
Applications/DataExplorer/Base/CheckboxDelegate.h | 2 +-
Applications/DataExplorer/Base/ColorPickerPushButton.h | 2 +-
.../DataExplorer/Base/QNonScalableGraphicsTextItem.h | 6 +++---
Applications/DataExplorer/Base/QValueTooltipSlider.h | 2 +-
Applications/DataExplorer/Base/StrictDoubleValidator.h | 4 ++--
Applications/DataExplorer/Base/TreeModel.h | 2 +-
Applications/DataExplorer/Base/TreeModelIterator.h | 2 +-
.../DataExplorer/DataView/AddLayerToMeshDialog.h | 2 +-
Applications/DataExplorer/DataView/BaseItem.h | 4 ++--
Applications/DataExplorer/DataView/ColorTableModel.h | 2 +-
Applications/DataExplorer/DataView/ColorTableView.h | 7 +++++--
.../DataExplorer/DataView/CondFromRasterDialog.h | 4 ++--
.../DataExplorer/DataView/CreateStructuredGridDialog.h | 2 +-
.../DataExplorer/DataView/DataExplorerSettingsDialog.h | 2 +-
.../DataExplorer/DataView/DiagramView/DetailWindow.h | 9 +++++----
.../DataView/DiagramView/DiagramPrefsDialog.h | 9 +++++----
.../DataExplorer/DataView/DiagramView/DiagramScene.h | 4 ++--
.../DataExplorer/DataView/DiagramView/DiagramView.h | 4 ++--
Applications/DataExplorer/DataView/ElementTreeModel.h | 2 +-
Applications/DataExplorer/DataView/ElementTreeView.h | 2 +-
Applications/DataExplorer/DataView/FemConditionModel.h | 2 +-
Applications/DataExplorer/DataView/FemConditionView.h | 2 +-
Applications/DataExplorer/DataView/GEOModels.h | 3 ++-
Applications/DataExplorer/DataView/GMSHPrefsDialog.h | 3 ++-
.../DataExplorer/DataView/GeoOnMeshMappingDialog.h | 2 +-
Applications/DataExplorer/DataView/GeoTabWidget.h | 2 +-
Applications/DataExplorer/DataView/GeoTreeModel.h | 2 +-
Applications/DataExplorer/DataView/GeoTreeView.h | 2 +-
Applications/DataExplorer/DataView/LicenseDialog.h | 2 +-
Applications/DataExplorer/DataView/LineEditDialog.h | 4 ++--
.../DataExplorer/DataView/MergeGeometriesDialog.h | 4 ++--
Applications/DataExplorer/DataView/MeshAnalysisDialog.h | 2 +-
.../DataExplorer/DataView/MeshElementRemovalDialog.h | 4 ++--
Applications/DataExplorer/DataView/MeshLayerEditDialog.h | 3 ++-
Applications/DataExplorer/DataView/MeshMapping2DDialog.h | 2 +-
Applications/DataExplorer/DataView/MeshModel.h | 3 ++-
.../DataExplorer/DataView/MeshQualitySelectionDialog.h | 2 +-
Applications/DataExplorer/DataView/MeshTabWidget.h | 2 +-
Applications/DataExplorer/DataView/MeshValueEditDialog.h | 3 ++-
Applications/DataExplorer/DataView/MeshView.h | 2 +-
Applications/DataExplorer/DataView/ModellingTabWidget.h | 2 +-
Applications/DataExplorer/DataView/ProcessModel.h | 3 ++-
Applications/DataExplorer/DataView/ProcessView.h | 2 +-
Applications/DataExplorer/DataView/SaveMeshDialog.h | 3 ++-
Applications/DataExplorer/DataView/StationTabWidget.h | 2 +-
Applications/DataExplorer/DataView/StationTreeModel.h | 2 +-
Applications/DataExplorer/DataView/StationTreeView.h | 2 +-
Applications/DataExplorer/DataView/StratView/StratBar.h | 7 ++++---
.../DataExplorer/DataView/StratView/StratScene.h | 2 +-
Applications/DataExplorer/DataView/StratView/StratView.h | 2 +-
.../DataExplorer/DataView/StratView/StratWindow.h | 2 +-
.../DataExplorer/DataView/SurfaceExtractionDialog.h | 2 +-
Applications/DataExplorer/VtkVis/MeshFromRasterDialog.h | 2 +-
Applications/DataExplorer/VtkVis/VisualizationWidget.h | 2 +-
.../DataExplorer/VtkVis/VtkAlgorithmProperties.h | 2 +-
.../VtkVis/VtkCompositeColorByHeightFilter.h | 2 +-
.../VtkVis/VtkCompositeColormapToImageFilter.h | 2 +-
.../DataExplorer/VtkVis/VtkCompositeContourFilter.h | 2 +-
.../VtkVis/VtkCompositeElementSelectionFilter.h | 2 +-
Applications/DataExplorer/VtkVis/VtkCompositeFilter.h | 2 +-
.../DataExplorer/VtkVis/VtkCompositeGeoObjectFilter.h | 2 +-
.../VtkVis/VtkCompositeImageToCylindersFilter.h | 2 +-
.../VtkVis/VtkCompositeImageToPointCloudFilter.h | 2 +-
.../VtkVis/VtkCompositeImageToSurfacePointsFilter.h | 3 ++-
.../DataExplorer/VtkVis/VtkCompositeLineToTubeFilter.h | 2 +-
.../VtkVis/VtkCompositeNodeSelectionFilter.h | 2 +-
.../DataExplorer/VtkVis/VtkCompositePointToGlyphFilter.h | 2 +-
.../VtkVis/VtkCompositeTextureOnSurfaceFilter.h | 2 +-
.../DataExplorer/VtkVis/VtkCompositeThresholdFilter.h | 2 +-
Applications/DataExplorer/VtkVis/VtkVisPipeline.h | 2 +-
Applications/DataExplorer/VtkVis/VtkVisPipelineView.h | 2 +-
Applications/DataExplorer/VtkVis/VtkVisTabWidget.h | 2 +-
Applications/DataExplorer/mainwindow.h | 2 +-
Applications/Utils/OGSFileConverter/OGSFileConverter.h | 3 ++-
BaseLib/FileFinder.h | 2 +-
.../FractureModels/Permeability/ConstantPermeability.h | 2 +-
NumLib/NamedFunctionCaller.h | 2 +-
ProcessLib/VariableTransformation.h | 2 +-
78 files changed, 112 insertions(+), 97 deletions(-)
diff --git a/Applications/DataExplorer/Base/CheckboxDelegate.h b/Applications/DataExplorer/Base/CheckboxDelegate.h
index be4449ac56a..4d876b97d2a 100644
--- a/Applications/DataExplorer/Base/CheckboxDelegate.h
+++ b/Applications/DataExplorer/Base/CheckboxDelegate.h
@@ -31,7 +31,7 @@ class CheckboxDelegate : public QItemDelegate
public:
/// \brief Constructor
- CheckboxDelegate(QObject* parent = nullptr);
+ explicit CheckboxDelegate(QObject* parent = nullptr);
/// \brief Paints a checkbox. This overrides the default painting of a combo box.
void paint(QPainter* painter, const QStyleOptionViewItem& option,
diff --git a/Applications/DataExplorer/Base/ColorPickerPushButton.h b/Applications/DataExplorer/Base/ColorPickerPushButton.h
index 0e53871a4eb..040a9638d54 100644
--- a/Applications/DataExplorer/Base/ColorPickerPushButton.h
+++ b/Applications/DataExplorer/Base/ColorPickerPushButton.h
@@ -30,7 +30,7 @@ class ColorPickerPushButton : public QPushButton
Q_OBJECT
public:
- ColorPickerPushButton(QWidget* parent = nullptr);
+ explicit ColorPickerPushButton(QWidget* parent = nullptr);
public slots:
/// Calls the QColorDialog
diff --git a/Applications/DataExplorer/Base/QNonScalableGraphicsTextItem.h b/Applications/DataExplorer/Base/QNonScalableGraphicsTextItem.h
index 5c0c66f711d..80dd621ff93 100644
--- a/Applications/DataExplorer/Base/QNonScalableGraphicsTextItem.h
+++ b/Applications/DataExplorer/Base/QNonScalableGraphicsTextItem.h
@@ -24,9 +24,9 @@
class QNonScalableGraphicsTextItem : public QGraphicsTextItem
{
public:
- QNonScalableGraphicsTextItem(QGraphicsItem* parent = nullptr);
- QNonScalableGraphicsTextItem(const QString& text,
- QGraphicsItem* parent = nullptr);
+ explicit QNonScalableGraphicsTextItem(QGraphicsItem* parent = nullptr);
+ explicit QNonScalableGraphicsTextItem(const QString& text,
+ QGraphicsItem* parent = nullptr);
~QNonScalableGraphicsTextItem() override;
void paint(QPainter* painter,
diff --git a/Applications/DataExplorer/Base/QValueTooltipSlider.h b/Applications/DataExplorer/Base/QValueTooltipSlider.h
index ff41723c530..e62784b4ec7 100644
--- a/Applications/DataExplorer/Base/QValueTooltipSlider.h
+++ b/Applications/DataExplorer/Base/QValueTooltipSlider.h
@@ -23,7 +23,7 @@ class QValueTooltipSlider : public QSlider
Q_OBJECT
public:
- QValueTooltipSlider(QWidget* parent = nullptr);
+ explicit QValueTooltipSlider(QWidget* parent = nullptr);
public slots:
void setTooltipValue(int value);
diff --git a/Applications/DataExplorer/Base/StrictDoubleValidator.h b/Applications/DataExplorer/Base/StrictDoubleValidator.h
index d447e1d7ae5..6ad1e9d41b3 100644
--- a/Applications/DataExplorer/Base/StrictDoubleValidator.h
+++ b/Applications/DataExplorer/Base/StrictDoubleValidator.h
@@ -26,8 +26,8 @@ public:
QDoubleValidator( min, max, decimals, parent)
{}
- StrictDoubleValidator ( QObject* parent = nullptr) :
- QDoubleValidator( parent)
+ explicit StrictDoubleValidator(QObject* parent = nullptr)
+ : QDoubleValidator(parent)
{}
QValidator::State validate(QString& input, int& pos) const override
diff --git a/Applications/DataExplorer/Base/TreeModel.h b/Applications/DataExplorer/Base/TreeModel.h
index 2e063ce6c86..797f434229d 100644
--- a/Applications/DataExplorer/Base/TreeModel.h
+++ b/Applications/DataExplorer/Base/TreeModel.h
@@ -31,7 +31,7 @@ class TreeModel : public QAbstractItemModel
Q_OBJECT
public:
- TreeModel(QObject* parent = nullptr);
+ explicit TreeModel(QObject* parent = nullptr);
~TreeModel() override;
QVariant data(const QModelIndex& index, int role) const override;
diff --git a/Applications/DataExplorer/Base/TreeModelIterator.h b/Applications/DataExplorer/Base/TreeModelIterator.h
index d309e441271..9d0c91d84bb 100644
--- a/Applications/DataExplorer/Base/TreeModelIterator.h
+++ b/Applications/DataExplorer/Base/TreeModelIterator.h
@@ -35,7 +35,7 @@ class TreeModelIterator
{
public:
/// \brief Constructor. Provide a tree model to iterate over.
- TreeModelIterator(TreeModel* model);
+ explicit TreeModelIterator(TreeModel* model);
/// \brief Dereferencing the iterator to retrieve the current TreeItem.
/// Returns nullptr if the iterator is at the end.
diff --git a/Applications/DataExplorer/DataView/AddLayerToMeshDialog.h b/Applications/DataExplorer/DataView/AddLayerToMeshDialog.h
index 90398aae900..e6052c7fd5b 100644
--- a/Applications/DataExplorer/DataView/AddLayerToMeshDialog.h
+++ b/Applications/DataExplorer/DataView/AddLayerToMeshDialog.h
@@ -27,7 +27,7 @@ class AddLayerToMeshDialog : public QDialog, private Ui_AddLayerToMesh
Q_OBJECT
public:
- AddLayerToMeshDialog(QDialog* parent = nullptr);
+ explicit AddLayerToMeshDialog(QDialog* parent = nullptr);
/// Returns if the top layer button is selected (if false, bottom is selected).
bool isTopLayer() const { return this->topButton->isChecked(); };
diff --git a/Applications/DataExplorer/DataView/BaseItem.h b/Applications/DataExplorer/DataView/BaseItem.h
index d97437f142e..d76baa5c8ac 100644
--- a/Applications/DataExplorer/DataView/BaseItem.h
+++ b/Applications/DataExplorer/DataView/BaseItem.h
@@ -31,8 +31,8 @@ class Point;
class BaseItem
{
public:
- BaseItem(const QString& listName,
- const std::vector<GeoLib::Point*>* stations = nullptr)
+ explicit BaseItem(const QString& listName,
+ const std::vector<GeoLib::Point*>* stations = nullptr)
: _stations(stations), _vtkSource(VtkStationSource::New())
{
// create the vtk-object for 3d-visualisation of this list
diff --git a/Applications/DataExplorer/DataView/ColorTableModel.h b/Applications/DataExplorer/DataView/ColorTableModel.h
index 3b21f6261c6..45a619cf0a1 100644
--- a/Applications/DataExplorer/DataView/ColorTableModel.h
+++ b/Applications/DataExplorer/DataView/ColorTableModel.h
@@ -27,7 +27,7 @@ class ColorTableModel : public QAbstractTableModel
Q_OBJECT
public:
- ColorTableModel(
+ explicit ColorTableModel(
const std::map<std::string, DataHolderLib::Color*>& colorLookupTable,
QObject* parent = nullptr);
~ColorTableModel() override;
diff --git a/Applications/DataExplorer/DataView/ColorTableView.h b/Applications/DataExplorer/DataView/ColorTableView.h
index c25717050bf..3b231904f2e 100644
--- a/Applications/DataExplorer/DataView/ColorTableView.h
+++ b/Applications/DataExplorer/DataView/ColorTableView.h
@@ -25,7 +25,7 @@ class ColorTableView : public QTableView
public:
/// Constructor
- ColorTableView(QWidget* parent = nullptr);
+ explicit ColorTableView(QWidget* parent = nullptr);
};
/**
@@ -37,7 +37,10 @@ class ColorTableViewDelegate : public QItemDelegate
public:
/// Constructor
- ColorTableViewDelegate(QWidget* parent = nullptr) : QItemDelegate(parent) {}
+ explicit ColorTableViewDelegate(QWidget* parent = nullptr)
+ : QItemDelegate(parent)
+ {
+ }
/// Overwrites the paint-method to set user-defined properties instead of the default properties.
void paint(QPainter* painter, const QStyleOptionViewItem& option,
const QModelIndex& index) const override;
diff --git a/Applications/DataExplorer/DataView/CondFromRasterDialog.h b/Applications/DataExplorer/DataView/CondFromRasterDialog.h
index ade6924fd1d..5152b823bde 100644
--- a/Applications/DataExplorer/DataView/CondFromRasterDialog.h
+++ b/Applications/DataExplorer/DataView/CondFromRasterDialog.h
@@ -31,8 +31,8 @@ class CondFromRasterDialog : public QDialog, private Ui_CondFromRaster
Q_OBJECT
public:
- CondFromRasterDialog(std::vector<MeshLib::Mesh*> msh_vec,
- QDialog* parent = nullptr);
+ explicit CondFromRasterDialog(std::vector<MeshLib::Mesh*> msh_vec,
+ QDialog* parent = nullptr);
~CondFromRasterDialog() override;
private:
diff --git a/Applications/DataExplorer/DataView/CreateStructuredGridDialog.h b/Applications/DataExplorer/DataView/CreateStructuredGridDialog.h
index 56d6ec6c91c..5d17ca84f9f 100644
--- a/Applications/DataExplorer/DataView/CreateStructuredGridDialog.h
+++ b/Applications/DataExplorer/DataView/CreateStructuredGridDialog.h
@@ -27,7 +27,7 @@ class CreateStructuredGridDialog : public QDialog, private Ui_CreateStructuredGr
Q_OBJECT
public:
- CreateStructuredGridDialog(QDialog* parent = nullptr);
+ explicit CreateStructuredGridDialog(QDialog* parent = nullptr);
private slots:
void on_lineButton_toggled() const;
diff --git a/Applications/DataExplorer/DataView/DataExplorerSettingsDialog.h b/Applications/DataExplorer/DataView/DataExplorerSettingsDialog.h
index 613e5bab353..bf0a1ff6151 100644
--- a/Applications/DataExplorer/DataView/DataExplorerSettingsDialog.h
+++ b/Applications/DataExplorer/DataView/DataExplorerSettingsDialog.h
@@ -25,7 +25,7 @@ class DataExplorerSettingsDialog : public QDialog, private Ui_DataExplorerSettin
Q_OBJECT
public:
- DataExplorerSettingsDialog(QDialog* parent = nullptr);
+ explicit DataExplorerSettingsDialog(QDialog* parent = nullptr);
~DataExplorerSettingsDialog() override;
private slots:
diff --git a/Applications/DataExplorer/DataView/DiagramView/DetailWindow.h b/Applications/DataExplorer/DataView/DiagramView/DetailWindow.h
index 35ec29d2c4f..ee7a563e681 100644
--- a/Applications/DataExplorer/DataView/DiagramView/DetailWindow.h
+++ b/Applications/DataExplorer/DataView/DiagramView/DetailWindow.h
@@ -27,22 +27,23 @@ class DetailWindow : public QWidget, private Ui_DetailWindow
public:
/// Creates an empty diagram window.
- DetailWindow(QWidget* parent = nullptr);
+ explicit DetailWindow(QWidget* parent = nullptr);
/**
* Creates a window containing a diagram.
* \param filename ASCII file containing x and y values for the graph to be displayed.
* \param parent The parent QWidget.
*/
- DetailWindow(QString filename, QWidget* parent = nullptr);
+ explicit DetailWindow(QString filename, QWidget* parent = nullptr);
/**
* Creates a window containing a diagram
* \param list A QDiagramList containing all the data points and necessary metainformation for a graph to be displayed
* \param parent The parent QWidget.
*/
- DetailWindow(DiagramList* list, QWidget* parent = nullptr);
+ explicit DetailWindow(DiagramList* list, QWidget* parent = nullptr);
- DetailWindow(std::vector<std::size_t> data, QWidget* parent = nullptr);
+ explicit DetailWindow(std::vector<std::size_t> data,
+ QWidget* parent = nullptr);
~DetailWindow() override;
diff --git a/Applications/DataExplorer/DataView/DiagramView/DiagramPrefsDialog.h b/Applications/DataExplorer/DataView/DiagramView/DiagramPrefsDialog.h
index 0fe9041baa2..9ead7c8b11d 100644
--- a/Applications/DataExplorer/DataView/DiagramView/DiagramPrefsDialog.h
+++ b/Applications/DataExplorer/DataView/DiagramView/DiagramPrefsDialog.h
@@ -58,7 +58,8 @@ public:
* \param stn The station object associated the diagram.
* \param parent The parent QDialog.
*/
- DiagramPrefsDialog(GeoLib::Station* stn, QDialog* parent = nullptr);
+ explicit DiagramPrefsDialog(GeoLib::Station* stn,
+ QDialog* parent = nullptr);
/**
* Opens a new dialog and automatically reads data from the specified file. The diagram is not associated
@@ -67,9 +68,9 @@ public:
* \param[out] window Returns the created DetailWindow.
* \param parent The parent QDialog.
*/
- DiagramPrefsDialog(const QString& filename,
- DetailWindow* window = nullptr,
- QDialog* parent = nullptr);
+ explicit DiagramPrefsDialog(const QString& filename,
+ DetailWindow* window = nullptr,
+ QDialog* parent = nullptr);
~DiagramPrefsDialog() override;
diff --git a/Applications/DataExplorer/DataView/DiagramView/DiagramScene.h b/Applications/DataExplorer/DataView/DiagramView/DiagramScene.h
index 1c34c20b224..6c8cdb06560 100644
--- a/Applications/DataExplorer/DataView/DiagramView/DiagramScene.h
+++ b/Applications/DataExplorer/DataView/DiagramView/DiagramScene.h
@@ -28,8 +28,8 @@ class QDateTime;
class DiagramScene : public QGraphicsScene
{
public:
- DiagramScene(QObject* parent = nullptr);
- DiagramScene(DiagramList* list, QObject* parent = nullptr);
+ explicit DiagramScene(QObject* parent = nullptr);
+ explicit DiagramScene(DiagramList* list, QObject* parent = nullptr);
~DiagramScene() override;
QArrow* addArrow(qreal length, qreal angle, QPen& pen);
diff --git a/Applications/DataExplorer/DataView/DiagramView/DiagramView.h b/Applications/DataExplorer/DataView/DiagramView/DiagramView.h
index 5711e5e2e1e..a5956d093d5 100644
--- a/Applications/DataExplorer/DataView/DiagramView/DiagramView.h
+++ b/Applications/DataExplorer/DataView/DiagramView/DiagramView.h
@@ -31,13 +31,13 @@ public:
/**
* Creates an empty view.
*/
- DiagramView(QWidget* parent = nullptr);
+ explicit DiagramView(QWidget* parent = nullptr);
/**
* Creates a view already containing a graph
* \param list Contains a list of data points and metainformation to be displayed by the scene.
* \param parent The parent QWidget.
*/
- DiagramView(DiagramList* list, QWidget* parent = nullptr);
+ explicit DiagramView(DiagramList* list, QWidget* parent = nullptr);
~DiagramView() override;
/// Adds a new graph to the scene.
diff --git a/Applications/DataExplorer/DataView/ElementTreeModel.h b/Applications/DataExplorer/DataView/ElementTreeModel.h
index 3acf2ef0029..ac421d75220 100644
--- a/Applications/DataExplorer/DataView/ElementTreeModel.h
+++ b/Applications/DataExplorer/DataView/ElementTreeModel.h
@@ -32,7 +32,7 @@ class ElementTreeModel : public TreeModel
Q_OBJECT
public:
- ElementTreeModel(QObject* parent = nullptr);
+ explicit ElementTreeModel(QObject* parent = nullptr);
~ElementTreeModel() override;
vtkUnstructuredGridAlgorithm const* getSource() const { return _mesh_source; };
diff --git a/Applications/DataExplorer/DataView/ElementTreeView.h b/Applications/DataExplorer/DataView/ElementTreeView.h
index 821b6ff5685..f5d7f98f595 100644
--- a/Applications/DataExplorer/DataView/ElementTreeView.h
+++ b/Applications/DataExplorer/DataView/ElementTreeView.h
@@ -26,7 +26,7 @@ class ElementTreeView : public QTreeView
public:
/// Constructor
- ElementTreeView(QWidget* parent = nullptr);
+ explicit ElementTreeView(QWidget* parent = nullptr);
public slots:
void updateView();
diff --git a/Applications/DataExplorer/DataView/FemConditionModel.h b/Applications/DataExplorer/DataView/FemConditionModel.h
index d6b21c0ac67..06cf5942595 100644
--- a/Applications/DataExplorer/DataView/FemConditionModel.h
+++ b/Applications/DataExplorer/DataView/FemConditionModel.h
@@ -22,7 +22,7 @@ class FemConditionModel : public TreeModel
Q_OBJECT
public:
- FemConditionModel(QObject* parent = nullptr);
+ explicit FemConditionModel(QObject* parent = nullptr);
int columnCount(
const QModelIndex& /*parent*/ = QModelIndex()) const override
diff --git a/Applications/DataExplorer/DataView/FemConditionView.h b/Applications/DataExplorer/DataView/FemConditionView.h
index 898855d0bc4..43d49b406b8 100644
--- a/Applications/DataExplorer/DataView/FemConditionView.h
+++ b/Applications/DataExplorer/DataView/FemConditionView.h
@@ -24,7 +24,7 @@ class FemConditionView final : public QTreeView
public:
/// Constructor
- FemConditionView(QWidget* parent = nullptr);
+ explicit FemConditionView(QWidget* parent = nullptr);
public slots:
void updateView();
diff --git a/Applications/DataExplorer/DataView/GEOModels.h b/Applications/DataExplorer/DataView/GEOModels.h
index 525cc21cea6..91ae62d9a8d 100644
--- a/Applications/DataExplorer/DataView/GEOModels.h
+++ b/Applications/DataExplorer/DataView/GEOModels.h
@@ -38,7 +38,8 @@ class GEOModels : public QObject
Q_OBJECT
public:
- GEOModels(GeoLib::GEOObjects& geo_objects, QObject* parent = nullptr);
+ explicit GEOModels(GeoLib::GEOObjects& geo_objects,
+ QObject* parent = nullptr);
~GEOModels() override;
GeoTreeModel* getGeoModel() { return _geoModel; }
diff --git a/Applications/DataExplorer/DataView/GMSHPrefsDialog.h b/Applications/DataExplorer/DataView/GMSHPrefsDialog.h
index 79ea7a48642..86acd8c8780 100644
--- a/Applications/DataExplorer/DataView/GMSHPrefsDialog.h
+++ b/Applications/DataExplorer/DataView/GMSHPrefsDialog.h
@@ -32,7 +32,8 @@ class GMSHPrefsDialog : public QDialog, private Ui_GMSHPrefs
Q_OBJECT
public:
- GMSHPrefsDialog(GeoLib::GEOObjects const& geoObjects, QDialog* parent = nullptr);
+ explicit GMSHPrefsDialog(GeoLib::GEOObjects const& geoObjects,
+ QDialog* parent = nullptr);
~GMSHPrefsDialog() override;
private:
diff --git a/Applications/DataExplorer/DataView/GeoOnMeshMappingDialog.h b/Applications/DataExplorer/DataView/GeoOnMeshMappingDialog.h
index 18775962dd4..a38a9953a5b 100644
--- a/Applications/DataExplorer/DataView/GeoOnMeshMappingDialog.h
+++ b/Applications/DataExplorer/DataView/GeoOnMeshMappingDialog.h
@@ -31,7 +31,7 @@ class GeoOnMeshMappingDialog : public QDialog, private Ui_GeoOnMeshMapping
Q_OBJECT
public:
- GeoOnMeshMappingDialog(
+ explicit GeoOnMeshMappingDialog(
std::vector<std::unique_ptr<MeshLib::Mesh>> const& mesh_vec,
QDialog* parent = nullptr);
~GeoOnMeshMappingDialog() override;
diff --git a/Applications/DataExplorer/DataView/GeoTabWidget.h b/Applications/DataExplorer/DataView/GeoTabWidget.h
index 28e41780b88..9d51f344cee 100644
--- a/Applications/DataExplorer/DataView/GeoTabWidget.h
+++ b/Applications/DataExplorer/DataView/GeoTabWidget.h
@@ -25,7 +25,7 @@ class GeoTabWidget : public QWidget, public Ui_GeoTabWidgetBase
Q_OBJECT
public:
- GeoTabWidget(QWidget* parent = nullptr);
+ explicit GeoTabWidget(QWidget* parent = nullptr);
private:
diff --git a/Applications/DataExplorer/DataView/GeoTreeModel.h b/Applications/DataExplorer/DataView/GeoTreeModel.h
index e6840e701c8..7f861ab7e9f 100644
--- a/Applications/DataExplorer/DataView/GeoTreeModel.h
+++ b/Applications/DataExplorer/DataView/GeoTreeModel.h
@@ -42,7 +42,7 @@ class GeoTreeModel : public TreeModel
Q_OBJECT
public:
- GeoTreeModel(QObject* parent = nullptr);
+ explicit GeoTreeModel(QObject* parent = nullptr);
~GeoTreeModel() override;
/**
diff --git a/Applications/DataExplorer/DataView/GeoTreeView.h b/Applications/DataExplorer/DataView/GeoTreeView.h
index 5b2d2df63f8..609d51213f8 100644
--- a/Applications/DataExplorer/DataView/GeoTreeView.h
+++ b/Applications/DataExplorer/DataView/GeoTreeView.h
@@ -31,7 +31,7 @@ class GeoTreeView : public QTreeView
public:
/// Constructor
- GeoTreeView(QWidget* parent = nullptr);
+ explicit GeoTreeView(QWidget* parent = nullptr);
/// Update the view to visualise changes made to the underlying data
void updateView();
diff --git a/Applications/DataExplorer/DataView/LicenseDialog.h b/Applications/DataExplorer/DataView/LicenseDialog.h
index e3f8f83a0da..23e44a25a07 100644
--- a/Applications/DataExplorer/DataView/LicenseDialog.h
+++ b/Applications/DataExplorer/DataView/LicenseDialog.h
@@ -25,7 +25,7 @@ class LicenseDialog : public QDialog, private Ui_License
Q_OBJECT
public:
- LicenseDialog(QDialog* parent = nullptr);
+ explicit LicenseDialog(QDialog* parent = nullptr);
~LicenseDialog() override = default;
;
diff --git a/Applications/DataExplorer/DataView/LineEditDialog.h b/Applications/DataExplorer/DataView/LineEditDialog.h
index cc6df5993a9..ae9f7da773c 100644
--- a/Applications/DataExplorer/DataView/LineEditDialog.h
+++ b/Applications/DataExplorer/DataView/LineEditDialog.h
@@ -31,8 +31,8 @@ class LineEditDialog : public QDialog, private Ui_LineEdit
Q_OBJECT
public:
- LineEditDialog(const GeoLib::PolylineVec& ply_vec,
- QDialog* parent = nullptr);
+ explicit LineEditDialog(const GeoLib::PolylineVec& ply_vec,
+ QDialog* parent = nullptr);
~LineEditDialog() override;
private:
diff --git a/Applications/DataExplorer/DataView/MergeGeometriesDialog.h b/Applications/DataExplorer/DataView/MergeGeometriesDialog.h
index 15e2adf049c..296517ad1ac 100644
--- a/Applications/DataExplorer/DataView/MergeGeometriesDialog.h
+++ b/Applications/DataExplorer/DataView/MergeGeometriesDialog.h
@@ -32,8 +32,8 @@ class MergeGeometriesDialog : public QDialog, private Ui_MergeGeometries
Q_OBJECT
public:
- MergeGeometriesDialog(GeoLib::GEOObjects& geoObjects,
- QDialog* parent = nullptr);
+ explicit MergeGeometriesDialog(GeoLib::GEOObjects& geoObjects,
+ QDialog* parent = nullptr);
~MergeGeometriesDialog() override;
/// Returns a vector of selected geometries
diff --git a/Applications/DataExplorer/DataView/MeshAnalysisDialog.h b/Applications/DataExplorer/DataView/MeshAnalysisDialog.h
index 0da4a578ba4..adfc8ab0e50 100644
--- a/Applications/DataExplorer/DataView/MeshAnalysisDialog.h
+++ b/Applications/DataExplorer/DataView/MeshAnalysisDialog.h
@@ -33,7 +33,7 @@ class MeshAnalysisDialog : public QDialog, private Ui_MeshAnalysis
Q_OBJECT
public:
- MeshAnalysisDialog(
+ explicit MeshAnalysisDialog(
std::vector<std::unique_ptr<MeshLib::Mesh>> const& mesh_vec,
QDialog* parent = nullptr);
~MeshAnalysisDialog() override;
diff --git a/Applications/DataExplorer/DataView/MeshElementRemovalDialog.h b/Applications/DataExplorer/DataView/MeshElementRemovalDialog.h
index 93b51d2248f..0017aabf9eb 100644
--- a/Applications/DataExplorer/DataView/MeshElementRemovalDialog.h
+++ b/Applications/DataExplorer/DataView/MeshElementRemovalDialog.h
@@ -39,8 +39,8 @@ class MeshElementRemovalDialog : public QDialog, private Ui_MeshElementRemoval
Q_OBJECT
public:
- MeshElementRemovalDialog(DataHolderLib::Project const& project,
- QDialog* parent = nullptr);
+ explicit MeshElementRemovalDialog(DataHolderLib::Project const& project,
+ QDialog* parent = nullptr);
~MeshElementRemovalDialog() override;
private slots:
diff --git a/Applications/DataExplorer/DataView/MeshLayerEditDialog.h b/Applications/DataExplorer/DataView/MeshLayerEditDialog.h
index 2d951120004..fe73025d53b 100644
--- a/Applications/DataExplorer/DataView/MeshLayerEditDialog.h
+++ b/Applications/DataExplorer/DataView/MeshLayerEditDialog.h
@@ -40,7 +40,8 @@ class MeshLayerEditDialog : public QDialog, private Ui_MeshLayerEdit
Q_OBJECT
public:
- MeshLayerEditDialog(const MeshLib::Mesh* mesh, QDialog* parent = nullptr);
+ explicit MeshLayerEditDialog(const MeshLib::Mesh* mesh,
+ QDialog* parent = nullptr);
~MeshLayerEditDialog() override;
private:
diff --git a/Applications/DataExplorer/DataView/MeshMapping2DDialog.h b/Applications/DataExplorer/DataView/MeshMapping2DDialog.h
index 112f7bacd68..74e89434fd2 100644
--- a/Applications/DataExplorer/DataView/MeshMapping2DDialog.h
+++ b/Applications/DataExplorer/DataView/MeshMapping2DDialog.h
@@ -23,7 +23,7 @@ class MeshMapping2DDialog : public QDialog, private Ui_MeshMapping2D
Q_OBJECT
public:
- MeshMapping2DDialog(QDialog* parent = nullptr);
+ explicit MeshMapping2DDialog(QDialog* parent = nullptr);
bool useRasterMapping() const { return this->rasterValueButton->isChecked(); }
bool useStaticMapping() const { return this->staticValueButton->isChecked(); }
diff --git a/Applications/DataExplorer/DataView/MeshModel.h b/Applications/DataExplorer/DataView/MeshModel.h
index 684896487a6..a00b4f1e57d 100644
--- a/Applications/DataExplorer/DataView/MeshModel.h
+++ b/Applications/DataExplorer/DataView/MeshModel.h
@@ -39,7 +39,8 @@ class MeshModel : public TreeModel
Q_OBJECT
public:
- MeshModel(DataHolderLib::Project& project, QObject* parent = nullptr);
+ explicit MeshModel(DataHolderLib::Project& project,
+ QObject* parent = nullptr);
/// Adds a new mesh
void addMesh(std::unique_ptr<MeshLib::Mesh> mesh);
diff --git a/Applications/DataExplorer/DataView/MeshQualitySelectionDialog.h b/Applications/DataExplorer/DataView/MeshQualitySelectionDialog.h
index 76f2c77408d..0743748f073 100644
--- a/Applications/DataExplorer/DataView/MeshQualitySelectionDialog.h
+++ b/Applications/DataExplorer/DataView/MeshQualitySelectionDialog.h
@@ -29,7 +29,7 @@ class MeshQualitySelectionDialog : public QDialog, private Ui_MeshQualitySelecti
Q_OBJECT
public:
- MeshQualitySelectionDialog(QDialog* parent = nullptr);
+ explicit MeshQualitySelectionDialog(QDialog* parent = nullptr);
~MeshQualitySelectionDialog() override;
/// Returns selected metric
diff --git a/Applications/DataExplorer/DataView/MeshTabWidget.h b/Applications/DataExplorer/DataView/MeshTabWidget.h
index 74827ed9cb1..97700a0dc5f 100644
--- a/Applications/DataExplorer/DataView/MeshTabWidget.h
+++ b/Applications/DataExplorer/DataView/MeshTabWidget.h
@@ -25,7 +25,7 @@ class MeshTabWidget : public QWidget, public Ui_MeshTabWidgetBase
Q_OBJECT
public:
- MeshTabWidget(QWidget* parent = nullptr);
+ explicit MeshTabWidget(QWidget* parent = nullptr);
private slots:
void enableSaveButton(bool enable) { this->saveMeshPushButton->setEnabled(enable); };
diff --git a/Applications/DataExplorer/DataView/MeshValueEditDialog.h b/Applications/DataExplorer/DataView/MeshValueEditDialog.h
index c38791d73ea..c394d709d5d 100644
--- a/Applications/DataExplorer/DataView/MeshValueEditDialog.h
+++ b/Applications/DataExplorer/DataView/MeshValueEditDialog.h
@@ -31,7 +31,8 @@ class MeshValueEditDialog : public QDialog, private Ui_MeshValueEdit
public:
/// Constructor for creating a new FEM condition.
- MeshValueEditDialog(MeshLib::Mesh* mesh, QDialog* parent = nullptr);
+ explicit MeshValueEditDialog(MeshLib::Mesh* mesh,
+ QDialog* parent = nullptr);
~MeshValueEditDialog() override;
diff --git a/Applications/DataExplorer/DataView/MeshView.h b/Applications/DataExplorer/DataView/MeshView.h
index 2baac358216..ba20c7f6b6d 100644
--- a/Applications/DataExplorer/DataView/MeshView.h
+++ b/Applications/DataExplorer/DataView/MeshView.h
@@ -37,7 +37,7 @@ class MeshView : public QTreeView
Q_OBJECT
public:
- MeshView(QWidget* parent = nullptr);
+ explicit MeshView(QWidget* parent = nullptr);
~MeshView() override;
public slots:
diff --git a/Applications/DataExplorer/DataView/ModellingTabWidget.h b/Applications/DataExplorer/DataView/ModellingTabWidget.h
index 19aadec186d..9fa2939b27f 100644
--- a/Applications/DataExplorer/DataView/ModellingTabWidget.h
+++ b/Applications/DataExplorer/DataView/ModellingTabWidget.h
@@ -25,7 +25,7 @@ class ModellingTabWidget : public QWidget, public Ui_ModellingTabWidgetBase
Q_OBJECT
public:
- ModellingTabWidget(QWidget* parent = nullptr);
+ explicit ModellingTabWidget(QWidget* parent = nullptr);
private slots:
diff --git a/Applications/DataExplorer/DataView/ProcessModel.h b/Applications/DataExplorer/DataView/ProcessModel.h
index dc505bc6bda..6a4a61cc74d 100644
--- a/Applications/DataExplorer/DataView/ProcessModel.h
+++ b/Applications/DataExplorer/DataView/ProcessModel.h
@@ -37,7 +37,8 @@ class ProcessModel final : public TreeModel
Q_OBJECT
public:
- ProcessModel(DataHolderLib::Project& project, QObject* parent = nullptr);
+ explicit ProcessModel(DataHolderLib::Project& project,
+ QObject* parent = nullptr);
int columnCount(const QModelIndex& parent = QModelIndex()) const override;
diff --git a/Applications/DataExplorer/DataView/ProcessView.h b/Applications/DataExplorer/DataView/ProcessView.h
index b47f947ddda..d36bac7cfe1 100644
--- a/Applications/DataExplorer/DataView/ProcessView.h
+++ b/Applications/DataExplorer/DataView/ProcessView.h
@@ -32,7 +32,7 @@ class ProcessView final : public QTreeView
public:
/// Constructor
- ProcessView(QWidget* parent = nullptr);
+ explicit ProcessView(QWidget* parent = nullptr);
/// Update the view to visualise changes made to the underlying data
void updateView();
diff --git a/Applications/DataExplorer/DataView/SaveMeshDialog.h b/Applications/DataExplorer/DataView/SaveMeshDialog.h
index f3451474796..54d3d494811 100644
--- a/Applications/DataExplorer/DataView/SaveMeshDialog.h
+++ b/Applications/DataExplorer/DataView/SaveMeshDialog.h
@@ -29,7 +29,8 @@ class SaveMeshDialog : public QDialog, private Ui_SaveMesh
Q_OBJECT
public:
- SaveMeshDialog(MeshLib::Mesh const& mesh, QDialog* parent = nullptr);
+ explicit SaveMeshDialog(MeshLib::Mesh const& mesh,
+ QDialog* parent = nullptr);
~SaveMeshDialog() override = default;
private slots:
diff --git a/Applications/DataExplorer/DataView/StationTabWidget.h b/Applications/DataExplorer/DataView/StationTabWidget.h
index 6ca268f68e4..16ba71f93f4 100644
--- a/Applications/DataExplorer/DataView/StationTabWidget.h
+++ b/Applications/DataExplorer/DataView/StationTabWidget.h
@@ -25,7 +25,7 @@ class StationTabWidget : public QWidget, public Ui_StationTabWidgetBase
Q_OBJECT
public:
- StationTabWidget(QWidget* parent = nullptr);
+ explicit StationTabWidget(QWidget* parent = nullptr);
private:
diff --git a/Applications/DataExplorer/DataView/StationTreeModel.h b/Applications/DataExplorer/DataView/StationTreeModel.h
index ba99cfddd0c..44c60e8692c 100644
--- a/Applications/DataExplorer/DataView/StationTreeModel.h
+++ b/Applications/DataExplorer/DataView/StationTreeModel.h
@@ -44,7 +44,7 @@ class StationTreeModel : public TreeModel
Q_OBJECT
public:
- StationTreeModel(QObject* parent = nullptr);
+ explicit StationTreeModel(QObject* parent = nullptr);
~StationTreeModel() override;
void addStationList(QString listName, const std::vector<GeoLib::Point*>* stations);
diff --git a/Applications/DataExplorer/DataView/StationTreeView.h b/Applications/DataExplorer/DataView/StationTreeView.h
index 0094c07569e..159ec9025e8 100644
--- a/Applications/DataExplorer/DataView/StationTreeView.h
+++ b/Applications/DataExplorer/DataView/StationTreeView.h
@@ -30,7 +30,7 @@ class StationTreeView : public QTreeView
public:
/// Constructor
- StationTreeView(QWidget* parent = nullptr);
+ explicit StationTreeView(QWidget* parent = nullptr);
/// Update the view to visualise changes made to the underlying data
void updateView();
diff --git a/Applications/DataExplorer/DataView/StratView/StratBar.h b/Applications/DataExplorer/DataView/StratView/StratBar.h
index 7155142d947..28736f78e29 100644
--- a/Applications/DataExplorer/DataView/StratView/StratBar.h
+++ b/Applications/DataExplorer/DataView/StratView/StratBar.h
@@ -35,9 +35,10 @@ public:
* \param stratColors A color map.
* \param parent The parent QGraphicsItem.
*/
- StratBar(GeoLib::StationBorehole* station,
- std::map<std::string, DataHolderLib::Color>* stratColors = nullptr,
- QGraphicsItem* parent = nullptr);
+ explicit StratBar(
+ GeoLib::StationBorehole* station,
+ std::map<std::string, DataHolderLib::Color>* stratColors = nullptr,
+ QGraphicsItem* parent = nullptr);
~StratBar() override = default;
/// Returns the bounding rectangle of the bar.
diff --git a/Applications/DataExplorer/DataView/StratView/StratScene.h b/Applications/DataExplorer/DataView/StratView/StratScene.h
index 8ab6461a1bf..e4f19dbe2ba 100644
--- a/Applications/DataExplorer/DataView/StratView/StratScene.h
+++ b/Applications/DataExplorer/DataView/StratView/StratScene.h
@@ -29,7 +29,7 @@ class StratScene : public QGraphicsScene
{
public:
/// Constructor
- StratScene(
+ explicit StratScene(
GeoLib::StationBorehole* station,
std::map<std::string, DataHolderLib::Color>* stratColors = nullptr,
QObject* parent = nullptr);
diff --git a/Applications/DataExplorer/DataView/StratView/StratView.h b/Applications/DataExplorer/DataView/StratView/StratView.h
index 0fc64a60436..32176d3d9f2 100644
--- a/Applications/DataExplorer/DataView/StratView/StratView.h
+++ b/Applications/DataExplorer/DataView/StratView/StratView.h
@@ -34,7 +34,7 @@ public:
/**
* Creates an empty view.
*/
- StratView(QWidget* parent = nullptr) { Q_UNUSED(parent); }
+ explicit StratView(QWidget* parent = nullptr) { Q_UNUSED(parent); }
~StratView() override;
/// Sets the Borehole whose data should be visualised.
diff --git a/Applications/DataExplorer/DataView/StratView/StratWindow.h b/Applications/DataExplorer/DataView/StratView/StratWindow.h
index 3e44de0bd85..f1ba17558cf 100644
--- a/Applications/DataExplorer/DataView/StratView/StratWindow.h
+++ b/Applications/DataExplorer/DataView/StratView/StratWindow.h
@@ -36,7 +36,7 @@ public:
* \param stratColors A color map.
* \param parent The parent QWidget.
*/
- StratWindow(
+ explicit StratWindow(
GeoLib::StationBorehole* station,
std::map<std::string, DataHolderLib::Color>* stratColors = nullptr,
QWidget* parent = nullptr);
diff --git a/Applications/DataExplorer/DataView/SurfaceExtractionDialog.h b/Applications/DataExplorer/DataView/SurfaceExtractionDialog.h
index 936ed97f4e4..beea7116aac 100644
--- a/Applications/DataExplorer/DataView/SurfaceExtractionDialog.h
+++ b/Applications/DataExplorer/DataView/SurfaceExtractionDialog.h
@@ -31,7 +31,7 @@ class SurfaceExtractionDialog : public QDialog, private Ui_SurfaceExtraction
Q_OBJECT
public:
- SurfaceExtractionDialog(QDialog* parent = nullptr);
+ explicit SurfaceExtractionDialog(QDialog* parent = nullptr);
~SurfaceExtractionDialog() override = default;
int getTolerance() const { return _tolerance; }
diff --git a/Applications/DataExplorer/VtkVis/MeshFromRasterDialog.h b/Applications/DataExplorer/VtkVis/MeshFromRasterDialog.h
index 0ea29d3eb33..a3fe99cd8e7 100644
--- a/Applications/DataExplorer/VtkVis/MeshFromRasterDialog.h
+++ b/Applications/DataExplorer/VtkVis/MeshFromRasterDialog.h
@@ -34,7 +34,7 @@ class MeshFromRasterDialog : public QDialog, private Ui_MeshFromRaster
public:
/// Constructor
- MeshFromRasterDialog(QDialog* parent = nullptr);
+ explicit MeshFromRasterDialog(QDialog* parent = nullptr);
~MeshFromRasterDialog() override;
std::string getMeshName() const { return _mesh_name; }
diff --git a/Applications/DataExplorer/VtkVis/VisualizationWidget.h b/Applications/DataExplorer/VtkVis/VisualizationWidget.h
index c0155df2592..da506e21cfa 100644
--- a/Applications/DataExplorer/VtkVis/VisualizationWidget.h
+++ b/Applications/DataExplorer/VtkVis/VisualizationWidget.h
@@ -32,7 +32,7 @@ class VisualizationWidget : public QWidget, public Ui_VisualizationWidgetBase
public:
/// @brief Constructor.
- VisualizationWidget(QWidget* parent = nullptr);
+ explicit VisualizationWidget(QWidget* parent = nullptr);
/// @brief Destructor.
~VisualizationWidget() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkAlgorithmProperties.h b/Applications/DataExplorer/VtkVis/VtkAlgorithmProperties.h
index 7bfc0b43489..af0ff3cbbab 100644
--- a/Applications/DataExplorer/VtkVis/VtkAlgorithmProperties.h
+++ b/Applications/DataExplorer/VtkVis/VtkAlgorithmProperties.h
@@ -140,7 +140,7 @@ class VtkAlgorithmProperties : public QObject
public:
/// Constructor (sets default values)
- VtkAlgorithmProperties(QObject* parent = nullptr);
+ explicit VtkAlgorithmProperties(QObject* parent = nullptr);
~VtkAlgorithmProperties() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeColorByHeightFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeColorByHeightFilter.h
index 4c6f07ea96a..c69e3209e22 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositeColorByHeightFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositeColorByHeightFilter.h
@@ -22,7 +22,7 @@ class vtkSphereSource;
class VtkCompositeColorByHeightFilter : public VtkCompositeFilter
{
public:
- VtkCompositeColorByHeightFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositeColorByHeightFilter(vtkAlgorithm* inputAlgorithm);
~VtkCompositeColorByHeightFilter() override = default;
void init() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeColormapToImageFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeColormapToImageFilter.h
index a63f01860ce..8800983270b 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositeColormapToImageFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositeColormapToImageFilter.h
@@ -20,7 +20,7 @@
class VtkCompositeColormapToImageFilter : public VtkCompositeFilter
{
public:
- VtkCompositeColormapToImageFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositeColormapToImageFilter(vtkAlgorithm* inputAlgorithm);
~VtkCompositeColormapToImageFilter() override;
void init() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeContourFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeContourFilter.h
index 0a02824772d..493d8f83254 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositeContourFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositeContourFilter.h
@@ -22,7 +22,7 @@
class VtkCompositeContourFilter : public VtkCompositeFilter
{
public:
- VtkCompositeContourFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositeContourFilter(vtkAlgorithm* inputAlgorithm);
~VtkCompositeContourFilter() override;
void init() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeElementSelectionFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeElementSelectionFilter.h
index cd364f986f1..c61e716312b 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositeElementSelectionFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositeElementSelectionFilter.h
@@ -26,7 +26,7 @@ class VtkColorLookupTable;
class VtkCompositeElementSelectionFilter : public VtkCompositeFilter
{
public:
- VtkCompositeElementSelectionFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositeElementSelectionFilter(vtkAlgorithm* inputAlgorithm);
~VtkCompositeElementSelectionFilter() override = default;
void init() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeFilter.h
index 3414bf34a6c..91e073ab982 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositeFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositeFilter.h
@@ -43,7 +43,7 @@ class VtkCompositeFilter : public VtkAlgorithmProperties
public:
/// @brief Constructor.
/// @param inputAlgorithm The algorithm to attach this filter to.
- VtkCompositeFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositeFilter(vtkAlgorithm* inputAlgorithm);
/// @brief Destructor.
~VtkCompositeFilter() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeGeoObjectFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeGeoObjectFilter.h
index 3aa3644e055..0ab673b6e2a 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositeGeoObjectFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositeGeoObjectFilter.h
@@ -23,7 +23,7 @@ class vtkThreshold;
class VtkCompositeGeoObjectFilter : public VtkCompositeFilter
{
public:
- VtkCompositeGeoObjectFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositeGeoObjectFilter(vtkAlgorithm* inputAlgorithm);
~VtkCompositeGeoObjectFilter() override;
void init() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeImageToCylindersFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeImageToCylindersFilter.h
index 2c00445c3cd..a4b140976b1 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositeImageToCylindersFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositeImageToCylindersFilter.h
@@ -24,7 +24,7 @@ class VtkImageDataToLinePolyDataFilter;
class VtkCompositeImageToCylindersFilter : public VtkCompositeFilter
{
public:
- VtkCompositeImageToCylindersFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositeImageToCylindersFilter(vtkAlgorithm* inputAlgorithm);
~VtkCompositeImageToCylindersFilter() override;
void init() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeImageToPointCloudFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeImageToPointCloudFilter.h
index e9ffec6ed5f..17d5f6e0397 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositeImageToPointCloudFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositeImageToPointCloudFilter.h
@@ -16,7 +16,7 @@ class VtkImageDataToPointCloudFilter;
class VtkCompositeImageToPointCloudFilter : public VtkCompositeFilter
{
public:
- VtkCompositeImageToPointCloudFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositeImageToPointCloudFilter(vtkAlgorithm* inputAlgorithm);
~VtkCompositeImageToPointCloudFilter() override = default;
void init() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeImageToSurfacePointsFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeImageToSurfacePointsFilter.h
index f53faf66a40..e4576d19c56 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositeImageToSurfacePointsFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositeImageToSurfacePointsFilter.h
@@ -16,7 +16,8 @@ class VtkImageDataToSurfacePointsFilter;
class VtkCompositeImageToSurfacePointsFilter : public VtkCompositeFilter
{
public:
- VtkCompositeImageToSurfacePointsFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositeImageToSurfacePointsFilter(
+ vtkAlgorithm* inputAlgorithm);
~VtkCompositeImageToSurfacePointsFilter() override = default;
void init() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeLineToTubeFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeLineToTubeFilter.h
index bbb226daa09..eed50103078 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositeLineToTubeFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositeLineToTubeFilter.h
@@ -20,7 +20,7 @@
class VtkCompositeLineToTubeFilter : public VtkCompositeFilter
{
public:
- VtkCompositeLineToTubeFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositeLineToTubeFilter(vtkAlgorithm* inputAlgorithm);
~VtkCompositeLineToTubeFilter() override;
void init() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeNodeSelectionFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeNodeSelectionFilter.h
index 67f1a735600..2835f57df02 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositeNodeSelectionFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositeNodeSelectionFilter.h
@@ -23,7 +23,7 @@
class VtkCompositeNodeSelectionFilter : public VtkCompositeFilter
{
public:
- VtkCompositeNodeSelectionFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositeNodeSelectionFilter(vtkAlgorithm* inputAlgorithm);
~VtkCompositeNodeSelectionFilter() override;
void init() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositePointToGlyphFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositePointToGlyphFilter.h
index 54790254b64..96fa3d11ae3 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositePointToGlyphFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositePointToGlyphFilter.h
@@ -22,7 +22,7 @@ class vtkSphereSource;
class VtkCompositePointToGlyphFilter : public VtkCompositeFilter
{
public:
- VtkCompositePointToGlyphFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositePointToGlyphFilter(vtkAlgorithm* inputAlgorithm);
~VtkCompositePointToGlyphFilter() override;
void init() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeTextureOnSurfaceFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeTextureOnSurfaceFilter.h
index 44c89fd76be..3b479c17ebc 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositeTextureOnSurfaceFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositeTextureOnSurfaceFilter.h
@@ -22,7 +22,7 @@ class vtkSphereSource;
class VtkCompositeTextureOnSurfaceFilter : public VtkCompositeFilter
{
public:
- VtkCompositeTextureOnSurfaceFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositeTextureOnSurfaceFilter(vtkAlgorithm* inputAlgorithm);
~VtkCompositeTextureOnSurfaceFilter() override;
void init() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeThresholdFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeThresholdFilter.h
index 77e4d5387b2..aaa9684df2d 100644
--- a/Applications/DataExplorer/VtkVis/VtkCompositeThresholdFilter.h
+++ b/Applications/DataExplorer/VtkVis/VtkCompositeThresholdFilter.h
@@ -22,7 +22,7 @@
class VtkCompositeThresholdFilter : public VtkCompositeFilter
{
public:
- VtkCompositeThresholdFilter(vtkAlgorithm* inputAlgorithm);
+ explicit VtkCompositeThresholdFilter(vtkAlgorithm* inputAlgorithm);
~VtkCompositeThresholdFilter() override;
void init() override;
diff --git a/Applications/DataExplorer/VtkVis/VtkVisPipeline.h b/Applications/DataExplorer/VtkVis/VtkVisPipeline.h
index ccbea1d46a1..1d9aa2d417c 100644
--- a/Applications/DataExplorer/VtkVis/VtkVisPipeline.h
+++ b/Applications/DataExplorer/VtkVis/VtkVisPipeline.h
@@ -57,7 +57,7 @@ class VtkVisPipeline : public TreeModel
Q_OBJECT
public:
- VtkVisPipeline(vtkRenderer* renderer, QObject* parent = nullptr);
+ explicit VtkVisPipeline(vtkRenderer* renderer, QObject* parent = nullptr);
/// \brief Emits vtkVisPipelineChanged() and calls base class method.
bool setData(const QModelIndex& index, const QVariant& value,
diff --git a/Applications/DataExplorer/VtkVis/VtkVisPipelineView.h b/Applications/DataExplorer/VtkVis/VtkVisPipelineView.h
index 61370f8e9f0..fefee39ed99 100644
--- a/Applications/DataExplorer/VtkVis/VtkVisPipelineView.h
+++ b/Applications/DataExplorer/VtkVis/VtkVisPipelineView.h
@@ -40,7 +40,7 @@ class VtkVisPipelineView : public QTreeView
public:
/// @brief Constructor.
- VtkVisPipelineView(QWidget* parent = nullptr);
+ explicit VtkVisPipelineView(QWidget* parent = nullptr);
/// @brief Overridden to set model specific header properties.
void setModel(QAbstractItemModel* model) override;
diff --git a/Applications/DataExplorer/VtkVis/VtkVisTabWidget.h b/Applications/DataExplorer/VtkVis/VtkVisTabWidget.h
index 1ccd0ac61b0..3be22090265 100644
--- a/Applications/DataExplorer/VtkVis/VtkVisTabWidget.h
+++ b/Applications/DataExplorer/VtkVis/VtkVisTabWidget.h
@@ -30,7 +30,7 @@ class VtkVisTabWidget : public QWidget, public Ui_VtkVisTabWidgetBase
public:
/// Constructor
- VtkVisTabWidget(QWidget* parent = nullptr);
+ explicit VtkVisTabWidget(QWidget* parent = nullptr);
protected slots:
/// Updates the property panels to show informations on the given VtkVisPipelineItem.
diff --git a/Applications/DataExplorer/mainwindow.h b/Applications/DataExplorer/mainwindow.h
index b5532f95f5b..7f6d2cbce86 100644
--- a/Applications/DataExplorer/mainwindow.h
+++ b/Applications/DataExplorer/mainwindow.h
@@ -42,7 +42,7 @@ class MainWindow : public QMainWindow, public Ui_MainWindowClass
Q_OBJECT
public:
- MainWindow(QWidget* parent = nullptr);
+ explicit MainWindow(QWidget* parent = nullptr);
void ShowWindow();
void HideWindow();
diff --git a/Applications/Utils/OGSFileConverter/OGSFileConverter.h b/Applications/Utils/OGSFileConverter/OGSFileConverter.h
index 2d5a0e67057..33fb685176d 100644
--- a/Applications/Utils/OGSFileConverter/OGSFileConverter.h
+++ b/Applications/Utils/OGSFileConverter/OGSFileConverter.h
@@ -26,7 +26,8 @@ class OGSFileConverter : public QDialog, private Ui_OGSFileConverter
public:
/// Constructor
- OGSFileConverter(std::string const& gmsh_path, QWidget* parent = nullptr);
+ explicit OGSFileConverter(std::string const& gmsh_path,
+ QWidget* parent = nullptr);
/// Destructor
~OGSFileConverter() override;
diff --git a/BaseLib/FileFinder.h b/BaseLib/FileFinder.h
index b08cac34d04..b33a60078cf 100644
--- a/BaseLib/FileFinder.h
+++ b/BaseLib/FileFinder.h
@@ -37,7 +37,7 @@ public:
*
* @param dirs an initializer list of additional directory paths to the search-space
*/
- explicit FileFinder(std::initializer_list<std::string> dirs);
+ FileFinder(std::initializer_list<std::string> dirs);
/**
* \brief Adds another directory to the search-space.
diff --git a/MaterialLib/FractureModels/Permeability/ConstantPermeability.h b/MaterialLib/FractureModels/Permeability/ConstantPermeability.h
index cbe99490ead..86d0abd68bc 100644
--- a/MaterialLib/FractureModels/Permeability/ConstantPermeability.h
+++ b/MaterialLib/FractureModels/Permeability/ConstantPermeability.h
@@ -18,7 +18,7 @@ namespace MaterialLib::Fracture::Permeability
class ConstantPermeability final : public Permeability
{
public:
- ConstantPermeability(double const permeability);
+ explicit ConstantPermeability(double const permeability);
private:
double permeability(PermeabilityState const* const /*state*/,
diff --git a/NumLib/NamedFunctionCaller.h b/NumLib/NamedFunctionCaller.h
index 365b1907a37..6c98637c2bf 100644
--- a/NumLib/NamedFunctionCaller.h
+++ b/NumLib/NamedFunctionCaller.h
@@ -22,7 +22,7 @@ class NamedFunctionCaller final
{
public:
//! Constructs an instance whose unbound arguments have the given names.
- explicit NamedFunctionCaller(
+ NamedFunctionCaller(
std::initializer_list<std::string> unbound_argument_names);
//! Adds the given named function
diff --git a/ProcessLib/VariableTransformation.h b/ProcessLib/VariableTransformation.h
index 2f00a1d20f9..5162e027dc9 100644
--- a/ProcessLib/VariableTransformation.h
+++ b/ProcessLib/VariableTransformation.h
@@ -65,7 +65,7 @@ struct TrafoTanh
struct TrafoScale
{
- TrafoScale(const double factor) : _factor{factor} {}
+ explicit TrafoScale(const double factor) : _factor{factor} {}
static const bool constrained = false;
--
GitLab