Full adoption of MPL in ChemistryLib (part 1: exchange)
Description
Partial adoption of the MPL by the ChemistryLib was merged previously (see !3358 (merged)). However, there are still some processes left to be adopted. This is extremely important for some current projects in the scope of radwaste, since such simulations require interactions between highly different materials (from a chemical point of view).
The minimum tags that need to be moved to the MPL to have a functional adoption of the MPL by the ChemistryLib are:
-
pe
(https://doxygen.opengeosys.org/de/db9/ogs_file_param__prj__chemical_system__solution__pe.html) -
surface
(https://doxygen.opengeosys.org/d9/df5/ogs_file_param__prj__chemical_system__surface.html) -
exchange
(https://doxygen.opengeosys.org/d1/da0/ogs_file_param__prj__chemical_system__exchange.html)
This can of course be done tag by tag.
Starting with the pe
, in my opinion, this can be added as an optional property of the AqueousLiquid
phase (in case there is no chemistry involved). However, I would suggest keeping the definition inside the <chemical_system>
for the case of one material only, if possible (to avoid the modification of the .prj
files in the benchmarks and by the users).
surface
and exchange
tags are pretty similar, so if one gets taken care of, the other shouldn't be a problem.
Edit: I have thought about the pe
issue and I think there is no straightforward way to avoid moving its definition from the <chemical_system>
.