Skip to content

[BHE] fix the BHE boundary nodes order problem

Shuang Chen requested to merge ShuangChen88/ogs:BHE into master

This MR fixes the BHE top and bottom node order problem when assigning them as boundary nodes. For 1U, 2U, CXC, CXA type BHEs in OGS BHE model, the z-coordinate of the BHE top node should always larger than it on the BHE bottom node. However in the current source code, the BHE top and bottom nodes are automatically identified according to their mesh node ids in ascending order. In this MR, a swap function is applied to the BHE boundary nodes vector, when the z-coordinate of the preassumed top BHE node is lower than it on the bottom BHE node. This will allow the top and bottom nodes to be identified no matter how the nodes are ordered.

Detailed changes are described as followed.

  1. A swap function is applied ton the BHE boundary nodes vector after all BHE boundary nodes are selected out in the createBHEBoundaryConditionTopBottom function.
  2. For horizontal BHE type e.g. 1P BHE, the reordering process will not be executed and the related information will be outputed.
Edited by Shuang Chen

Merge request reports