Skip to content

Use the existing class to compute the rotation matrix in LIE

wenqing requested to merge wenqing/ogs:LIE_improvement into master

Since the rotation matrix computation is handled by MeshLib::ElementCoordinatesMappingLocal, its implementation in LIE is redundant. This MR makes use of MeshLib::ElementCoordinatesMappingLocal in LIE and removes the associated redundant implementation.

This MR is prepared in order to improve MR !3632 (merged).

  1. Feature description was added to the changelog
  2. Tests covering your feature were added? Yes. It tested by all the exiting benchmarks, which all work with the their existing reference results except LIE_M_single_joint_3D. For LIE_M_single_joint_3D, the jump orientation is inversed due to the correction of the orientation of the normal to the jump, which is inversed. The following figure compares the signs of jump_X by using the current changed code (left), and the code compiled from the ogs/master (right):

The sign of jump_X by using the current changed code keeps a consistency with the sign of displacement_X as shown in the following figure (the negative for the same largest displacement):

  1. Any new feature or behavior change was documented?
Edited by wenqing

Merge request reports