Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • O ogs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 71
    • Issues 71
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 24
    • Merge requests 24
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ogs
  • ogs
  • Merge requests
  • !3923

[MPL/RelPermNonWettingPhaseVanGenuchtenMualem] replace the Newton-Raphson method with the Regula–Falsi Method

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged wenqing requested to merge wenqing/ogs:improve_permeablility into master Dec 14, 2021
  • Overview 7
  • Commits 3
  • Pipelines 7
  • Changes 4

In RelPermNonWettingPhaseVanGenuchtenMualem, the saturation corresponding to the minimum relative permeability is computed by using the Newton-Raphson method. With Newton-Raphson method, the solution of saturation during the linearization may exceed the range of [S_\text{r}, S_\text{max}]. Especially when S > S_\text{max}, i.e. S_e > 1, the permeability value calculation in RelPermNonWettingPhaseVanGenuchtenMualem leads to overflow.

In this MR. the local nonlinear solver in RelPermNonWettingPhaseVanGenuchtenMualem is changed to the Regula–Falsi method. With the Regula–Falsi method, the saturation is always in the range of [S_\text{r}, S_\text{max}]. That computation is only performed once on the ctor of RelPermNonWettingPhaseVanGenuchtenMualem. Since that permeability function is monotonic, the Regula–Falsi method for the root calculation can always give converged solution.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?
Edited Dec 20, 2021 by wenqing
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: improve_permeablility