Skip to content

Draft: Change Central Differences Jacobian implementation

Dmitry Yu. Naumov requested to merge endJunction/ogs:CentralDifferences into master

Don't use product rule in the computation of the residuum derivative.

The former implementation is using product rule for derivatives (M\cdot\dot{x})' and (K\cdot x)' using the product rule, which is not fully correct; Correct derivatives for finite differences would be M'\cdot \dot{x} + M\cdot \dot{x}' + M'\cdot \dot{x}'. The last term is missing in the implementation.

The new implementation does not use the product rule avoiding the mistake.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?
Edited by Dmitry Yu. Naumov

Merge request reports