Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • O ogs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 39
    • Merge requests 39
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ogsogs
  • ogs
  • Merge requests
  • !4189

Use values for domain deactivation structs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dmitry Yu. Naumov requested to merge endJunction/ogs:ValuesForSubdomainDeactivation into master Jun 22, 2022
  • Overview 9
  • Commits 9
  • Pipelines 7
  • Changes 20

Moving from vectors of pointers for nodes stored in the deactivated subdomain structs to vectors of node ids enables copy semantics.

For this the MeshLib now uses v3-ranges library and provides new ids "function" (a view closure) (will be used in many other places; partly in this MR and in another upcoming MR(s)).

Consequently removing the unique pointers and storing values directly simplifies the constructors and many other parts of the code.

Review commit-wise.

Fixes #3302 (closed)

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?
Edited Jun 28, 2022 by Dmitry Yu. Naumov
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ValuesForSubdomainDeactivation