fix time comparison in domain deactivation

Dmitri Naumovrequested to merge
endJunction/ogs:fix-deactivation-end-time-roundoff into master

Current time is accumulated sum of time step sizes. Can miss deactivation interval end by one ULP. Support test compared bare doubles, unlike every other time comparison in the time loop, which go through NumLib::Time tolerance. Miss the end, no subdomain is in its support interval, whole deactivated domain goes active for that step. Solution changes.

Use NumLib::Time in comparisons. Move TimeInterval to NumLib for deduplication. Test (failing on master) added. This also fixes DirichletWithinTimeInterval BC with exactly the same pattern.

  1. Tests covering your feature were added?
  2. Any new feature or behaviour change was documented?
Edited by Dmitri Naumov

Merge request reports