From 77c178dbe6e2b3dc4ee7b53a14c8fd13cac0821b Mon Sep 17 00:00:00 2001
From: aheinri5 <Anna@netzkritzler.de>
Date: Wed, 9 Dec 2020 15:26:01 +0100
Subject: [PATCH] [bugfix] Test files now generated at right location
---
R/scrape_benchmarks.R | 6 ++++++
tests/testthat/test-generate_functions.R | 1 -
tests/testthat/test-scrape_benchmarks.R | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
delete mode 100644 tests/testthat/test-generate_functions.R
diff --git a/R/scrape_benchmarks.R b/R/scrape_benchmarks.R
index a0cc825..96556d9 100644
--- a/R/scrape_benchmarks.R
+++ b/R/scrape_benchmarks.R
@@ -42,6 +42,12 @@ download_benchmark <- function(prj_url, path) {
assertthat::assert_that(assertthat::is.string(prj_url))
assertthat::assert_that(assertthat::is.string(path))
+ last_char_index <- length(path)
+
+ if(substring(path, last_char_index, last_char_index) != "/"){
+ path <- paste0(path, "/")
+ }
+
prj_dest_file <- paste0(path, basename(prj_url))
file.create(prj_dest_file)
diff --git a/tests/testthat/test-generate_functions.R b/tests/testthat/test-generate_functions.R
deleted file mode 100644
index 8b13789..0000000
--- a/tests/testthat/test-generate_functions.R
+++ /dev/null
@@ -1 +0,0 @@
-
diff --git a/tests/testthat/test-scrape_benchmarks.R b/tests/testthat/test-scrape_benchmarks.R
index 445ccbe..280997c 100644
--- a/tests/testthat/test-scrape_benchmarks.R
+++ b/tests/testthat/test-scrape_benchmarks.R
@@ -21,7 +21,7 @@ test_that("download_benchmark works", {
"flow_no_strain.prj"),
path = path)
- expect_equal(file.exists(paste0(path, "flow_no_strain.prj")), TRUE)
+ expect_equal(file.exists(paste0(path, "/flow_no_strain.prj")), TRUE)
do.call(file.remove, list(list.files(path, full.names = TRUE)))
})
\ No newline at end of file
--
GitLab