r2ogs6 issueshttps://gitlab.opengeosys.org/ogs/tools/r2ogs6/-/issues2024-03-03T14:09:47Zhttps://gitlab.opengeosys.org/ogs/tools/r2ogs6/-/issues/90Add function to install ogs and python dependencies2024-03-03T14:09:47ZJohannes BoogAdd function to install ogs and python dependenciesSupport for OGS 6.4.4Johannes BoogJohannes Booghttps://gitlab.opengeosys.org/ogs/tools/r2ogs6/-/issues/89Move r2ogs6 to github.com2024-02-26T07:24:06ZJohannes BoogMove r2ogs6 to github.comJohannes BoogJohannes Booghttps://gitlab.opengeosys.org/ogs/tools/r2ogs6/-/issues/87JOSS Review - Functionality and Documentation2023-06-14T08:57:17ZPaul SmithJOSS Review - Functionality and Documentation**General comment**: In my opinion it would be worth tidying up the package and submitting to CRAN. This would likely result in greater usage.
## Installation
- [ ] Current link to OGS on the r2ogs6 repository points to
https://www.ope...**General comment**: In my opinion it would be worth tidying up the package and submitting to CRAN. This would likely result in greater usage.
## Installation
- [ ] Current link to OGS on the r2ogs6 repository points to
https://www.opengeosys.org/releases/. Would be better pointing to
https://www.opengeosys.org/docs/userguide/basics/introduction/ which outlines the installation options rather then just giving downloads
- [ ] Cloning the r2ogs6 repository and used devtools::install does not pick up and install BiocManager or rhdf5 so fails. These (perhaps only rhdf5?) need to be installed first. The sequence in the instructions need altering to reflect this.
- [ ] Be explicit about getting the user to note where the OGS executables are installed. Not clear to me about how this would work with containers but didn't try this.
## Statement of Need
- [ ] This is missing from the documentation
## Examples
### Single Simulation
- [ ] Would be helpful if the line "Since I already read in a .prj file earlier, I won't run the above snippet.2 was above the code block :)
- [ ] Working with hdf5 files currently states "Here, we have added a file artificially from the benchmark library for demonstration." - a minimal data set (or clear link to one) should be included (is not one also needed for testing?)
### Ensemble Simulations
- [ ] Include `options("r2ogs6.default_ogs6_bin_path" = "<already_noted_path_from installation>")` in the preamble code
- [ ] These take a long time to run for examples, perhaps consider trimming them or stating run time estimates
## Community Guidelines
- [ ] While it is possible that "We are happy about all contributions!" I (hope) that there are some that you might not be happy with - reflect this!
- [ ] Should note that sign-up to the opengeosys gitlab is required to raise issues etc. Maybe this barrier is to high?https://gitlab.opengeosys.org/ogs/tools/r2ogs6/-/issues/86JOSS Review - paper comments2023-07-17T08:20:46ZPaul SmithJOSS Review - paper comments## General comments
- [ ] It would be useful for the paper to contain evidence of at least some usage or output, maybe not as compelte as https://doi.org/10.21105/joss.03673, but some sort of simulation output demonstrating use on a pra...## General comments
- [ ] It would be useful for the paper to contain evidence of at least some usage or output, maybe not as compelte as https://doi.org/10.21105/joss.03673, but some sort of simulation output demonstrating use on a practical problem.
- [ ] Links to examples could be more descriptive. Also expand on "r2ogs6 includes functions to create R scripts from existing OpenGeoSys 6 benchmarks that will allow a quick start for new users" (perhaps seperate out into a different "quick start" example?)
## Statement of need
- [ ] Line 35 - 47: References needed in first paragraph
## State of the field
- [ ] Lines 60-65: While other software packages are referenced it is unclear what underlying computational core (if any) they are wrapping and how there functionality compares to r2ogs6
## Quality of the writing
- [ ] While the standard of English is good the paper could do with further proof reading both for clarity and formality. For example Line 70-73 "Especially,..." and Line 53 "model setups get more and more complex"
## References
- [ ] Carnell R. should point to CRAN not github as for other R packagesJohannes BoogJohannes Booghttps://gitlab.opengeosys.org/ogs/tools/r2ogs6/-/issues/85Set up windows runner2023-05-18T07:18:24ZJohannes BoogSet up windows runnerSupport for OGS 6.4.4Johannes BoogJohannes Booghttps://gitlab.opengeosys.org/ogs/tools/r2ogs6/-/issues/84[docs] update vignettes2023-04-08T12:11:38ZJohannes Boog[docs] update vignettesAs final step before new release.As final step before new release.Support for OGS 6.4.4Johannes BoogJohannes Booghttps://gitlab.opengeosys.org/ogs/tools/r2ogs6/-/issues/76[base] Check platform compatabilities2023-03-21T21:08:35ZJohannes Boog[base] Check platform compatabilitiescheck if package works on:
- linux
- windows
using [rhub](https://r-hub.github.io/rhub/index.html)check if package works on:
- linux
- windows
using [rhub](https://r-hub.github.io/rhub/index.html)Support for OGS 6.4.4Johannes BoogJohannes Booghttps://gitlab.opengeosys.org/ogs/tools/r2ogs6/-/issues/75[test] Increase test coverage to 80% at least2022-12-19T19:28:12ZJohannes Boog[test] Increase test coverage to 80% at leastStart with files that have very low coverage.Start with files that have very low coverage.Johannes BoogJohannes Boog