GitLab

In HDF5 development the header file guards were changed,
namely the leading underscore was removed. This lead to
a redefinition of the hid_t type, which is int64_t.

The change happened in commit
https://github.com/HDFGroup/hdf5/commit/c17b4b93d680340af2b3f2c026f2c03c3baeb33ahttps://github.com/HDFGroup/hdf5/commit/c17b4b93d680340af2b3f2c026f2c03c3baeb33a
and is published in HDF5 version hdf5-1_13_0-rc6.

Fixes policy CMP0115 warnings.

Tobias Meisel authored Nov 11, 2020 and Lars Bilke committed Nov 25, 2020

This is needed to have a seperate name than the xdmf lib
which may be distributed together with the vtk lib

Because the API of the xdmf lib contains c++ structures (vector)
we run into a C++ ABI Problem where it is difficult to link a OGS
translation unit with GLIBCXX_DEBUG to a library without GLIBCXX_DEBUG
(e.g. the xdmf lib shipped with vtk in default arch linux distribution
is built without GLIBCXX_DEBUG)

A good overview of this problem from gcc perspective is here:

https://gcc.gnu.org/onlinedocs/gcc-4.9.4/libstdc++/manual/manual/debug_mode_design.html

correction xdmf lib 3rd party

warnings: avoid string + int and use stringstream instead

See merge request xdmf/xdmf!51

Fix shadowing warnings

See merge request xdmf/xdmf!54

XdmfGridTemplate: use boolean && rather than bitwise &

See merge request xdmf/xdmf!53

The code was useless before since it declared a variable that
immediately left the scope.

These instances are best fixed by renaming or removing the (unused)
shadowing declaration.

Fix warnings

See merge request xdmf/xdmf!52

Since it is inherited, the destructor needs to be virtual to release
memory properly.

XdmfGridController: add missing `return` statement

See merge request xdmf/xdmf!50

replace atoi for seek because that can get overflow easily

See merge request xdmf/xdmf!49

With this we at least get full unsigned int range and a warning
if we overflow.

Cmake cleanup

See merge request xdmf/xdmf!39

Set them at the top-level instead.

These were all overwriting each other otherwise.

This should be controlled by the build system.