From 0406bc5672e56b868982d732fb6f415c79a54f56 Mon Sep 17 00:00:00 2001
From: Dmitri Naumov <github@naumov.de>
Date: Tue, 16 Jun 2020 19:18:47 +0200
Subject: [PATCH] [T/MPL] Relax tolerances for numerical derivatives
The errors, especially for the second derivative are
one order higher especially around values +- 2,4,8,16,32,64.
Setting the tolerance for second order derivative just
above the maximum error I got for -63.99999303065484 which,
is 0.00014201125474823262.
Fixes #3005 ttps://github.com/ufz/ogs/issues/3005
---
Tests/MaterialLib/TestMPLExponential.cpp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Tests/MaterialLib/TestMPLExponential.cpp b/Tests/MaterialLib/TestMPLExponential.cpp
index 514ff21433a..7b41067809c 100644
--- a/Tests/MaterialLib/TestMPLExponential.cpp
+++ b/Tests/MaterialLib/TestMPLExponential.cpp
@@ -74,8 +74,12 @@ TEST_F(MaterialPropertyLibExponentialProperty, TestNumericalDerivatives)
double const Dv = dydx_C2(T, y, eps);
double const Dv2 = d2ydx2_C2(T, y, eps);
+ if ((std::abs(dv - Dv) > 1e-9 * v) ||
+ (std::abs(dv2 - Dv2) > 1.5e-4 * v))
+ INFO("{} {} {}", T, std::abs(dv - Dv) / v, std::abs(dv2 - Dv2) / v);
+
return (std::abs(dv - Dv) <= 1e-9 * v) &&
- (std::abs(dv2 - Dv2) <= eps * v);
+ (std::abs(dv2 - Dv2) <= 1.5e-4 * v);
};
// Limit values to avoid +-inf.
--
GitLab