From 71e97e1a8de8122f0691442730fd82370fea5670 Mon Sep 17 00:00:00 2001
From: Christoph Lehmann <christoph.lehmann@ufz.de>
Date: Tue, 5 Apr 2022 10:06:13 +0200
Subject: [PATCH] [AppL] Use l-value refs
As far as I can see, none of the method arguments are used in a way that
requires them to be passed as r-value ref. So IMHO they should be passed
in the traditional way.
---
Applications/ApplicationsLib/Simulation.cpp | 7 ++++---
Applications/ApplicationsLib/Simulation.h | 8 +++++---
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/Applications/ApplicationsLib/Simulation.cpp b/Applications/ApplicationsLib/Simulation.cpp
index ded70561e2e..e3beabaf930 100644
--- a/Applications/ApplicationsLib/Simulation.cpp
+++ b/Applications/ApplicationsLib/Simulation.cpp
@@ -44,9 +44,10 @@ Simulation::Simulation(int argc, char* argv[])
}
void Simulation::initializeDataStructures(
- std::string&& project, std::vector<std::string>&& xml_patch_file_names,
- bool const reference_path_is_set, std::string&& reference_path,
- bool const nonfatal, std::string&& outdir, std::string&& mesh_dir,
+ std::string const& project,
+ std::vector<std::string> const& xml_patch_file_names,
+ bool const reference_path_is_set, std::string const& reference_path,
+ bool const nonfatal, std::string const& outdir, std::string const& mesh_dir,
bool const write_prj)
{
std::stringstream prj_stream;
diff --git a/Applications/ApplicationsLib/Simulation.h b/Applications/ApplicationsLib/Simulation.h
index d477e401ae7..5ca7887ea77 100644
--- a/Applications/ApplicationsLib/Simulation.h
+++ b/Applications/ApplicationsLib/Simulation.h
@@ -26,9 +26,11 @@ public:
Simulation(int argc, char* argv[]);
void initializeDataStructures(
- std::string&& project, std::vector<std::string>&& xml_patch_file_names,
- bool reference_path_is_set, std::string&& reference_path, bool nonfatal,
- std::string&& outdir, std::string&& mesh_dir, bool write_prj);
+ std::string const& project,
+ std::vector<std::string> const& xml_patch_file_names,
+ bool reference_path_is_set, std::string const& reference_path,
+ bool nonfatal, std::string const& outdir, std::string const& mesh_dir,
+ bool write_prj);
bool executeSimulation();
--
GitLab