From 79feafbc38df3435959da11acd2ba464e065fb5d Mon Sep 17 00:00:00 2001
From: Lars Bilke <lars.bilke@ufz.de>
Date: Mon, 11 Aug 2014 11:40:34 +0200
Subject: [PATCH] Consider creating a pointer/reference to avoid using the same
expression repeatedly.
http://www.viva64.com/en/d/0216/print/
---
FileIO/XmlIO/Qt/XmlCndInterface.cpp | 7 ++++---
FileIO/XmlIO/Qt/XmlGmlInterface.cpp | 9 +++++----
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/FileIO/XmlIO/Qt/XmlCndInterface.cpp b/FileIO/XmlIO/Qt/XmlCndInterface.cpp
index 1f6b3701829..2fe1de53329 100644
--- a/FileIO/XmlIO/Qt/XmlCndInterface.cpp
+++ b/FileIO/XmlIO/Qt/XmlCndInterface.cpp
@@ -51,11 +51,12 @@ int XmlCndInterface::readFile(const QString &fileName)
for (int i = 0; i < lists.count(); i++)
{
const QDomNode list_node (lists.at(i));
- if (list_node.nodeName().compare("BoundaryConditions") == 0)
+ const QString nodeName = list_node.nodeName();
+ if (nodeName.compare("BoundaryConditions") == 0)
readConditions(list_node, FEMCondition::BOUNDARY_CONDITION);
- else if (list_node.nodeName().compare("InitialConditions") == 0)
+ else if (nodeName.compare("InitialConditions") == 0)
readConditions(list_node, FEMCondition::INITIAL_CONDITION);
- else if (list_node.nodeName().compare("SourceTerms") == 0)
+ else if (nodeName.compare("SourceTerms") == 0)
readConditions(list_node, FEMCondition::SOURCE_TERM);
}
std::size_t const n_cond_after(this->_project.getConditions().size());
diff --git a/FileIO/XmlIO/Qt/XmlGmlInterface.cpp b/FileIO/XmlIO/Qt/XmlGmlInterface.cpp
index 64141938a2d..cf54a32ea75 100644
--- a/FileIO/XmlIO/Qt/XmlGmlInterface.cpp
+++ b/FileIO/XmlIO/Qt/XmlGmlInterface.cpp
@@ -58,7 +58,8 @@ int XmlGmlInterface::readFile(const QString &fileName)
for (int i = 0; i < geoTypes.count(); i++)
{
const QDomNode type_node(geoTypes.at(i));
- if (type_node.nodeName().compare("name") == 0)
+ const QString nodeName = type_node.nodeName();
+ if (nodeName.compare("name") == 0)
if (type_node.toElement().text().isEmpty())
{
ERR("XmlGmlInterface::readFile(): <name>-tag is empty.")
@@ -66,15 +67,15 @@ int XmlGmlInterface::readFile(const QString &fileName)
}
else
gliName = type_node.toElement().text().toStdString();
- else if (type_node.nodeName().compare("points") == 0)
+ else if (nodeName.compare("points") == 0)
{
readPoints(type_node, points, pnt_names);
_geo_objs.addPointVec(points, gliName, pnt_names);
}
- else if (type_node.nodeName().compare("polylines") == 0)
+ else if (nodeName.compare("polylines") == 0)
readPolylines(type_node, polylines, points,
_geo_objs.getPointVecObj(gliName)->getIDMap(), ply_names);
- else if (type_node.nodeName().compare("surfaces") == 0)
+ else if (nodeName.compare("surfaces") == 0)
readSurfaces(type_node, surfaces, points,
_geo_objs.getPointVecObj(gliName)->getIDMap(), sfc_names);
}
--
GitLab