From 26cbf9ecc1ddc0671a5f3a856015192bd6206d01 Mon Sep 17 00:00:00 2001
From: Thomas Fischer <thomas.fischer@ufz.de>
Date: Mon, 5 Aug 2019 11:20:54 +0200
Subject: [PATCH] [Param] Don't create local variable before return.

---
 ParameterLib/Parameter.cpp | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/ParameterLib/Parameter.cpp b/ParameterLib/Parameter.cpp
index fcd185c339d..cfb170703c2 100644
--- a/ParameterLib/Parameter.cpp
+++ b/ParameterLib/Parameter.cpp
@@ -48,38 +48,32 @@ std::unique_ptr<ParameterBase> createParameter(
     if (type == "Constant")
     {
         INFO("ConstantParameter: %s", name.c_str());
-        auto param = createConstantParameter(name, config);
-        return param;
+        return createConstantParameter(name, config);
     }
     if (type == "CurveScaled")
     {
         INFO("CurveScaledParameter: %s", name.c_str());
-        auto param = createCurveScaledParameter(name, config, curves);
-        return param;
+        return createCurveScaledParameter(name, config, curves);
     }
     if (type == "Function")
     {
         INFO("FunctionParameter: %s", name.c_str());
-        auto param = createFunctionParameter(name, config, mesh);
-        return param;
+        return createFunctionParameter(name, config, mesh);
     }
     if (type == "Group")
     {
         INFO("GroupBasedParameter: %s", name.c_str());
-        auto param = createGroupBasedParameter(name, config, mesh);
-        return param;
+        return createGroupBasedParameter(name, config, mesh);
     }
     if (type == "MeshElement")
     {
         INFO("MeshElementParameter: %s", name.c_str());
-        auto param = createMeshElementParameter(name, config, mesh);
-        return param;
+        return createMeshElementParameter(name, config, mesh);
     }
     if (type == "MeshNode")
     {
         INFO("MeshNodeParameter: %s", name.c_str());
-        auto param = createMeshNodeParameter(name, config, mesh);
-        return param;
+        return createMeshNodeParameter(name, config, mesh);
     }
     if (type == "TimeDependentHeterogeneousParameter")
     {
-- 
GitLab