diff --git a/.clang-tidy b/.clang-tidy index 7db6dba41c9ae5919b9470998799b8c61a2cbd62..ff349ead9c83e28ccccff7b13e2b85de075ba47c 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -5,3 +5,10 @@ WarningsAsErrors: '' HeaderFilterRegex: '.*' AnalyzeTemporaryDtors: false FormatStyle: file +CheckOptions: + - key: google-readability-braces-around-statements.ShortStatementLines + value: '1' + - key: hicpp-braces-around-statements.ShortStatementLines + value: '1' + - key: readability-braces-around-statements.ShortStatementLines + value: '1' diff --git a/Applications/DataExplorer/Base/CheckboxDelegate.h b/Applications/DataExplorer/Base/CheckboxDelegate.h index be4449ac56a6f037f1e932de1a15e49f75f421f0..4d876b97d2a53b6cc8c68b0338811cb672bc5648 100644 --- a/Applications/DataExplorer/Base/CheckboxDelegate.h +++ b/Applications/DataExplorer/Base/CheckboxDelegate.h @@ -31,7 +31,7 @@ class CheckboxDelegate : public QItemDelegate public: /// \brief Constructor - CheckboxDelegate(QObject* parent = nullptr); + explicit CheckboxDelegate(QObject* parent = nullptr); /// \brief Paints a checkbox. This overrides the default painting of a combo box. void paint(QPainter* painter, const QStyleOptionViewItem& option, diff --git a/Applications/DataExplorer/Base/ColorPickerPushButton.h b/Applications/DataExplorer/Base/ColorPickerPushButton.h index 0e53871a4eb4dc2f251ba7e95e6a19482f160f60..040a9638d54350c75743c5d72d30fa92b0bd8bfa 100644 --- a/Applications/DataExplorer/Base/ColorPickerPushButton.h +++ b/Applications/DataExplorer/Base/ColorPickerPushButton.h @@ -30,7 +30,7 @@ class ColorPickerPushButton : public QPushButton Q_OBJECT public: - ColorPickerPushButton(QWidget* parent = nullptr); + explicit ColorPickerPushButton(QWidget* parent = nullptr); public slots: /// Calls the QColorDialog diff --git a/Applications/DataExplorer/Base/QNonScalableGraphicsTextItem.h b/Applications/DataExplorer/Base/QNonScalableGraphicsTextItem.h index 5c0c66f711d255baa0568cdf253bdae4777a3c59..80dd621ff932572ac039e92b83b60292aa284598 100644 --- a/Applications/DataExplorer/Base/QNonScalableGraphicsTextItem.h +++ b/Applications/DataExplorer/Base/QNonScalableGraphicsTextItem.h @@ -24,9 +24,9 @@ class QNonScalableGraphicsTextItem : public QGraphicsTextItem { public: - QNonScalableGraphicsTextItem(QGraphicsItem* parent = nullptr); - QNonScalableGraphicsTextItem(const QString& text, - QGraphicsItem* parent = nullptr); + explicit QNonScalableGraphicsTextItem(QGraphicsItem* parent = nullptr); + explicit QNonScalableGraphicsTextItem(const QString& text, + QGraphicsItem* parent = nullptr); ~QNonScalableGraphicsTextItem() override; void paint(QPainter* painter, diff --git a/Applications/DataExplorer/Base/QValueTooltipSlider.h b/Applications/DataExplorer/Base/QValueTooltipSlider.h index ff41723c530a1319bcd936e3d24f32d73551b754..e62784b4ec7143b45ccc24fdc55eb1bac0dffef3 100644 --- a/Applications/DataExplorer/Base/QValueTooltipSlider.h +++ b/Applications/DataExplorer/Base/QValueTooltipSlider.h @@ -23,7 +23,7 @@ class QValueTooltipSlider : public QSlider Q_OBJECT public: - QValueTooltipSlider(QWidget* parent = nullptr); + explicit QValueTooltipSlider(QWidget* parent = nullptr); public slots: void setTooltipValue(int value); diff --git a/Applications/DataExplorer/Base/StrictDoubleValidator.h b/Applications/DataExplorer/Base/StrictDoubleValidator.h index d447e1d7ae5d99a2fe260254923a989f15e6c96c..6ad1e9d41b3990e71519d94cd2af9cd3aed6026e 100644 --- a/Applications/DataExplorer/Base/StrictDoubleValidator.h +++ b/Applications/DataExplorer/Base/StrictDoubleValidator.h @@ -26,8 +26,8 @@ public: QDoubleValidator( min, max, decimals, parent) {} - StrictDoubleValidator ( QObject* parent = nullptr) : - QDoubleValidator( parent) + explicit StrictDoubleValidator(QObject* parent = nullptr) + : QDoubleValidator(parent) {} QValidator::State validate(QString& input, int& pos) const override diff --git a/Applications/DataExplorer/Base/TreeModel.h b/Applications/DataExplorer/Base/TreeModel.h index 2e063ce6c869169c80d1f2939a1218f09a32e788..797f434229d41d5fb98343213a446bb72614b2bf 100644 --- a/Applications/DataExplorer/Base/TreeModel.h +++ b/Applications/DataExplorer/Base/TreeModel.h @@ -31,7 +31,7 @@ class TreeModel : public QAbstractItemModel Q_OBJECT public: - TreeModel(QObject* parent = nullptr); + explicit TreeModel(QObject* parent = nullptr); ~TreeModel() override; QVariant data(const QModelIndex& index, int role) const override; diff --git a/Applications/DataExplorer/Base/TreeModelIterator.h b/Applications/DataExplorer/Base/TreeModelIterator.h index d309e4412718f8553506c518a2d28eb8ea08aa96..9d0c91d84bb338cba2ef6f9c2e6a6368cd63780b 100644 --- a/Applications/DataExplorer/Base/TreeModelIterator.h +++ b/Applications/DataExplorer/Base/TreeModelIterator.h @@ -35,7 +35,7 @@ class TreeModelIterator { public: /// \brief Constructor. Provide a tree model to iterate over. - TreeModelIterator(TreeModel* model); + explicit TreeModelIterator(TreeModel* model); /// \brief Dereferencing the iterator to retrieve the current TreeItem. /// Returns nullptr if the iterator is at the end. diff --git a/Applications/DataExplorer/DataView/AddLayerToMeshDialog.h b/Applications/DataExplorer/DataView/AddLayerToMeshDialog.h index 90398aae90006e6b157bfb54c66abddaa15dd590..e6052c7fd5bc1ccbb7048621d7f12fe3bb609556 100644 --- a/Applications/DataExplorer/DataView/AddLayerToMeshDialog.h +++ b/Applications/DataExplorer/DataView/AddLayerToMeshDialog.h @@ -27,7 +27,7 @@ class AddLayerToMeshDialog : public QDialog, private Ui_AddLayerToMesh Q_OBJECT public: - AddLayerToMeshDialog(QDialog* parent = nullptr); + explicit AddLayerToMeshDialog(QDialog* parent = nullptr); /// Returns if the top layer button is selected (if false, bottom is selected). bool isTopLayer() const { return this->topButton->isChecked(); }; diff --git a/Applications/DataExplorer/DataView/BaseItem.h b/Applications/DataExplorer/DataView/BaseItem.h index d97437f142e6098527721ed92f79fb46dc455bba..d76baa5c8acee3f0fa13f63a834173408e945ded 100644 --- a/Applications/DataExplorer/DataView/BaseItem.h +++ b/Applications/DataExplorer/DataView/BaseItem.h @@ -31,8 +31,8 @@ class Point; class BaseItem { public: - BaseItem(const QString& listName, - const std::vector<GeoLib::Point*>* stations = nullptr) + explicit BaseItem(const QString& listName, + const std::vector<GeoLib::Point*>* stations = nullptr) : _stations(stations), _vtkSource(VtkStationSource::New()) { // create the vtk-object for 3d-visualisation of this list diff --git a/Applications/DataExplorer/DataView/ColorTableModel.h b/Applications/DataExplorer/DataView/ColorTableModel.h index 3b21f6261c6176135e2c31ec7a6ad52bc4ae97c4..45a619cf0a197ff34ab36b200a69659bda57d441 100644 --- a/Applications/DataExplorer/DataView/ColorTableModel.h +++ b/Applications/DataExplorer/DataView/ColorTableModel.h @@ -27,7 +27,7 @@ class ColorTableModel : public QAbstractTableModel Q_OBJECT public: - ColorTableModel( + explicit ColorTableModel( const std::map<std::string, DataHolderLib::Color*>& colorLookupTable, QObject* parent = nullptr); ~ColorTableModel() override; diff --git a/Applications/DataExplorer/DataView/ColorTableView.h b/Applications/DataExplorer/DataView/ColorTableView.h index c25717050bfc087d0f1aa7bee180fb51a6309df1..3b231904f2e0fa287f82d32a08a05b9cc94f5e5c 100644 --- a/Applications/DataExplorer/DataView/ColorTableView.h +++ b/Applications/DataExplorer/DataView/ColorTableView.h @@ -25,7 +25,7 @@ class ColorTableView : public QTableView public: /// Constructor - ColorTableView(QWidget* parent = nullptr); + explicit ColorTableView(QWidget* parent = nullptr); }; /** @@ -37,7 +37,10 @@ class ColorTableViewDelegate : public QItemDelegate public: /// Constructor - ColorTableViewDelegate(QWidget* parent = nullptr) : QItemDelegate(parent) {} + explicit ColorTableViewDelegate(QWidget* parent = nullptr) + : QItemDelegate(parent) + { + } /// Overwrites the paint-method to set user-defined properties instead of the default properties. void paint(QPainter* painter, const QStyleOptionViewItem& option, const QModelIndex& index) const override; diff --git a/Applications/DataExplorer/DataView/CondFromRasterDialog.h b/Applications/DataExplorer/DataView/CondFromRasterDialog.h index ade6924fd1da640fd7b39582a03634aa0ebaa645..5152b823bdea1b1c5308f8af04a49e3f0c646e99 100644 --- a/Applications/DataExplorer/DataView/CondFromRasterDialog.h +++ b/Applications/DataExplorer/DataView/CondFromRasterDialog.h @@ -31,8 +31,8 @@ class CondFromRasterDialog : public QDialog, private Ui_CondFromRaster Q_OBJECT public: - CondFromRasterDialog(std::vector<MeshLib::Mesh*> msh_vec, - QDialog* parent = nullptr); + explicit CondFromRasterDialog(std::vector<MeshLib::Mesh*> msh_vec, + QDialog* parent = nullptr); ~CondFromRasterDialog() override; private: diff --git a/Applications/DataExplorer/DataView/CreateStructuredGridDialog.h b/Applications/DataExplorer/DataView/CreateStructuredGridDialog.h index 56d6ec6c91cc7de7b1097359a279acc263a2e1ad..5d17ca84f9fddf835d86ab469e8e0cbeec87d391 100644 --- a/Applications/DataExplorer/DataView/CreateStructuredGridDialog.h +++ b/Applications/DataExplorer/DataView/CreateStructuredGridDialog.h @@ -27,7 +27,7 @@ class CreateStructuredGridDialog : public QDialog, private Ui_CreateStructuredGr Q_OBJECT public: - CreateStructuredGridDialog(QDialog* parent = nullptr); + explicit CreateStructuredGridDialog(QDialog* parent = nullptr); private slots: void on_lineButton_toggled() const; diff --git a/Applications/DataExplorer/DataView/DataExplorerSettingsDialog.h b/Applications/DataExplorer/DataView/DataExplorerSettingsDialog.h index 613e5bab35394bef6850f17fc57c4dcb194369f3..bf0a1ff6151e5fd74cea5ba5af16917556f85347 100644 --- a/Applications/DataExplorer/DataView/DataExplorerSettingsDialog.h +++ b/Applications/DataExplorer/DataView/DataExplorerSettingsDialog.h @@ -25,7 +25,7 @@ class DataExplorerSettingsDialog : public QDialog, private Ui_DataExplorerSettin Q_OBJECT public: - DataExplorerSettingsDialog(QDialog* parent = nullptr); + explicit DataExplorerSettingsDialog(QDialog* parent = nullptr); ~DataExplorerSettingsDialog() override; private slots: diff --git a/Applications/DataExplorer/DataView/DiagramView/DetailWindow.h b/Applications/DataExplorer/DataView/DiagramView/DetailWindow.h index 35ec29d2c4fff6c33aed2579636eb994bea4e609..ee7a563e6819ab14495f3a96fb275311def9cde9 100644 --- a/Applications/DataExplorer/DataView/DiagramView/DetailWindow.h +++ b/Applications/DataExplorer/DataView/DiagramView/DetailWindow.h @@ -27,22 +27,23 @@ class DetailWindow : public QWidget, private Ui_DetailWindow public: /// Creates an empty diagram window. - DetailWindow(QWidget* parent = nullptr); + explicit DetailWindow(QWidget* parent = nullptr); /** * Creates a window containing a diagram. * \param filename ASCII file containing x and y values for the graph to be displayed. * \param parent The parent QWidget. */ - DetailWindow(QString filename, QWidget* parent = nullptr); + explicit DetailWindow(QString filename, QWidget* parent = nullptr); /** * Creates a window containing a diagram * \param list A QDiagramList containing all the data points and necessary metainformation for a graph to be displayed * \param parent The parent QWidget. */ - DetailWindow(DiagramList* list, QWidget* parent = nullptr); + explicit DetailWindow(DiagramList* list, QWidget* parent = nullptr); - DetailWindow(std::vector<std::size_t> data, QWidget* parent = nullptr); + explicit DetailWindow(std::vector<std::size_t> data, + QWidget* parent = nullptr); ~DetailWindow() override; diff --git a/Applications/DataExplorer/DataView/DiagramView/DiagramPrefsDialog.h b/Applications/DataExplorer/DataView/DiagramView/DiagramPrefsDialog.h index 0fe9041baa2ccf5d0b37aa55f05b8a93210578a8..9ead7c8b11db57c52dd9b3ad984793c5c71bf98c 100644 --- a/Applications/DataExplorer/DataView/DiagramView/DiagramPrefsDialog.h +++ b/Applications/DataExplorer/DataView/DiagramView/DiagramPrefsDialog.h @@ -58,7 +58,8 @@ public: * \param stn The station object associated the diagram. * \param parent The parent QDialog. */ - DiagramPrefsDialog(GeoLib::Station* stn, QDialog* parent = nullptr); + explicit DiagramPrefsDialog(GeoLib::Station* stn, + QDialog* parent = nullptr); /** * Opens a new dialog and automatically reads data from the specified file. The diagram is not associated @@ -67,9 +68,9 @@ public: * \param[out] window Returns the created DetailWindow. * \param parent The parent QDialog. */ - DiagramPrefsDialog(const QString& filename, - DetailWindow* window = nullptr, - QDialog* parent = nullptr); + explicit DiagramPrefsDialog(const QString& filename, + DetailWindow* window = nullptr, + QDialog* parent = nullptr); ~DiagramPrefsDialog() override; diff --git a/Applications/DataExplorer/DataView/DiagramView/DiagramScene.h b/Applications/DataExplorer/DataView/DiagramView/DiagramScene.h index 1c34c20b22486dadbbcb41f8970bb2584a5f0980..6c8cdb065607bb4ce74ed78007105136fd04bd9c 100644 --- a/Applications/DataExplorer/DataView/DiagramView/DiagramScene.h +++ b/Applications/DataExplorer/DataView/DiagramView/DiagramScene.h @@ -28,8 +28,8 @@ class QDateTime; class DiagramScene : public QGraphicsScene { public: - DiagramScene(QObject* parent = nullptr); - DiagramScene(DiagramList* list, QObject* parent = nullptr); + explicit DiagramScene(QObject* parent = nullptr); + explicit DiagramScene(DiagramList* list, QObject* parent = nullptr); ~DiagramScene() override; QArrow* addArrow(qreal length, qreal angle, QPen& pen); diff --git a/Applications/DataExplorer/DataView/DiagramView/DiagramView.h b/Applications/DataExplorer/DataView/DiagramView/DiagramView.h index 5711e5e2e1e8c00975645ecddfe50777a9b054ed..a5956d093d54de0fef9a1875a6a96ea6796ba205 100644 --- a/Applications/DataExplorer/DataView/DiagramView/DiagramView.h +++ b/Applications/DataExplorer/DataView/DiagramView/DiagramView.h @@ -31,13 +31,13 @@ public: /** * Creates an empty view. */ - DiagramView(QWidget* parent = nullptr); + explicit DiagramView(QWidget* parent = nullptr); /** * Creates a view already containing a graph * \param list Contains a list of data points and metainformation to be displayed by the scene. * \param parent The parent QWidget. */ - DiagramView(DiagramList* list, QWidget* parent = nullptr); + explicit DiagramView(DiagramList* list, QWidget* parent = nullptr); ~DiagramView() override; /// Adds a new graph to the scene. diff --git a/Applications/DataExplorer/DataView/ElementTreeModel.h b/Applications/DataExplorer/DataView/ElementTreeModel.h index 3acf2ef00294cf38783dc2d25655e6c95ffa7827..ac421d75220d663d03b6dd18408b4d8efaa9e500 100644 --- a/Applications/DataExplorer/DataView/ElementTreeModel.h +++ b/Applications/DataExplorer/DataView/ElementTreeModel.h @@ -32,7 +32,7 @@ class ElementTreeModel : public TreeModel Q_OBJECT public: - ElementTreeModel(QObject* parent = nullptr); + explicit ElementTreeModel(QObject* parent = nullptr); ~ElementTreeModel() override; vtkUnstructuredGridAlgorithm const* getSource() const { return _mesh_source; }; diff --git a/Applications/DataExplorer/DataView/ElementTreeView.h b/Applications/DataExplorer/DataView/ElementTreeView.h index 821b6ff5685afa193125eda68b002e92105e4dcf..f5d7f98f595e590a5a3e9db21aba1cc0750a1c07 100644 --- a/Applications/DataExplorer/DataView/ElementTreeView.h +++ b/Applications/DataExplorer/DataView/ElementTreeView.h @@ -26,7 +26,7 @@ class ElementTreeView : public QTreeView public: /// Constructor - ElementTreeView(QWidget* parent = nullptr); + explicit ElementTreeView(QWidget* parent = nullptr); public slots: void updateView(); diff --git a/Applications/DataExplorer/DataView/FemConditionModel.h b/Applications/DataExplorer/DataView/FemConditionModel.h index d6b21c0ac67efe853554671023f64c911aef29fa..06cf594259589100465c70f276732761e4280233 100644 --- a/Applications/DataExplorer/DataView/FemConditionModel.h +++ b/Applications/DataExplorer/DataView/FemConditionModel.h @@ -22,7 +22,7 @@ class FemConditionModel : public TreeModel Q_OBJECT public: - FemConditionModel(QObject* parent = nullptr); + explicit FemConditionModel(QObject* parent = nullptr); int columnCount( const QModelIndex& /*parent*/ = QModelIndex()) const override diff --git a/Applications/DataExplorer/DataView/FemConditionView.h b/Applications/DataExplorer/DataView/FemConditionView.h index 898855d0bc4f79542ed2146540976ea24dc73c05..43d49b406b8f04514679cecbca99c65173e31b9f 100644 --- a/Applications/DataExplorer/DataView/FemConditionView.h +++ b/Applications/DataExplorer/DataView/FemConditionView.h @@ -24,7 +24,7 @@ class FemConditionView final : public QTreeView public: /// Constructor - FemConditionView(QWidget* parent = nullptr); + explicit FemConditionView(QWidget* parent = nullptr); public slots: void updateView(); diff --git a/Applications/DataExplorer/DataView/GEOModels.h b/Applications/DataExplorer/DataView/GEOModels.h index 525cc21cea61a08e9165f405e5ebe9ffd19dc9ea..91ae62d9a8de32e445f55c8e5ac77a1737535db1 100644 --- a/Applications/DataExplorer/DataView/GEOModels.h +++ b/Applications/DataExplorer/DataView/GEOModels.h @@ -38,7 +38,8 @@ class GEOModels : public QObject Q_OBJECT public: - GEOModels(GeoLib::GEOObjects& geo_objects, QObject* parent = nullptr); + explicit GEOModels(GeoLib::GEOObjects& geo_objects, + QObject* parent = nullptr); ~GEOModels() override; GeoTreeModel* getGeoModel() { return _geoModel; } diff --git a/Applications/DataExplorer/DataView/GMSHPrefsDialog.h b/Applications/DataExplorer/DataView/GMSHPrefsDialog.h index 79ea7a486422cf41973bbc7995b2d4ad6fbdf802..86acd8c8780e61f18c82b9e053353ffdbe984992 100644 --- a/Applications/DataExplorer/DataView/GMSHPrefsDialog.h +++ b/Applications/DataExplorer/DataView/GMSHPrefsDialog.h @@ -32,7 +32,8 @@ class GMSHPrefsDialog : public QDialog, private Ui_GMSHPrefs Q_OBJECT public: - GMSHPrefsDialog(GeoLib::GEOObjects const& geoObjects, QDialog* parent = nullptr); + explicit GMSHPrefsDialog(GeoLib::GEOObjects const& geoObjects, + QDialog* parent = nullptr); ~GMSHPrefsDialog() override; private: diff --git a/Applications/DataExplorer/DataView/GeoOnMeshMappingDialog.h b/Applications/DataExplorer/DataView/GeoOnMeshMappingDialog.h index 18775962dd4c9b6c0c70b96b3ec1da5df73d0299..a38a9953a5bf39eb1915b1676ea921cd8bb94a12 100644 --- a/Applications/DataExplorer/DataView/GeoOnMeshMappingDialog.h +++ b/Applications/DataExplorer/DataView/GeoOnMeshMappingDialog.h @@ -31,7 +31,7 @@ class GeoOnMeshMappingDialog : public QDialog, private Ui_GeoOnMeshMapping Q_OBJECT public: - GeoOnMeshMappingDialog( + explicit GeoOnMeshMappingDialog( std::vector<std::unique_ptr<MeshLib::Mesh>> const& mesh_vec, QDialog* parent = nullptr); ~GeoOnMeshMappingDialog() override; diff --git a/Applications/DataExplorer/DataView/GeoTabWidget.h b/Applications/DataExplorer/DataView/GeoTabWidget.h index 28e41780b88b9cc2ff56decac63a8e683630a61d..9d51f344ceebf8f38274805b42e1d8ec385966fd 100644 --- a/Applications/DataExplorer/DataView/GeoTabWidget.h +++ b/Applications/DataExplorer/DataView/GeoTabWidget.h @@ -25,7 +25,7 @@ class GeoTabWidget : public QWidget, public Ui_GeoTabWidgetBase Q_OBJECT public: - GeoTabWidget(QWidget* parent = nullptr); + explicit GeoTabWidget(QWidget* parent = nullptr); private: diff --git a/Applications/DataExplorer/DataView/GeoTreeModel.h b/Applications/DataExplorer/DataView/GeoTreeModel.h index e6840e701c86a60696e7241364a91f56b8808e24..7f861ab7e9f6e5f9d1457bab135773d56b3a2c84 100644 --- a/Applications/DataExplorer/DataView/GeoTreeModel.h +++ b/Applications/DataExplorer/DataView/GeoTreeModel.h @@ -42,7 +42,7 @@ class GeoTreeModel : public TreeModel Q_OBJECT public: - GeoTreeModel(QObject* parent = nullptr); + explicit GeoTreeModel(QObject* parent = nullptr); ~GeoTreeModel() override; /** diff --git a/Applications/DataExplorer/DataView/GeoTreeView.h b/Applications/DataExplorer/DataView/GeoTreeView.h index 5b2d2df63f82e9664db26d1a2d3b9722e43f0dce..609d51213f827bcea1a50baf7021bffe5c1d5d0f 100644 --- a/Applications/DataExplorer/DataView/GeoTreeView.h +++ b/Applications/DataExplorer/DataView/GeoTreeView.h @@ -31,7 +31,7 @@ class GeoTreeView : public QTreeView public: /// Constructor - GeoTreeView(QWidget* parent = nullptr); + explicit GeoTreeView(QWidget* parent = nullptr); /// Update the view to visualise changes made to the underlying data void updateView(); diff --git a/Applications/DataExplorer/DataView/LicenseDialog.h b/Applications/DataExplorer/DataView/LicenseDialog.h index e3f8f83a0da53cc125db18307750c9b5c5000ba9..23e44a25a07d169036e7246ba1083904ce89486a 100644 --- a/Applications/DataExplorer/DataView/LicenseDialog.h +++ b/Applications/DataExplorer/DataView/LicenseDialog.h @@ -25,7 +25,7 @@ class LicenseDialog : public QDialog, private Ui_License Q_OBJECT public: - LicenseDialog(QDialog* parent = nullptr); + explicit LicenseDialog(QDialog* parent = nullptr); ~LicenseDialog() override = default; ; diff --git a/Applications/DataExplorer/DataView/LineEditDialog.h b/Applications/DataExplorer/DataView/LineEditDialog.h index cc6df5993a9141ef22aca8ea7735c8214ae2eda7..ae9f7da773c2519233da46c802c22331fe982a1f 100644 --- a/Applications/DataExplorer/DataView/LineEditDialog.h +++ b/Applications/DataExplorer/DataView/LineEditDialog.h @@ -31,8 +31,8 @@ class LineEditDialog : public QDialog, private Ui_LineEdit Q_OBJECT public: - LineEditDialog(const GeoLib::PolylineVec& ply_vec, - QDialog* parent = nullptr); + explicit LineEditDialog(const GeoLib::PolylineVec& ply_vec, + QDialog* parent = nullptr); ~LineEditDialog() override; private: diff --git a/Applications/DataExplorer/DataView/MergeGeometriesDialog.h b/Applications/DataExplorer/DataView/MergeGeometriesDialog.h index 15e2adf049c015e622697d7b918ea6b2ffa27fdd..296517ad1acde3190da7d5c65f76da244b56e136 100644 --- a/Applications/DataExplorer/DataView/MergeGeometriesDialog.h +++ b/Applications/DataExplorer/DataView/MergeGeometriesDialog.h @@ -32,8 +32,8 @@ class MergeGeometriesDialog : public QDialog, private Ui_MergeGeometries Q_OBJECT public: - MergeGeometriesDialog(GeoLib::GEOObjects& geoObjects, - QDialog* parent = nullptr); + explicit MergeGeometriesDialog(GeoLib::GEOObjects& geoObjects, + QDialog* parent = nullptr); ~MergeGeometriesDialog() override; /// Returns a vector of selected geometries diff --git a/Applications/DataExplorer/DataView/MeshAnalysisDialog.h b/Applications/DataExplorer/DataView/MeshAnalysisDialog.h index 0da4a578ba4b4f5a0fea93efa813556235a356b5..adfc8ab0e50458a7b4977edf265633681f02b26e 100644 --- a/Applications/DataExplorer/DataView/MeshAnalysisDialog.h +++ b/Applications/DataExplorer/DataView/MeshAnalysisDialog.h @@ -33,7 +33,7 @@ class MeshAnalysisDialog : public QDialog, private Ui_MeshAnalysis Q_OBJECT public: - MeshAnalysisDialog( + explicit MeshAnalysisDialog( std::vector<std::unique_ptr<MeshLib::Mesh>> const& mesh_vec, QDialog* parent = nullptr); ~MeshAnalysisDialog() override; diff --git a/Applications/DataExplorer/DataView/MeshElementRemovalDialog.h b/Applications/DataExplorer/DataView/MeshElementRemovalDialog.h index 93b51d2248f249569b2c658133895ca336774c81..0017aabf9eb1a9affbee775045d760b27587ae1f 100644 --- a/Applications/DataExplorer/DataView/MeshElementRemovalDialog.h +++ b/Applications/DataExplorer/DataView/MeshElementRemovalDialog.h @@ -39,8 +39,8 @@ class MeshElementRemovalDialog : public QDialog, private Ui_MeshElementRemoval Q_OBJECT public: - MeshElementRemovalDialog(DataHolderLib::Project const& project, - QDialog* parent = nullptr); + explicit MeshElementRemovalDialog(DataHolderLib::Project const& project, + QDialog* parent = nullptr); ~MeshElementRemovalDialog() override; private slots: diff --git a/Applications/DataExplorer/DataView/MeshLayerEditDialog.h b/Applications/DataExplorer/DataView/MeshLayerEditDialog.h index 2d9511200046800370d6a50753e24108a12a99d9..fe73025d53bf90950e941e641b0a61e3585b9d6d 100644 --- a/Applications/DataExplorer/DataView/MeshLayerEditDialog.h +++ b/Applications/DataExplorer/DataView/MeshLayerEditDialog.h @@ -40,7 +40,8 @@ class MeshLayerEditDialog : public QDialog, private Ui_MeshLayerEdit Q_OBJECT public: - MeshLayerEditDialog(const MeshLib::Mesh* mesh, QDialog* parent = nullptr); + explicit MeshLayerEditDialog(const MeshLib::Mesh* mesh, + QDialog* parent = nullptr); ~MeshLayerEditDialog() override; private: diff --git a/Applications/DataExplorer/DataView/MeshMapping2DDialog.h b/Applications/DataExplorer/DataView/MeshMapping2DDialog.h index 112f7bacd683fd0bca2915560de7059a1507e345..74e89434fd22b04b4ab57bca2313e6ed68a4807e 100644 --- a/Applications/DataExplorer/DataView/MeshMapping2DDialog.h +++ b/Applications/DataExplorer/DataView/MeshMapping2DDialog.h @@ -23,7 +23,7 @@ class MeshMapping2DDialog : public QDialog, private Ui_MeshMapping2D Q_OBJECT public: - MeshMapping2DDialog(QDialog* parent = nullptr); + explicit MeshMapping2DDialog(QDialog* parent = nullptr); bool useRasterMapping() const { return this->rasterValueButton->isChecked(); } bool useStaticMapping() const { return this->staticValueButton->isChecked(); } diff --git a/Applications/DataExplorer/DataView/MeshModel.h b/Applications/DataExplorer/DataView/MeshModel.h index 19cfdce43aed0a2e8853b71a8fc7b0771f2004e1..a00b4f1e57d776d3ffa5d99f87f716bfb1629ab9 100644 --- a/Applications/DataExplorer/DataView/MeshModel.h +++ b/Applications/DataExplorer/DataView/MeshModel.h @@ -39,7 +39,8 @@ class MeshModel : public TreeModel Q_OBJECT public: - MeshModel(DataHolderLib::Project& project, QObject* parent = nullptr); + explicit MeshModel(DataHolderLib::Project& project, + QObject* parent = nullptr); /// Adds a new mesh void addMesh(std::unique_ptr<MeshLib::Mesh> mesh); @@ -59,7 +60,7 @@ public slots: /// Removes the mesh with the given name. bool removeMesh(const std::string &name); /// Updates the model/view for a mesh. - void updateMesh(MeshLib::Mesh*); + void updateMesh(MeshLib::Mesh* /*mesh*/); /// Updates the model based on the ProjectData-object void updateModel(); /// Returns the VTK source item for the mesh with the given index. diff --git a/Applications/DataExplorer/DataView/MeshQualitySelectionDialog.h b/Applications/DataExplorer/DataView/MeshQualitySelectionDialog.h index 76f2c77408d939a464e6af8330420533894dc30c..0743748f0733d353b15ef104ace1fdefb04cbd22 100644 --- a/Applications/DataExplorer/DataView/MeshQualitySelectionDialog.h +++ b/Applications/DataExplorer/DataView/MeshQualitySelectionDialog.h @@ -29,7 +29,7 @@ class MeshQualitySelectionDialog : public QDialog, private Ui_MeshQualitySelecti Q_OBJECT public: - MeshQualitySelectionDialog(QDialog* parent = nullptr); + explicit MeshQualitySelectionDialog(QDialog* parent = nullptr); ~MeshQualitySelectionDialog() override; /// Returns selected metric diff --git a/Applications/DataExplorer/DataView/MeshTabWidget.h b/Applications/DataExplorer/DataView/MeshTabWidget.h index 74827ed9cb183c470ac0d41dc70f638a65055145..97700a0dc5f2228b7b63a8a4c90c0d7b5aeb9233 100644 --- a/Applications/DataExplorer/DataView/MeshTabWidget.h +++ b/Applications/DataExplorer/DataView/MeshTabWidget.h @@ -25,7 +25,7 @@ class MeshTabWidget : public QWidget, public Ui_MeshTabWidgetBase Q_OBJECT public: - MeshTabWidget(QWidget* parent = nullptr); + explicit MeshTabWidget(QWidget* parent = nullptr); private slots: void enableSaveButton(bool enable) { this->saveMeshPushButton->setEnabled(enable); }; diff --git a/Applications/DataExplorer/DataView/MeshValueEditDialog.h b/Applications/DataExplorer/DataView/MeshValueEditDialog.h index c38791d73eac99e3ef0cd16832d8a778ac438b9e..c394d709d5dad1d6bf3f8290cd90d1488d2fb32d 100644 --- a/Applications/DataExplorer/DataView/MeshValueEditDialog.h +++ b/Applications/DataExplorer/DataView/MeshValueEditDialog.h @@ -31,7 +31,8 @@ class MeshValueEditDialog : public QDialog, private Ui_MeshValueEdit public: /// Constructor for creating a new FEM condition. - MeshValueEditDialog(MeshLib::Mesh* mesh, QDialog* parent = nullptr); + explicit MeshValueEditDialog(MeshLib::Mesh* mesh, + QDialog* parent = nullptr); ~MeshValueEditDialog() override; diff --git a/Applications/DataExplorer/DataView/MeshView.h b/Applications/DataExplorer/DataView/MeshView.h index 2baac35821629f0e5ff19d2b5d634cb7fef02a9e..ba20c7f6b6d4e201ac5af2ace7c7b0ac8dac3e85 100644 --- a/Applications/DataExplorer/DataView/MeshView.h +++ b/Applications/DataExplorer/DataView/MeshView.h @@ -37,7 +37,7 @@ class MeshView : public QTreeView Q_OBJECT public: - MeshView(QWidget* parent = nullptr); + explicit MeshView(QWidget* parent = nullptr); ~MeshView() override; public slots: diff --git a/Applications/DataExplorer/DataView/ModellingTabWidget.h b/Applications/DataExplorer/DataView/ModellingTabWidget.h index 19aadec186de4e0f14614e83fc80db104bd42a00..9fa2939b27fce31a5f61db58679ac64db4e17724 100644 --- a/Applications/DataExplorer/DataView/ModellingTabWidget.h +++ b/Applications/DataExplorer/DataView/ModellingTabWidget.h @@ -25,7 +25,7 @@ class ModellingTabWidget : public QWidget, public Ui_ModellingTabWidgetBase Q_OBJECT public: - ModellingTabWidget(QWidget* parent = nullptr); + explicit ModellingTabWidget(QWidget* parent = nullptr); private slots: diff --git a/Applications/DataExplorer/DataView/ProcessModel.h b/Applications/DataExplorer/DataView/ProcessModel.h index dc505bc6bda02a2f7a59df67c3f3ba124ca11e4b..6a4a61cc74d51b11efe43ef3bc3db772dd226d36 100644 --- a/Applications/DataExplorer/DataView/ProcessModel.h +++ b/Applications/DataExplorer/DataView/ProcessModel.h @@ -37,7 +37,8 @@ class ProcessModel final : public TreeModel Q_OBJECT public: - ProcessModel(DataHolderLib::Project& project, QObject* parent = nullptr); + explicit ProcessModel(DataHolderLib::Project& project, + QObject* parent = nullptr); int columnCount(const QModelIndex& parent = QModelIndex()) const override; diff --git a/Applications/DataExplorer/DataView/ProcessView.h b/Applications/DataExplorer/DataView/ProcessView.h index b47f947ddda40b08a845e655bae8adc25a091171..d36bac7cfe1f976860bd2671fce8e62bb41fecf0 100644 --- a/Applications/DataExplorer/DataView/ProcessView.h +++ b/Applications/DataExplorer/DataView/ProcessView.h @@ -32,7 +32,7 @@ class ProcessView final : public QTreeView public: /// Constructor - ProcessView(QWidget* parent = nullptr); + explicit ProcessView(QWidget* parent = nullptr); /// Update the view to visualise changes made to the underlying data void updateView(); diff --git a/Applications/DataExplorer/DataView/SaveMeshDialog.h b/Applications/DataExplorer/DataView/SaveMeshDialog.h index f3451474796688bc93cc3ad33e9fbd0b44d6fab0..54d3d494811be279f13dd30ebd89590507ca9c0b 100644 --- a/Applications/DataExplorer/DataView/SaveMeshDialog.h +++ b/Applications/DataExplorer/DataView/SaveMeshDialog.h @@ -29,7 +29,8 @@ class SaveMeshDialog : public QDialog, private Ui_SaveMesh Q_OBJECT public: - SaveMeshDialog(MeshLib::Mesh const& mesh, QDialog* parent = nullptr); + explicit SaveMeshDialog(MeshLib::Mesh const& mesh, + QDialog* parent = nullptr); ~SaveMeshDialog() override = default; private slots: diff --git a/Applications/DataExplorer/DataView/StationTabWidget.h b/Applications/DataExplorer/DataView/StationTabWidget.h index 6ca268f68e48b6066e16a5313002052353d52265..16ba71f93f4c30d1355e998dff6fe22052ea63ce 100644 --- a/Applications/DataExplorer/DataView/StationTabWidget.h +++ b/Applications/DataExplorer/DataView/StationTabWidget.h @@ -25,7 +25,7 @@ class StationTabWidget : public QWidget, public Ui_StationTabWidgetBase Q_OBJECT public: - StationTabWidget(QWidget* parent = nullptr); + explicit StationTabWidget(QWidget* parent = nullptr); private: diff --git a/Applications/DataExplorer/DataView/StationTreeModel.h b/Applications/DataExplorer/DataView/StationTreeModel.h index ba99cfddd0c766eb9285867fbaa273c3fd1f9ab2..44c60e8692c155bf27bd6fe8f87907ee55b16483 100644 --- a/Applications/DataExplorer/DataView/StationTreeModel.h +++ b/Applications/DataExplorer/DataView/StationTreeModel.h @@ -44,7 +44,7 @@ class StationTreeModel : public TreeModel Q_OBJECT public: - StationTreeModel(QObject* parent = nullptr); + explicit StationTreeModel(QObject* parent = nullptr); ~StationTreeModel() override; void addStationList(QString listName, const std::vector<GeoLib::Point*>* stations); diff --git a/Applications/DataExplorer/DataView/StationTreeView.h b/Applications/DataExplorer/DataView/StationTreeView.h index 0094c07569e3aac33e55bd43fa5bc4a06e608a4b..159ec9025e8d9df528447846a34d2e82fd2dd136 100644 --- a/Applications/DataExplorer/DataView/StationTreeView.h +++ b/Applications/DataExplorer/DataView/StationTreeView.h @@ -30,7 +30,7 @@ class StationTreeView : public QTreeView public: /// Constructor - StationTreeView(QWidget* parent = nullptr); + explicit StationTreeView(QWidget* parent = nullptr); /// Update the view to visualise changes made to the underlying data void updateView(); diff --git a/Applications/DataExplorer/DataView/StratView/StratBar.h b/Applications/DataExplorer/DataView/StratView/StratBar.h index 7155142d9475efdb9c8871087615b6a7387d1bfc..28736f78e29b837473203145d09fe76efa3e626d 100644 --- a/Applications/DataExplorer/DataView/StratView/StratBar.h +++ b/Applications/DataExplorer/DataView/StratView/StratBar.h @@ -35,9 +35,10 @@ public: * \param stratColors A color map. * \param parent The parent QGraphicsItem. */ - StratBar(GeoLib::StationBorehole* station, - std::map<std::string, DataHolderLib::Color>* stratColors = nullptr, - QGraphicsItem* parent = nullptr); + explicit StratBar( + GeoLib::StationBorehole* station, + std::map<std::string, DataHolderLib::Color>* stratColors = nullptr, + QGraphicsItem* parent = nullptr); ~StratBar() override = default; /// Returns the bounding rectangle of the bar. diff --git a/Applications/DataExplorer/DataView/StratView/StratScene.h b/Applications/DataExplorer/DataView/StratView/StratScene.h index 8ab6461a1bf3e8fa51510076803a0343224d3a7a..e4f19dbe2ba1d24ac93ddb8285fec02c94322d64 100644 --- a/Applications/DataExplorer/DataView/StratView/StratScene.h +++ b/Applications/DataExplorer/DataView/StratView/StratScene.h @@ -29,7 +29,7 @@ class StratScene : public QGraphicsScene { public: /// Constructor - StratScene( + explicit StratScene( GeoLib::StationBorehole* station, std::map<std::string, DataHolderLib::Color>* stratColors = nullptr, QObject* parent = nullptr); diff --git a/Applications/DataExplorer/DataView/StratView/StratView.h b/Applications/DataExplorer/DataView/StratView/StratView.h index 0fc64a60436d5d9901b9e6d8d51af77287bcc82b..32176d3d9f23058c1ae3a0c7b21b4c6f079ff843 100644 --- a/Applications/DataExplorer/DataView/StratView/StratView.h +++ b/Applications/DataExplorer/DataView/StratView/StratView.h @@ -34,7 +34,7 @@ public: /** * Creates an empty view. */ - StratView(QWidget* parent = nullptr) { Q_UNUSED(parent); } + explicit StratView(QWidget* parent = nullptr) { Q_UNUSED(parent); } ~StratView() override; /// Sets the Borehole whose data should be visualised. diff --git a/Applications/DataExplorer/DataView/StratView/StratWindow.h b/Applications/DataExplorer/DataView/StratView/StratWindow.h index 3e44de0bd8520c0f6e52dc874964581af20940b8..f1ba17558cf6515fe7b52464def4b40a846ef82f 100644 --- a/Applications/DataExplorer/DataView/StratView/StratWindow.h +++ b/Applications/DataExplorer/DataView/StratView/StratWindow.h @@ -36,7 +36,7 @@ public: * \param stratColors A color map. * \param parent The parent QWidget. */ - StratWindow( + explicit StratWindow( GeoLib::StationBorehole* station, std::map<std::string, DataHolderLib::Color>* stratColors = nullptr, QWidget* parent = nullptr); diff --git a/Applications/DataExplorer/DataView/SurfaceExtractionDialog.h b/Applications/DataExplorer/DataView/SurfaceExtractionDialog.h index 936ed97f4e4fb60eb69cbc2bd50a6efb113d3258..beea7116aacf6e363ccfe1e2ebef5181e3f2cc68 100644 --- a/Applications/DataExplorer/DataView/SurfaceExtractionDialog.h +++ b/Applications/DataExplorer/DataView/SurfaceExtractionDialog.h @@ -31,7 +31,7 @@ class SurfaceExtractionDialog : public QDialog, private Ui_SurfaceExtraction Q_OBJECT public: - SurfaceExtractionDialog(QDialog* parent = nullptr); + explicit SurfaceExtractionDialog(QDialog* parent = nullptr); ~SurfaceExtractionDialog() override = default; int getTolerance() const { return _tolerance; } diff --git a/Applications/DataExplorer/VtkVis/MeshFromRasterDialog.h b/Applications/DataExplorer/VtkVis/MeshFromRasterDialog.h index 0ea29d3eb33234b75bc945e0a3e2bd74d3bd59d6..a3fe99cd8e7ff74bfa91ff5aaa8d7168a7f6173f 100644 --- a/Applications/DataExplorer/VtkVis/MeshFromRasterDialog.h +++ b/Applications/DataExplorer/VtkVis/MeshFromRasterDialog.h @@ -34,7 +34,7 @@ class MeshFromRasterDialog : public QDialog, private Ui_MeshFromRaster public: /// Constructor - MeshFromRasterDialog(QDialog* parent = nullptr); + explicit MeshFromRasterDialog(QDialog* parent = nullptr); ~MeshFromRasterDialog() override; std::string getMeshName() const { return _mesh_name; } diff --git a/Applications/DataExplorer/VtkVis/VisualizationWidget.h b/Applications/DataExplorer/VtkVis/VisualizationWidget.h index c0155df259271fbab53e3c1a0886ea4e07c7e2fd..da506e21cfa156c6032986a009e520d63d59b2f5 100644 --- a/Applications/DataExplorer/VtkVis/VisualizationWidget.h +++ b/Applications/DataExplorer/VtkVis/VisualizationWidget.h @@ -32,7 +32,7 @@ class VisualizationWidget : public QWidget, public Ui_VisualizationWidgetBase public: /// @brief Constructor. - VisualizationWidget(QWidget* parent = nullptr); + explicit VisualizationWidget(QWidget* parent = nullptr); /// @brief Destructor. ~VisualizationWidget() override; diff --git a/Applications/DataExplorer/VtkVis/VtkAlgorithmProperties.h b/Applications/DataExplorer/VtkVis/VtkAlgorithmProperties.h index 7bfc0b434896de1215da80a92fadc3c387dc0743..af0ff3cbbab9b86c828546cf4146b451a3db4365 100644 --- a/Applications/DataExplorer/VtkVis/VtkAlgorithmProperties.h +++ b/Applications/DataExplorer/VtkVis/VtkAlgorithmProperties.h @@ -140,7 +140,7 @@ class VtkAlgorithmProperties : public QObject public: /// Constructor (sets default values) - VtkAlgorithmProperties(QObject* parent = nullptr); + explicit VtkAlgorithmProperties(QObject* parent = nullptr); ~VtkAlgorithmProperties() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeColorByHeightFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeColorByHeightFilter.h index 4c6f07ea96ad8aa68dcd6ce900d5fab19dc3e1ec..c69e3209e224b5624f17b68d0cafa8e3e11abe29 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositeColorByHeightFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositeColorByHeightFilter.h @@ -22,7 +22,7 @@ class vtkSphereSource; class VtkCompositeColorByHeightFilter : public VtkCompositeFilter { public: - VtkCompositeColorByHeightFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositeColorByHeightFilter(vtkAlgorithm* inputAlgorithm); ~VtkCompositeColorByHeightFilter() override = default; void init() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeColormapToImageFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeColormapToImageFilter.h index a63f01860cea1779fdab274d878f519c72ab5e6d..8800983270b67395b1480dbddc01068d5008146b 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositeColormapToImageFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositeColormapToImageFilter.h @@ -20,7 +20,7 @@ class VtkCompositeColormapToImageFilter : public VtkCompositeFilter { public: - VtkCompositeColormapToImageFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositeColormapToImageFilter(vtkAlgorithm* inputAlgorithm); ~VtkCompositeColormapToImageFilter() override; void init() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeContourFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeContourFilter.h index 0a02824772dcd42b35d04da47df60ed662cc7703..493d8f83254f307c4fc16e74995aee76287883f8 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositeContourFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositeContourFilter.h @@ -22,7 +22,7 @@ class VtkCompositeContourFilter : public VtkCompositeFilter { public: - VtkCompositeContourFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositeContourFilter(vtkAlgorithm* inputAlgorithm); ~VtkCompositeContourFilter() override; void init() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeElementSelectionFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeElementSelectionFilter.h index cd364f986f11937f1fe05adbba7caf4cfcecd6b2..c61e716312b9d454fe4b4b2ee266d866293abd28 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositeElementSelectionFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositeElementSelectionFilter.h @@ -26,7 +26,7 @@ class VtkColorLookupTable; class VtkCompositeElementSelectionFilter : public VtkCompositeFilter { public: - VtkCompositeElementSelectionFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositeElementSelectionFilter(vtkAlgorithm* inputAlgorithm); ~VtkCompositeElementSelectionFilter() override = default; void init() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeFilter.h index 3414bf34a6c33407e1783565ab94258b662ce2b6..91e073ab982ed87356772e352b9fabcf030b6cf4 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositeFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositeFilter.h @@ -43,7 +43,7 @@ class VtkCompositeFilter : public VtkAlgorithmProperties public: /// @brief Constructor. /// @param inputAlgorithm The algorithm to attach this filter to. - VtkCompositeFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositeFilter(vtkAlgorithm* inputAlgorithm); /// @brief Destructor. ~VtkCompositeFilter() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeGeoObjectFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeGeoObjectFilter.h index 3aa3644e05559430f35048c4adc63ac06176e04b..0ab673b6e2a549ddfe4117a140737dc61401f7d1 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositeGeoObjectFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositeGeoObjectFilter.h @@ -23,7 +23,7 @@ class vtkThreshold; class VtkCompositeGeoObjectFilter : public VtkCompositeFilter { public: - VtkCompositeGeoObjectFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositeGeoObjectFilter(vtkAlgorithm* inputAlgorithm); ~VtkCompositeGeoObjectFilter() override; void init() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeImageToCylindersFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeImageToCylindersFilter.h index 2c00445c3cd88b23cff21915f7df29f9c3f7370c..a4b140976b19dabb5b57ff8dfaf2968272eed76b 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositeImageToCylindersFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositeImageToCylindersFilter.h @@ -24,7 +24,7 @@ class VtkImageDataToLinePolyDataFilter; class VtkCompositeImageToCylindersFilter : public VtkCompositeFilter { public: - VtkCompositeImageToCylindersFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositeImageToCylindersFilter(vtkAlgorithm* inputAlgorithm); ~VtkCompositeImageToCylindersFilter() override; void init() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeImageToPointCloudFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeImageToPointCloudFilter.h index e9ffec6ed5f9b4e67b3f80bd9942aa9fadf55a77..17d5f6e0397f8d620998e4e0af75565dabcb505f 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositeImageToPointCloudFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositeImageToPointCloudFilter.h @@ -16,7 +16,7 @@ class VtkImageDataToPointCloudFilter; class VtkCompositeImageToPointCloudFilter : public VtkCompositeFilter { public: - VtkCompositeImageToPointCloudFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositeImageToPointCloudFilter(vtkAlgorithm* inputAlgorithm); ~VtkCompositeImageToPointCloudFilter() override = default; void init() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeImageToSurfacePointsFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeImageToSurfacePointsFilter.h index f53faf66a40a14535b3827008878277697182d40..e4576d19c56ec607dfc56e1f4ca25a4e4342aeb0 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositeImageToSurfacePointsFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositeImageToSurfacePointsFilter.h @@ -16,7 +16,8 @@ class VtkImageDataToSurfacePointsFilter; class VtkCompositeImageToSurfacePointsFilter : public VtkCompositeFilter { public: - VtkCompositeImageToSurfacePointsFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositeImageToSurfacePointsFilter( + vtkAlgorithm* inputAlgorithm); ~VtkCompositeImageToSurfacePointsFilter() override = default; void init() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeLineToTubeFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeLineToTubeFilter.h index bbb226daa09255ccb28650434f8c882bcddd53a8..eed50103078b7e0f49ef1da263cc67fe0d81cb37 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositeLineToTubeFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositeLineToTubeFilter.h @@ -20,7 +20,7 @@ class VtkCompositeLineToTubeFilter : public VtkCompositeFilter { public: - VtkCompositeLineToTubeFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositeLineToTubeFilter(vtkAlgorithm* inputAlgorithm); ~VtkCompositeLineToTubeFilter() override; void init() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeNodeSelectionFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeNodeSelectionFilter.h index 67f1a735600dffe9bdbd18b599e1947dce7187d8..2835f57df0237849a02bd47ee101465a5ded6eb5 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositeNodeSelectionFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositeNodeSelectionFilter.h @@ -23,7 +23,7 @@ class VtkCompositeNodeSelectionFilter : public VtkCompositeFilter { public: - VtkCompositeNodeSelectionFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositeNodeSelectionFilter(vtkAlgorithm* inputAlgorithm); ~VtkCompositeNodeSelectionFilter() override; void init() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositePointToGlyphFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositePointToGlyphFilter.h index 54790254b64e145187c67a1303e60ec3cd1d0955..96fa3d11ae3d5a519013248983231cf7da64a6e8 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositePointToGlyphFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositePointToGlyphFilter.h @@ -22,7 +22,7 @@ class vtkSphereSource; class VtkCompositePointToGlyphFilter : public VtkCompositeFilter { public: - VtkCompositePointToGlyphFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositePointToGlyphFilter(vtkAlgorithm* inputAlgorithm); ~VtkCompositePointToGlyphFilter() override; void init() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeTextureOnSurfaceFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeTextureOnSurfaceFilter.h index 44c89fd76bea9516f0bfff04350a8abd4317695d..3b479c17ebc233015d2f7ee14a16f060060039ae 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositeTextureOnSurfaceFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositeTextureOnSurfaceFilter.h @@ -22,7 +22,7 @@ class vtkSphereSource; class VtkCompositeTextureOnSurfaceFilter : public VtkCompositeFilter { public: - VtkCompositeTextureOnSurfaceFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositeTextureOnSurfaceFilter(vtkAlgorithm* inputAlgorithm); ~VtkCompositeTextureOnSurfaceFilter() override; void init() override; diff --git a/Applications/DataExplorer/VtkVis/VtkCompositeThresholdFilter.h b/Applications/DataExplorer/VtkVis/VtkCompositeThresholdFilter.h index 77e4d5387b2cecb28341f8f04e5c268df0780e3d..aaa9684df2d91c51235bcb507ad775876d4c37f1 100644 --- a/Applications/DataExplorer/VtkVis/VtkCompositeThresholdFilter.h +++ b/Applications/DataExplorer/VtkVis/VtkCompositeThresholdFilter.h @@ -22,7 +22,7 @@ class VtkCompositeThresholdFilter : public VtkCompositeFilter { public: - VtkCompositeThresholdFilter(vtkAlgorithm* inputAlgorithm); + explicit VtkCompositeThresholdFilter(vtkAlgorithm* inputAlgorithm); ~VtkCompositeThresholdFilter() override; void init() override; diff --git a/Applications/DataExplorer/VtkVis/VtkConsoleOutputWindow.h b/Applications/DataExplorer/VtkVis/VtkConsoleOutputWindow.h index b6db5d80a8352197084272da1e75d560036493b4..c80f5c580e5ce10a4c79a813bbf152c703e065e8 100644 --- a/Applications/DataExplorer/VtkVis/VtkConsoleOutputWindow.h +++ b/Applications/DataExplorer/VtkVis/VtkConsoleOutputWindow.h @@ -24,7 +24,7 @@ public: void PrintSelf(ostream& os, vtkIndent indent) override; static VtkConsoleOutputWindow * New(); - void DisplayText(const char*) override; + void DisplayText(const char* /*unused*/) override; VtkConsoleOutputWindow(const VtkConsoleOutputWindow&) = delete; void operator=(const VtkConsoleOutputWindow&) = delete; diff --git a/Applications/DataExplorer/VtkVis/VtkVisPipeline.h b/Applications/DataExplorer/VtkVis/VtkVisPipeline.h index ccbea1d46a1caa019b856c2e70c36f0c898e18ba..1d9aa2d417cec3b98d1845042d9603b310c8210a 100644 --- a/Applications/DataExplorer/VtkVis/VtkVisPipeline.h +++ b/Applications/DataExplorer/VtkVis/VtkVisPipeline.h @@ -57,7 +57,7 @@ class VtkVisPipeline : public TreeModel Q_OBJECT public: - VtkVisPipeline(vtkRenderer* renderer, QObject* parent = nullptr); + explicit VtkVisPipeline(vtkRenderer* renderer, QObject* parent = nullptr); /// \brief Emits vtkVisPipelineChanged() and calls base class method. bool setData(const QModelIndex& index, const QVariant& value, diff --git a/Applications/DataExplorer/VtkVis/VtkVisPipelineView.h b/Applications/DataExplorer/VtkVis/VtkVisPipelineView.h index 61370f8e9f0eeaa16624fe2328466b49ddd07ed5..fefee39ed9939a1e245cc054d5164628b793e1c0 100644 --- a/Applications/DataExplorer/VtkVis/VtkVisPipelineView.h +++ b/Applications/DataExplorer/VtkVis/VtkVisPipelineView.h @@ -40,7 +40,7 @@ class VtkVisPipelineView : public QTreeView public: /// @brief Constructor. - VtkVisPipelineView(QWidget* parent = nullptr); + explicit VtkVisPipelineView(QWidget* parent = nullptr); /// @brief Overridden to set model specific header properties. void setModel(QAbstractItemModel* model) override; diff --git a/Applications/DataExplorer/VtkVis/VtkVisTabWidget.h b/Applications/DataExplorer/VtkVis/VtkVisTabWidget.h index 1ccd0ac61b09b05fb5a6918188628c9974bac97f..3be22090265071cf48808a9977a7be73f1648f11 100644 --- a/Applications/DataExplorer/VtkVis/VtkVisTabWidget.h +++ b/Applications/DataExplorer/VtkVis/VtkVisTabWidget.h @@ -30,7 +30,7 @@ class VtkVisTabWidget : public QWidget, public Ui_VtkVisTabWidgetBase public: /// Constructor - VtkVisTabWidget(QWidget* parent = nullptr); + explicit VtkVisTabWidget(QWidget* parent = nullptr); protected slots: /// Updates the property panels to show informations on the given VtkVisPipelineItem. diff --git a/Applications/DataExplorer/mainwindow.h b/Applications/DataExplorer/mainwindow.h index b5532f95f5b0d5c4c1f5494cba47357cc526f56d..7f6d2cbce8692a4306b1f202e3cdf5a531e62907 100644 --- a/Applications/DataExplorer/mainwindow.h +++ b/Applications/DataExplorer/mainwindow.h @@ -42,7 +42,7 @@ class MainWindow : public QMainWindow, public Ui_MainWindowClass Q_OBJECT public: - MainWindow(QWidget* parent = nullptr); + explicit MainWindow(QWidget* parent = nullptr); void ShowWindow(); void HideWindow(); diff --git a/Applications/FileIO/Gmsh/GMSHAdaptiveMeshDensity.h b/Applications/FileIO/Gmsh/GMSHAdaptiveMeshDensity.h index f1036515ddf62819d2120a813606eaaa2385e265..8c7ac58e0a4fb8bae49b1759cf70e824e15a7218 100644 --- a/Applications/FileIO/Gmsh/GMSHAdaptiveMeshDensity.h +++ b/Applications/FileIO/Gmsh/GMSHAdaptiveMeshDensity.h @@ -37,7 +37,8 @@ public: void initialize(std::vector<GeoLib::Point const*> const& pnts) override; double getMeshDensityAtPoint(GeoLib::Point const* const pnt) const override; void addPoints(std::vector<GeoLib::Point const*> const& pnts); - double getMeshDensityAtStation(GeoLib::Point const* const) const override; + double getMeshDensityAtStation( + GeoLib::Point const* const /*unused*/) const override; void getSteinerPoints (std::vector<GeoLib::Point*> & pnts, std::size_t additional_levels = 0) const; #ifndef NDEBUG diff --git a/Applications/FileIO/Gmsh/GMSHFixedMeshDensity.h b/Applications/FileIO/Gmsh/GMSHFixedMeshDensity.h index 34b3f6193959086ef79c56811f4b9feda1232bf9..b838a680e0258dfdacfc4c9fecdf7d45cb0df45d 100644 --- a/Applications/FileIO/Gmsh/GMSHFixedMeshDensity.h +++ b/Applications/FileIO/Gmsh/GMSHFixedMeshDensity.h @@ -22,8 +22,10 @@ class GMSHFixedMeshDensity final : public GMSHMeshDensityStrategy public: explicit GMSHFixedMeshDensity(double mesh_density); void initialize(std::vector<GeoLib::Point const*> const& vec) override; - double getMeshDensityAtPoint(GeoLib::Point const* const) const override; - double getMeshDensityAtStation(GeoLib::Point const* const) const override; + double getMeshDensityAtPoint( + GeoLib::Point const* const /*unused*/) const override; + double getMeshDensityAtStation( + GeoLib::Point const* const /*unused*/) const override; ~GMSHFixedMeshDensity() override = default; private: diff --git a/Applications/Utils/OGSFileConverter/OGSFileConverter.h b/Applications/Utils/OGSFileConverter/OGSFileConverter.h index 2d5a0e67057f9181489bf136ec91df10b7817ede..33fb685176ddf6a3102f5468db8dd2797d800162 100644 --- a/Applications/Utils/OGSFileConverter/OGSFileConverter.h +++ b/Applications/Utils/OGSFileConverter/OGSFileConverter.h @@ -26,7 +26,8 @@ class OGSFileConverter : public QDialog, private Ui_OGSFileConverter public: /// Constructor - OGSFileConverter(std::string const& gmsh_path, QWidget* parent = nullptr); + explicit OGSFileConverter(std::string const& gmsh_path, + QWidget* parent = nullptr); /// Destructor ~OGSFileConverter() override; diff --git a/BaseLib/ConfigTree-impl.h b/BaseLib/ConfigTree-impl.h index 9acdf51c07393bdcf350664932dd6092fcc08916..a4ffe1907640d15873f4801df43cea4d14f3d140 100644 --- a/BaseLib/ConfigTree-impl.h +++ b/BaseLib/ConfigTree-impl.h @@ -71,7 +71,7 @@ boost::optional<T> ConfigTree::getConfigParameterOptional( template <typename T> boost::optional<T> ConfigTree::getConfigParameterOptionalImpl( - std::string const& param, T*) const + std::string const& param, T* /*unused*/) const { if (auto p = getConfigSubtreeOptional(param)) { @@ -83,7 +83,7 @@ boost::optional<T> ConfigTree::getConfigParameterOptionalImpl( template <typename T> boost::optional<std::vector<T>> ConfigTree::getConfigParameterOptionalImpl( - std::string const& param, std::vector<T>*) const + std::string const& param, std::vector<T>* /*unused*/) const { if (auto p = getConfigSubtreeOptional(param)) { diff --git a/BaseLib/ConfigTree.h b/BaseLib/ConfigTree.h index a7634b56ba9d136dce4309218c2c539ec6a05888..7f55a51f06f9eff9987d5b12f3481ef35c3b0ccc 100644 --- a/BaseLib/ConfigTree.h +++ b/BaseLib/ConfigTree.h @@ -268,7 +268,7 @@ public: //! After being moved from, \c other is in an undefined state and must not be //! used anymore! - ConfigTree& operator=(ConfigTree &&); + ConfigTree& operator=(ConfigTree&& other); //! Used to get the project file name. std::string const& getProjectFileName() const { return _filename; } @@ -520,12 +520,14 @@ public: private: //! Default implementation of reading a value of type T. - template<typename T> boost::optional<T> - getConfigParameterOptionalImpl(std::string const& param, T*) const; + template <typename T> + boost::optional<T> getConfigParameterOptionalImpl(std::string const& param, + T* /*unused*/) const; //! Implementation of reading a vector of values of type T. - template<typename T> boost::optional<std::vector<T>> - getConfigParameterOptionalImpl(std::string const& param, std::vector<T>*) const; + template <typename T> + boost::optional<std::vector<T>> getConfigParameterOptionalImpl( + std::string const& param, std::vector<T>* /*unused*/) const; struct CountType { diff --git a/BaseLib/FileFinder.h b/BaseLib/FileFinder.h index b08cac34d04df615d6bbfd7c35702e7f93d9e541..b33a60078cf99d3381ae75c5c01645292f5cbc09 100644 --- a/BaseLib/FileFinder.h +++ b/BaseLib/FileFinder.h @@ -37,7 +37,7 @@ public: * * @param dirs an initializer list of additional directory paths to the search-space */ - explicit FileFinder(std::initializer_list<std::string> dirs); + FileFinder(std::initializer_list<std::string> dirs); /** * \brief Adds another directory to the search-space. diff --git a/BaseLib/Functional.h b/BaseLib/Functional.h index 09f0c0ff0f0bf81969c275040f670a57766953da..632414a92c3376a75e4a123afa3c755f766377fd 100644 --- a/BaseLib/Functional.h +++ b/BaseLib/Functional.h @@ -100,7 +100,7 @@ template <int... Indices, typename Object, typename MethodClass, typename ReturnType, typename... Args> std::function<ReturnType(Args...)> easyBind_inner( ReturnType (MethodClass::*method)(Args...), Object&& obj, - std::integer_sequence<int, Indices...>) + std::integer_sequence<int, Indices...> /*unused*/) { return easyBind_innermost<Indices...>(method, std::forward<Object>(obj)); } @@ -109,7 +109,7 @@ template <int... Indices, typename Object, typename MethodClass, typename ReturnType, typename... Args> std::function<ReturnType(Args...)> easyBind_inner( ReturnType (MethodClass::*method)(Args...) const, Object&& obj, - std::integer_sequence<int, Indices...>) + std::integer_sequence<int, Indices...> /*unused*/) { return easyBind_innermost<Indices...>(method, std::forward<Object>(obj)); } diff --git a/BaseLib/TCLAPCustomOutput.h b/BaseLib/TCLAPCustomOutput.h index 3c3ef0034f4c2f3a7d56b4060bcc9c7c4e6782ee..0154040ef28511cdd71d8b0bdd9e70aab817ce63 100644 --- a/BaseLib/TCLAPCustomOutput.h +++ b/BaseLib/TCLAPCustomOutput.h @@ -35,7 +35,7 @@ public: * produce alternative behavior. * \param c - The CmdLine object the output is generated for. */ - virtual void usage(TCLAP::CmdLineInterface& c); + virtual void usage(TCLAP::CmdLineInterface& _cmd); /** * Prints (to stderr) an error message, short usage @@ -43,8 +43,7 @@ public: * \param c - The CmdLine object the output is generated for. * \param e - The ArgException that caused the failure. */ - virtual void failure(TCLAP::CmdLineInterface& c, - TCLAP::ArgException& e ); + virtual void failure(TCLAP::CmdLineInterface& _cmd, TCLAP::ArgException& e); protected: @@ -53,7 +52,7 @@ protected: * \param c - The CmdLine object the output is generated for. * \param os - The stream to write the message to. */ - void _shortUsage( TCLAP::CmdLineInterface& c, std::ostream& os ) const; + void _shortUsage(TCLAP::CmdLineInterface& _cmd, std::ostream& os) const; /** * Writes a longer usage message with long and short args, @@ -61,8 +60,7 @@ protected: * \param c - The CmdLine object the output is generated for. * \param os - The stream to write the message to. */ - void _longUsage( TCLAP::CmdLineInterface& c, std::ostream& os ) const; - + void _longUsage(TCLAP::CmdLineInterface& _cmd, std::ostream& os) const; }; inline void TCLAPCustomOutput::usage(TCLAP::CmdLineInterface& _cmd ) diff --git a/GeoLib/GEOObjects.h b/GeoLib/GEOObjects.h index abf5218d9c737448f53ff217c299b151e9a2a4c2..5772f49776e9f24168567859c4644b7fe211a928 100644 --- a/GeoLib/GEOObjects.h +++ b/GeoLib/GEOObjects.h @@ -64,17 +64,20 @@ class GEOObjects final public: struct Callbacks { - virtual void addPointVec(std::string const&){} - virtual void removePointVec(std::string const&){} - virtual void addStationVec(std::string const&){} - virtual void removeStationVec(std::string const&){} - virtual void addPolylineVec(std::string const&){} - virtual void appendPolylineVec(std::string const&){} - virtual void removePolylineVec(std::string const&){} - virtual void addSurfaceVec(std::string const&){} - virtual void appendSurfaceVec(std::string const&){} - virtual void removeSurfaceVec(std::string const&){} - virtual void renameGeometry(std::string const&, std::string const&) {} + virtual void addPointVec(std::string const& /*unused*/) {} + virtual void removePointVec(std::string const& /*unused*/) {} + virtual void addStationVec(std::string const& /*unused*/) {} + virtual void removeStationVec(std::string const& /*unused*/) {} + virtual void addPolylineVec(std::string const& /*unused*/) {} + virtual void appendPolylineVec(std::string const& /*unused*/) {} + virtual void removePolylineVec(std::string const& /*unused*/) {} + virtual void addSurfaceVec(std::string const& /*unused*/) {} + virtual void appendSurfaceVec(std::string const& /*unused*/) {} + virtual void removeSurfaceVec(std::string const& /*unused*/) {} + virtual void renameGeometry(std::string const& /*unused*/, + std::string const& /*unused*/) + { + } virtual ~Callbacks() = default; }; @@ -308,34 +311,22 @@ public: std::unique_ptr<Callbacks> _callbacks{new Callbacks}; std::function<void(std::string const&)> addPolylineVecCallback = - [](std::string const&) - { - }; + [](std::string const& /*unused*/) {}; std::function<void(std::string const&)> appendPolylineVecCallback = - [](std::string const&) - { - }; + [](std::string const& /*unused*/) {}; std::function<void(std::string const&)> removePolylineVecCallback = - [](std::string const&) - { - }; + [](std::string const& /*unused*/) {}; std::function<void(std::string const&)> addSurfaceVecCallback = - [](std::string const&) - { - }; + [](std::string const& /*unused*/) {}; std::function<void(std::string const&)> appendSurfaceVecCallback = - [](std::string const&) - { - }; + [](std::string const& /*unused*/) {}; std::function<void(std::string const&)> removeSurfaceVecCallback = - [](std::string const&) - { - }; + [](std::string const& /*unused*/) {}; private: /** diff --git a/GeoLib/Grid.h b/GeoLib/Grid.h index a67254118f75b9af2dd86f2bb0a7ef0988929f97..5691c02b34e5cd8986e21606b0ccb99812139ae2 100644 --- a/GeoLib/Grid.h +++ b/GeoLib/Grid.h @@ -49,7 +49,8 @@ public: * */ template <typename InputIterator> - Grid(InputIterator first, InputIterator last, std::size_t items_per_cell = 512); + Grid(InputIterator first, InputIterator last, + std::size_t max_num_per_grid_cell = 512); /** * This is the destructor of the class. It deletes the internal data structures *not* @@ -165,7 +166,7 @@ private: */ template <typename P> std::array<double, 6> getPointCellBorderDistances( - P const& pnt, std::array<std::size_t,3> const& coordinates) const; + P const& pnt, std::array<std::size_t, 3> const& coords) const; template <typename P> bool calcNearestPointInGridCell(P const& pnt, diff --git a/MaterialLib/Adsorption/Reaction.h b/MaterialLib/Adsorption/Reaction.h index e5ee5c1d78bcaa638ba2888d358f3a46f1b0006b..213d588abdf270faeb053da5e0c0027ffc17ee7a 100644 --- a/MaterialLib/Adsorption/Reaction.h +++ b/MaterialLib/Adsorption/Reaction.h @@ -27,7 +27,10 @@ public: const double M_Ads, const double loading) const = 0; // TODO get rid of - virtual double getEquilibriumLoading(const double, const double, const double) const { + virtual double getEquilibriumLoading(const double /*unused*/, + const double /*unused*/, + const double /*unused*/) const + { return -1.0; } diff --git a/MaterialLib/FractureModels/Permeability/ConstantPermeability.h b/MaterialLib/FractureModels/Permeability/ConstantPermeability.h index cbe99490ead5260a02832f496b10525c2ab6f0ba..86d0abd68bc6bfced047366831e77ea5ac40a055 100644 --- a/MaterialLib/FractureModels/Permeability/ConstantPermeability.h +++ b/MaterialLib/FractureModels/Permeability/ConstantPermeability.h @@ -18,7 +18,7 @@ namespace MaterialLib::Fracture::Permeability class ConstantPermeability final : public Permeability { public: - ConstantPermeability(double const permeability); + explicit ConstantPermeability(double const permeability); private: double permeability(PermeabilityState const* const /*state*/, diff --git a/MathLib/Integration/WeightedSum.h b/MathLib/Integration/WeightedSum.h index cbb932d34e8716bdd8d5e531a5c826fb46aa4cfd..947c4a61e5c953fb2aee680131191c55835a9964 100644 --- a/MathLib/Integration/WeightedSum.h +++ b/MathLib/Integration/WeightedSum.h @@ -32,9 +32,7 @@ template <typename Method> struct SUM<0, Method> { template <typename F> - static - double - add(F const&) + static double add(F const& /*unused*/) { return 0; } diff --git a/MathLib/LinAlg/Dense/DenseMatrix.h b/MathLib/LinAlg/Dense/DenseMatrix.h index bfc93604f6de6110fea97bc944dd06208efd1fd9..19ea433ef7a9b145091022464f96a78e7cdf0d97 100644 --- a/MathLib/LinAlg/Dense/DenseMatrix.h +++ b/MathLib/LinAlg/Dense/DenseMatrix.h @@ -33,7 +33,7 @@ public: /// Dense rectangular matrix constructor. DenseMatrix (IDX_TYPE rows, IDX_TYPE cols); - DenseMatrix (IDX_TYPE rows, IDX_TYPE cols, const FP_TYPE& val); + DenseMatrix(IDX_TYPE rows, IDX_TYPE cols, const FP_TYPE& initial_value); DenseMatrix (const DenseMatrix &src); /** * Move constructor. diff --git a/MathLib/LinAlg/FinalizeMatrixAssembly.h b/MathLib/LinAlg/FinalizeMatrixAssembly.h index f278275eeeb24b24bf292362a0b6ddcce0c15f12..96fe660c8d814e24dd91b72bedf06d3b3d168ff4 100644 --- a/MathLib/LinAlg/FinalizeMatrixAssembly.h +++ b/MathLib/LinAlg/FinalizeMatrixAssembly.h @@ -15,9 +15,8 @@ namespace MathLib { - template <typename MAT_T> -bool finalizeMatrixAssembly(MAT_T &) +bool finalizeMatrixAssembly(MAT_T& /*unused*/) { return true; } diff --git a/MathLib/LinAlg/FinalizeVectorAssembly.h b/MathLib/LinAlg/FinalizeVectorAssembly.h index a1de94eef03510a462e071f7e0da130e4aa4c014..eb47de7741f955b4e71f83ae08ee9d1807a1a60c 100644 --- a/MathLib/LinAlg/FinalizeVectorAssembly.h +++ b/MathLib/LinAlg/FinalizeVectorAssembly.h @@ -17,7 +17,7 @@ namespace MathLib { /// General function to finalize the vector assembly template <typename VEC_T> -void finalizeVectorAssembly(VEC_T &) +void finalizeVectorAssembly(VEC_T& /*unused*/) { } diff --git a/MathLib/LinAlg/SetMatrixSparsity.h b/MathLib/LinAlg/SetMatrixSparsity.h index 3013e9d1c2aad3074a160c092f5c575e75cef070..bbcd1ec0c42102c83ea2fd5caf400f0d09e944f5 100644 --- a/MathLib/LinAlg/SetMatrixSparsity.h +++ b/MathLib/LinAlg/SetMatrixSparsity.h @@ -17,8 +17,7 @@ namespace MathLib template <typename MATRIX, typename SPARSITY_PATTERN> struct SetMatrixSparsity { - void operator()(MATRIX&, SPARSITY_PATTERN const&) - { } + void operator()(MATRIX& /*unused*/, SPARSITY_PATTERN const& /*unused*/) {} }; /// Sets the sparsity pattern of the underlying matrix. diff --git a/MeshLib/Elements/HexRule8.h b/MeshLib/Elements/HexRule8.h index ebf9de650b24903ebb3cc926a49ba0981e5a5df3..001a1476d9d9b0f97395dc285cbbf1f3f4d609f7 100644 --- a/MeshLib/Elements/HexRule8.h +++ b/MeshLib/Elements/HexRule8.h @@ -91,7 +91,7 @@ public: static ElementErrorCode validate(const Element* e); /// Returns the ID of a face given an array of nodes. - static unsigned identifyFace(Node const* const*, Node* nodes[3]); + static unsigned identifyFace(Node const* const* /*_nodes*/, Node* nodes[3]); /// Calculates the volume of a convex hexahedron by partitioning it into six tetrahedra. static double computeVolume(Node const* const* _nodes); diff --git a/MeshLib/Elements/LineRule2.h b/MeshLib/Elements/LineRule2.h index d5576eaf76b1b2bb91272f355c42e8690fb151ff..f671d75551778553a021cb10c68b2da030f756fe 100644 --- a/MeshLib/Elements/LineRule2.h +++ b/MeshLib/Elements/LineRule2.h @@ -60,7 +60,7 @@ public: static ElementErrorCode validate(const Element* e); /// Returns the ID of a face given an array of nodes. - static unsigned identifyFace(Node const* const*, Node* nodes[1]); + static unsigned identifyFace(Node const* const* /*_nodes*/, Node* nodes[1]); /// Calculates the length of a line static double computeVolume(Node const* const* _nodes); diff --git a/MeshLib/Elements/PointRule1.h b/MeshLib/Elements/PointRule1.h index 6f4713efcc13c89f45b12dfadf87d0ae2a2738d3..386da78e813487e96b11dfef504c634d3c59925b 100644 --- a/MeshLib/Elements/PointRule1.h +++ b/MeshLib/Elements/PointRule1.h @@ -55,7 +55,7 @@ public: static ElementErrorCode validate(const Element* e); /// Returns the ID of a face given an array of nodes. - static unsigned identifyFace(Node const* const*, Node* nodes[1]); + static unsigned identifyFace(Node const* const* /*_nodes*/, Node* nodes[1]); /// Calculates the length of a line static double computeVolume(Node const* const* _nodes); diff --git a/MeshLib/Elements/PrismRule6.h b/MeshLib/Elements/PrismRule6.h index 5e93fa003f4dc93dc8b81e45133174f129dcc34b..0682a5d5e28f7113f4014813d835a37bc1f62ee7 100644 --- a/MeshLib/Elements/PrismRule6.h +++ b/MeshLib/Elements/PrismRule6.h @@ -92,7 +92,7 @@ public: static ElementErrorCode validate(const Element* e); /// Returns the ID of a face given an array of nodes. - static unsigned identifyFace(Node const* const*, Node* nodes[3]); + static unsigned identifyFace(Node const* const* /*_nodes*/, Node* nodes[3]); /// Calculates the volume of a convex hexahedron by partitioning it into six tetrahedra. static double computeVolume(Node const* const* _nodes); diff --git a/MeshLib/Elements/PyramidRule5.h b/MeshLib/Elements/PyramidRule5.h index bdf2c0f941208718113c8e437785e0ada0d9857a..c40dd3d96bc2eabb80e5c2a836c7c18b1afdf6a8 100644 --- a/MeshLib/Elements/PyramidRule5.h +++ b/MeshLib/Elements/PyramidRule5.h @@ -91,7 +91,7 @@ public: static ElementErrorCode validate(const Element* e); /// Returns the ID of a face given an array of nodes. - static unsigned identifyFace(Node const* const*, Node* nodes[3]); + static unsigned identifyFace(Node const* const* /*_nodes*/, Node* nodes[3]); /// Calculates the volume of a convex hexahedron by partitioning it into six tetrahedra. static double computeVolume(Node const* const* _nodes); diff --git a/MeshLib/Elements/QuadRule4.h b/MeshLib/Elements/QuadRule4.h index 8a78c7a62ab8e0a6bfd21b912ca8c65958c36cc9..eb10d5df9f91ca9793b2781720baa3655920897d 100644 --- a/MeshLib/Elements/QuadRule4.h +++ b/MeshLib/Elements/QuadRule4.h @@ -73,7 +73,7 @@ public: static ElementErrorCode validate(const Element* e); /// Returns the ID of a face given an array of nodes. - static unsigned identifyFace(Node const* const*, Node* nodes[3]); + static unsigned identifyFace(Node const* const* /*_nodes*/, Node* nodes[3]); /// Calculates the volume of a convex hexahedron by partitioning it into six tetrahedra. static double computeVolume(Node const* const* _nodes); diff --git a/MeshLib/Elements/TetRule4.h b/MeshLib/Elements/TetRule4.h index 76ac9ac5930eedc03df275885900219b537b79ac..de46bf4ec99ad278b097bb78e53c2e275e8fdd16 100644 --- a/MeshLib/Elements/TetRule4.h +++ b/MeshLib/Elements/TetRule4.h @@ -86,7 +86,7 @@ public: static ElementErrorCode validate(const Element* e); /// Returns the ID of a face given an array of nodes. - static unsigned identifyFace(Node const* const*, Node* nodes[3]); + static unsigned identifyFace(Node const* const* /*_nodes*/, Node* nodes[3]); /// Calculates the volume of the element static double computeVolume(Node const* const* _nodes); diff --git a/MeshLib/Elements/TriRule3.h b/MeshLib/Elements/TriRule3.h index 67178beb3acb9d4da378fcf7e9da93b44d0686b1..56f000799292f13a724177ef5f338e43b29b4651 100644 --- a/MeshLib/Elements/TriRule3.h +++ b/MeshLib/Elements/TriRule3.h @@ -74,7 +74,7 @@ public: static ElementErrorCode validate(const Element* e); /// Returns the ID of a face given an array of nodes. - static unsigned identifyFace(Node const* const*, Node* nodes[3]); + static unsigned identifyFace(Node const* const* /*_nodes*/, Node* nodes[3]); /// Calculates the volume of a convex hexahedron by partitioning it into six tetrahedra. static double computeVolume(Node const* const* _nodes); diff --git a/MeshLib/Properties.h b/MeshLib/Properties.h index 7eb20426a596b311f6412f5c4e03320246b53432..efb465ad3b3df4068335c1ab6357949c1b04ffbc 100644 --- a/MeshLib/Properties.h +++ b/MeshLib/Properties.h @@ -116,7 +116,7 @@ public: template <typename T> PropertyVector<T>* getPropertyVector(std::string const& name, MeshItemType const item_type, - int const number_of_components); + int const n_components); void removePropertyVector(std::string const& name); diff --git a/MeshLib/Vtk/VtkMappedMeshSource.h b/MeshLib/Vtk/VtkMappedMeshSource.h index 05e04784cfcd157f51efcb12dddcec39416cf2a7..613d8577037e7efc328e1ec463aa2d6c4322e439 100644 --- a/MeshLib/Vtk/VtkMappedMeshSource.h +++ b/MeshLib/Vtk/VtkMappedMeshSource.h @@ -67,10 +67,12 @@ protected: int ProcessRequest(vtkInformation* request, vtkInformationVector** inputVector, vtkInformationVector* outputVector) override; - int RequestData(vtkInformation*, vtkInformationVector**, - vtkInformationVector*) override; - int RequestInformation(vtkInformation*, vtkInformationVector**, - vtkInformationVector*) override; + int RequestData(vtkInformation* /*request*/, + vtkInformationVector** /*inputVector*/, + vtkInformationVector* /*outputVector*/) override; + int RequestInformation(vtkInformation* /*request*/, + vtkInformationVector** /*inputVector*/, + vtkInformationVector* /*outputVector*/) override; private: /// Adds a zero-copy vtk array wrapper. diff --git a/MeshLib/Vtk/VtkMeshNodalCoordinatesTemplate-impl.h b/MeshLib/Vtk/VtkMeshNodalCoordinatesTemplate-impl.h index 39a659db6eda51c3bf607c17b788141e43d3baba..791a3c74c67efabb2f3271b76032dc0d66b91430 100644 --- a/MeshLib/Vtk/VtkMeshNodalCoordinatesTemplate-impl.h +++ b/MeshLib/Vtk/VtkMeshNodalCoordinatesTemplate-impl.h @@ -201,99 +201,113 @@ template <class Scalar> Scalar& VtkMeshNodalCoordinatesTemplate<Scalar> return (*(*this->_nodes)[tuple])[comp]; } -template <class Scalar> int VtkMeshNodalCoordinatesTemplate<Scalar> -::Allocate(vtkIdType, vtkIdType) +template <class Scalar> +int VtkMeshNodalCoordinatesTemplate<Scalar>::Allocate(vtkIdType /*unused*/, + vtkIdType /*unused*/) { vtkErrorMacro("Read only container."); return 0; } -template <class Scalar> int VtkMeshNodalCoordinatesTemplate<Scalar> -::Resize(vtkIdType) +template <class Scalar> +int VtkMeshNodalCoordinatesTemplate<Scalar>::Resize(vtkIdType /*unused*/) { vtkErrorMacro("Read only container."); return 0; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::SetNumberOfTuples(vtkIdType) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::SetNumberOfTuples( + vtkIdType /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::SetTuple(vtkIdType, vtkIdType, vtkAbstractArray *) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::SetTuple( + vtkIdType /*unused*/, vtkIdType /*unused*/, vtkAbstractArray* /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::SetTuple(vtkIdType, const float *) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::SetTuple(vtkIdType /*unused*/, + const float* /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::SetTuple(vtkIdType, const double *) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::SetTuple(vtkIdType /*unused*/, + const double* /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::InsertTuple(vtkIdType, vtkIdType, vtkAbstractArray *) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::InsertTuple( + vtkIdType /*unused*/, vtkIdType /*unused*/, vtkAbstractArray* /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::InsertTuple(vtkIdType, const float *) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::InsertTuple( + vtkIdType /*unused*/, const float* /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::InsertTuple(vtkIdType, const double *) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::InsertTuple( + vtkIdType /*unused*/, const double* /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::InsertTuples(vtkIdList *, vtkIdList *, vtkAbstractArray *) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::InsertTuples( + vtkIdList* /*unused*/, vtkIdList* /*unused*/, vtkAbstractArray* /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::InsertTuples(vtkIdType, vtkIdType, vtkIdType, vtkAbstractArray*) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::InsertTuples( + vtkIdType /*unused*/, vtkIdType /*unused*/, vtkIdType /*unused*/, + vtkAbstractArray* /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> vtkIdType VtkMeshNodalCoordinatesTemplate<Scalar> -::InsertNextTuple(vtkIdType, vtkAbstractArray *) +template <class Scalar> +vtkIdType VtkMeshNodalCoordinatesTemplate<Scalar>::InsertNextTuple( + vtkIdType /*unused*/, vtkAbstractArray* /*unused*/) { vtkErrorMacro("Read only container."); return -1; } -template <class Scalar> vtkIdType VtkMeshNodalCoordinatesTemplate<Scalar> -::InsertNextTuple(const float *) +template <class Scalar> +vtkIdType VtkMeshNodalCoordinatesTemplate<Scalar>::InsertNextTuple( + const float* /*unused*/) { vtkErrorMacro("Read only container."); return -1; } -template <class Scalar> vtkIdType VtkMeshNodalCoordinatesTemplate<Scalar> -::InsertNextTuple(const double *) +template <class Scalar> +vtkIdType VtkMeshNodalCoordinatesTemplate<Scalar>::InsertNextTuple( + const double* /*unused*/) { vtkErrorMacro("Read only container."); return -1; @@ -305,44 +319,49 @@ template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> vtkErrorMacro("Read only container."); } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::DeepCopy(vtkAbstractArray *) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::DeepCopy( + vtkAbstractArray* /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::DeepCopy(vtkDataArray *) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::DeepCopy(vtkDataArray* /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::InterpolateTuple(vtkIdType, vtkIdList *, vtkAbstractArray *, double *) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::InterpolateTuple( + vtkIdType /*unused*/, vtkIdList* /*unused*/, vtkAbstractArray* /*unused*/, + double* /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::InterpolateTuple(vtkIdType, vtkIdType, vtkAbstractArray*, vtkIdType, - vtkAbstractArray*, double) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::InterpolateTuple( + vtkIdType /*unused*/, vtkIdType /*unused*/, vtkAbstractArray* /*unused*/, + vtkIdType /*unused*/, vtkAbstractArray* /*unused*/, double /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::SetVariantValue(vtkIdType, vtkVariant) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::SetVariantValue( + vtkIdType /*unused*/, vtkVariant /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::RemoveTuple(vtkIdType) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::RemoveTuple(vtkIdType /*unused*/) { vtkErrorMacro("Read only container."); return; @@ -362,22 +381,25 @@ template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::SetValue(vtkIdType, Scalar) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::SetValue(vtkIdType /*unused*/, + Scalar /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> vtkIdType VtkMeshNodalCoordinatesTemplate<Scalar> -::InsertNextValue(Scalar) +template <class Scalar> +vtkIdType VtkMeshNodalCoordinatesTemplate<Scalar>::InsertNextValue( + Scalar /*unused*/) { vtkErrorMacro("Read only container."); return -1; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::InsertValue(vtkIdType, Scalar) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::InsertValue(vtkIdType /*unused*/, + Scalar /*unused*/) { vtkErrorMacro("Read only container."); return; @@ -430,22 +452,25 @@ template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> tuple[2] = (*(*this->_nodes)[tupleId])[2]; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::SetTypedTuple(vtkIdType, const Scalar*) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::SetTypedTuple( + vtkIdType /*unused*/, const Scalar* /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> void VtkMeshNodalCoordinatesTemplate<Scalar> -::InsertTypedTuple(vtkIdType, const Scalar*) +template <class Scalar> +void VtkMeshNodalCoordinatesTemplate<Scalar>::InsertTypedTuple( + vtkIdType /*unused*/, const Scalar* /*unused*/) { vtkErrorMacro("Read only container."); return; } -template <class Scalar> vtkIdType VtkMeshNodalCoordinatesTemplate<Scalar> -::InsertNextTypedTuple(const Scalar *) +template <class Scalar> +vtkIdType VtkMeshNodalCoordinatesTemplate<Scalar>::InsertNextTypedTuple( + const Scalar* /*unused*/) { vtkErrorMacro("Read only container."); return -1; diff --git a/MeshLib/Vtk/VtkMeshNodalCoordinatesTemplate.h b/MeshLib/Vtk/VtkMeshNodalCoordinatesTemplate.h index 45d0eb6ba298e9ace2e31454f5de342db89c990a..cc5e9bc6856c856e4b2c2014c40f9fd9da91ce32 100644 --- a/MeshLib/Vtk/VtkMeshNodalCoordinatesTemplate.h +++ b/MeshLib/Vtk/VtkMeshNodalCoordinatesTemplate.h @@ -81,7 +81,9 @@ public: void InsertTuple(vtkIdType i, const double *source) override; void InsertTuples(vtkIdList *dstIds, vtkIdList *srcIds, vtkAbstractArray *source) override; - void InsertTuples(vtkIdType, vtkIdType, vtkIdType, vtkAbstractArray*) override; + void InsertTuples(vtkIdType /*unused*/, vtkIdType /*unused*/, + vtkIdType /*unused*/, + vtkAbstractArray* /*unused*/) override; vtkIdType InsertNextTuple(vtkIdType j, vtkAbstractArray *source) override; vtkIdType InsertNextTuple(const float *source) override; vtkIdType InsertNextTuple(const double *source) override; @@ -103,7 +105,7 @@ public: #if !(VTK_MAJOR_VERSION < 7 || VTK_MAJOR_VERSION == 7 && VTK_MINOR_VERSION < 1) Scalar& GetValueReference(vtkIdType idx) const; Scalar GetValue(vtkIdType idx) const override; - void GetTypedTuple(vtkIdType idx, Scalar* t) const override; + void GetTypedTuple(vtkIdType tupleId, Scalar* t) const override; void SetTypedTuple(vtkIdType i, const Scalar* t) override; void InsertTypedTuple(vtkIdType i, const Scalar* t) override; vtkIdType InsertNextTypedTuple(const Scalar* t) override; diff --git a/NumLib/DOF/LocalToGlobalIndexMap.h b/NumLib/DOF/LocalToGlobalIndexMap.h index 50d3602016b54becf33cd7eb16b3aee4dc4a08b2..6795460a08037b3c411c5f6bcca28c3039582568 100644 --- a/NumLib/DOF/LocalToGlobalIndexMap.h +++ b/NumLib/DOF/LocalToGlobalIndexMap.h @@ -174,7 +174,8 @@ public: std::vector<int> const& global_component_ids, std::vector<int> const& variable_component_offsets, std::vector<MeshLib::Element*> const& elements, - NumLib::MeshComponentMap&& mesh_component_map, ConstructorTag); + NumLib::MeshComponentMap&& mesh_component_map, + ConstructorTag /*unused*/); private: template <typename ElementIterator> diff --git a/NumLib/Fem/CoordinatesMapping/ShapeMatrices-impl.h b/NumLib/Fem/CoordinatesMapping/ShapeMatrices-impl.h index e3ef9f6eb83e79a0ea15d7b6b5cef1e439a058d6..e6c8810d219ec3387a12636c23d91b9eea2a34db 100644 --- a/NumLib/Fem/CoordinatesMapping/ShapeMatrices-impl.h +++ b/NumLib/Fem/CoordinatesMapping/ShapeMatrices-impl.h @@ -50,19 +50,22 @@ void setVectorZero(T &vec) template <ShapeMatrixType FIELD_TYPE> struct ShapeDataFieldType {}; template <class T_N, class T_DNDR, class T_J, class T_DNDX> -inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX> &shape, ShapeDataFieldType<ShapeMatrixType::N>) +inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX>& shape, + ShapeDataFieldType<ShapeMatrixType::N> /*unused*/) { setVectorZero(shape.N); } template <class T_N, class T_DNDR, class T_J, class T_DNDX> -inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX> &shape, ShapeDataFieldType<ShapeMatrixType::DNDR>) +inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX>& shape, + ShapeDataFieldType<ShapeMatrixType::DNDR> /*unused*/) { setMatrixZero(shape.dNdr); } template <class T_N, class T_DNDR, class T_J, class T_DNDX> -inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX> &shape, ShapeDataFieldType<ShapeMatrixType::DNDR_J>) +inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX>& shape, + ShapeDataFieldType<ShapeMatrixType::DNDR_J> /*unused*/) { setZero(shape, ShapeDataFieldType<ShapeMatrixType::DNDR>()); setMatrixZero(shape.J); @@ -71,14 +74,16 @@ inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX> &shape, ShapeDataFie } template <class T_N, class T_DNDR, class T_J, class T_DNDX> -inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX> &shape, ShapeDataFieldType<ShapeMatrixType::N_J>) +inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX>& shape, + ShapeDataFieldType<ShapeMatrixType::N_J> /*unused*/) { setZero(shape, ShapeDataFieldType<ShapeMatrixType::N>()); setZero(shape, ShapeDataFieldType<ShapeMatrixType::DNDR_J>()); } template <class T_N, class T_DNDR, class T_J, class T_DNDX> -inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX> &shape, ShapeDataFieldType<ShapeMatrixType::DNDX>) +inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX>& shape, + ShapeDataFieldType<ShapeMatrixType::DNDX> /*unused*/) { setZero(shape, ShapeDataFieldType<ShapeMatrixType::DNDR_J>()); setMatrixZero(shape.invJ); @@ -86,7 +91,8 @@ inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX> &shape, ShapeDataFie } template <class T_N, class T_DNDR, class T_J, class T_DNDX> -inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX> &shape, ShapeDataFieldType<ShapeMatrixType::ALL>) +inline void setZero(ShapeMatrices<T_N, T_DNDR, T_J, T_DNDX>& shape, + ShapeDataFieldType<ShapeMatrixType::ALL> /*unused*/) { setZero(shape, ShapeDataFieldType<ShapeMatrixType::N>()); setZero(shape, ShapeDataFieldType<ShapeMatrixType::DNDX>()); diff --git a/NumLib/Fem/ShapeFunction/ShapePrism15.h b/NumLib/Fem/ShapeFunction/ShapePrism15.h index 26dab800d4bb7e728a146c231b6d5c26adc14882..1fc4f8abe69255368b7de16a9eedf601714fbc89 100644 --- a/NumLib/Fem/ShapeFunction/ShapePrism15.h +++ b/NumLib/Fem/ShapeFunction/ShapePrism15.h @@ -28,7 +28,7 @@ public: * @param [out] N a vector of calculated shape functions */ template <class T_X, class T_N> - static void computeShapeFunction(const T_X &r, T_N &N); + static void computeShapeFunction(const T_X& x, T_N& N); /** * Evaluate derivatives of the shape function at the given point @@ -37,7 +37,7 @@ public: * @param [out] dN a matrix of the derivatives */ template <class T_X, class T_N> - static void computeGradShapeFunction(const T_X &r, T_N &dN); + static void computeGradShapeFunction(const T_X& x, T_N& dN); using MeshElement = MeshLib::Prism15; static const unsigned DIM = MeshElement::dimension; diff --git a/NumLib/Fem/ShapeFunction/ShapePrism6.h b/NumLib/Fem/ShapeFunction/ShapePrism6.h index 12dd8456be5b1d9ac83b7f883ce7143f0ef8974a..fd392232aed793f51969a8706884e960c4c30a5e 100644 --- a/NumLib/Fem/ShapeFunction/ShapePrism6.h +++ b/NumLib/Fem/ShapeFunction/ShapePrism6.h @@ -28,7 +28,7 @@ public: * @param [out] N a vector of calculated shape functions */ template <class T_X, class T_N> - static void computeShapeFunction(const T_X &r, T_N &N); + static void computeShapeFunction(const T_X& x, T_N& N); /** * Evaluate derivatives of the shape function at the given point @@ -37,7 +37,7 @@ public: * @param [out] dN a matrix of the derivatives */ template <class T_X, class T_N> - static void computeGradShapeFunction(const T_X &r, T_N &dN); + static void computeGradShapeFunction(const T_X& x, T_N& dN); using MeshElement = MeshLib::Prism; static const unsigned DIM = MeshElement::dimension; diff --git a/NumLib/Fem/ShapeFunction/ShapePyra13.h b/NumLib/Fem/ShapeFunction/ShapePyra13.h index d66f49fac800488a1e7e81d3baa32771b9f3bbd2..8c7446fd7a740a0158fcb0ba3d3a54ac52287b1a 100644 --- a/NumLib/Fem/ShapeFunction/ShapePyra13.h +++ b/NumLib/Fem/ShapeFunction/ShapePyra13.h @@ -28,7 +28,7 @@ public: * @param [out] N a vector of calculated shape functions */ template <class T_X, class T_N> - static void computeShapeFunction(const T_X &r, T_N &N); + static void computeShapeFunction(const T_X& x, T_N& N); /** * Evaluate derivatives of the shape function at the given point @@ -37,7 +37,7 @@ public: * @param [out] dN a matrix of the derivatives */ template <class T_X, class T_N> - static void computeGradShapeFunction(const T_X &r, T_N &dN); + static void computeGradShapeFunction(const T_X& x, T_N& dN); using MeshElement = MeshLib::Pyramid13; static const unsigned DIM = MeshElement::dimension; diff --git a/NumLib/Fem/ShapeFunction/ShapePyra5.h b/NumLib/Fem/ShapeFunction/ShapePyra5.h index 2bd1fd5a52566efbd0fe70d383bc5908f646df1c..50d56e71161b8b3fc9c876f34e7afeb7a893ba2c 100644 --- a/NumLib/Fem/ShapeFunction/ShapePyra5.h +++ b/NumLib/Fem/ShapeFunction/ShapePyra5.h @@ -28,7 +28,7 @@ public: * @param [out] N a vector of calculated shape functions */ template <class T_X, class T_N> - static void computeShapeFunction(const T_X &r, T_N &N); + static void computeShapeFunction(const T_X& x, T_N& N); /** * Evaluate derivatives of the shape function at the given point @@ -37,7 +37,7 @@ public: * @param [out] dN a matrix of the derivatives */ template <class T_X, class T_N> - static void computeGradShapeFunction(const T_X &r, T_N &dN); + static void computeGradShapeFunction(const T_X& x, T_N& dN); using MeshElement = MeshLib::Pyramid; static const unsigned DIM = MeshElement::dimension; diff --git a/NumLib/NamedFunction.h b/NumLib/NamedFunction.h index 80100218dfff3a601133f700b728ed6d8a96cd07..d415bc8f66bc65e05da50c30191ed90832834c3c 100644 --- a/NumLib/NamedFunction.h +++ b/NumLib/NamedFunction.h @@ -63,7 +63,7 @@ public: std::function<ReturnType(Arguments...)>&& function); NamedFunction(NamedFunction&& other); - NamedFunction(NamedFunction const&); + NamedFunction(NamedFunction const& other); ~NamedFunction(); diff --git a/NumLib/NamedFunctionCaller.h b/NumLib/NamedFunctionCaller.h index 365b1907a373a68141597ec30e994d4fc7f4d9c3..6c98637c2bf377cfd9cb44f338579d0cf6f14535 100644 --- a/NumLib/NamedFunctionCaller.h +++ b/NumLib/NamedFunctionCaller.h @@ -22,7 +22,7 @@ class NamedFunctionCaller final { public: //! Constructs an instance whose unbound arguments have the given names. - explicit NamedFunctionCaller( + NamedFunctionCaller( std::initializer_list<std::string> unbound_argument_names); //! Adds the given named function diff --git a/NumLib/ODESolver/TimeDiscretization.h b/NumLib/ODESolver/TimeDiscretization.h index 8bf113f9281e9d12190a3a79aca44acd170ae53f..9694ad7749375ffe34e201ba232d841ade678682 100644 --- a/NumLib/ODESolver/TimeDiscretization.h +++ b/NumLib/ODESolver/TimeDiscretization.h @@ -269,7 +269,7 @@ public: GlobalVector const& x, MathLib::VecNormType norm_type) override; void pushState(const double /*t*/, GlobalVector const& x, - InternalMatrixStorage const&) override + InternalMatrixStorage const& /*strg*/) override { MathLib::LinAlg::copy(x, _x_old); } @@ -327,7 +327,7 @@ public: GlobalVector const& x, MathLib::VecNormType norm_type) override; void pushState(const double /*t*/, GlobalVector const& x, - InternalMatrixStorage const&) override + InternalMatrixStorage const& /*strg*/) override { MathLib::LinAlg::copy(x, _x_old); } @@ -411,7 +411,7 @@ public: double getRelativeChangeFromPreviousTimestep( GlobalVector const& x, MathLib::VecNormType norm_type) override; - void pushState(const double, GlobalVector const& x, + void pushState(const double /*t*/, GlobalVector const& x, InternalMatrixStorage const& strg) override { MathLib::LinAlg::copy(x, _x_old); @@ -494,8 +494,8 @@ public: double getRelativeChangeFromPreviousTimestep( GlobalVector const& x, MathLib::VecNormType norm_type) override; - void pushState(const double, GlobalVector const& x, - InternalMatrixStorage const&) override; + void pushState(const double /*t*/, GlobalVector const& x, + InternalMatrixStorage const& /*strg*/) override; void popState(GlobalVector& x) override { diff --git a/ParameterLib/GroupBasedParameter.h b/ParameterLib/GroupBasedParameter.h index 71d9d979cdfcba3fa5d18f21c107f9771e5059ae..f0064d1e96ad05458b49e8882dd15b9f4de4e4cc 100644 --- a/ParameterLib/GroupBasedParameter.h +++ b/ParameterLib/GroupBasedParameter.h @@ -84,13 +84,15 @@ private: }; static boost::optional<std::size_t> getMeshItemID( - SpatialPosition const& pos, type<MeshLib::MeshItemType::Cell>) + SpatialPosition const& pos, + type<MeshLib::MeshItemType::Cell> /*unused*/) { return pos.getElementID(); } static boost::optional<std::size_t> getMeshItemID( - SpatialPosition const& pos, type<MeshLib::MeshItemType::Node>) + SpatialPosition const& pos, + type<MeshLib::MeshItemType::Node> /*unused*/) { return pos.getNodeID(); } diff --git a/ProcessLib/HydroMechanics/LocalDataInitializer.h b/ProcessLib/HydroMechanics/LocalDataInitializer.h index 123de39a53c53672309c6e72ce3bcf00cb2619ac..0c32fd94ae01102b60465655b81b8038e95ec12d 100644 --- a/ProcessLib/HydroMechanics/LocalDataInitializer.h +++ b/ProcessLib/HydroMechanics/LocalDataInitializer.h @@ -255,7 +255,7 @@ private: /// 1), /// (Line2, 2), (Line2, 3), (Hex20, 3) but not (Hex20, 2) or (Hex20, 1). template <typename ShapeFunctionDisplacement> - static LADataBuilder makeLocalAssemblerBuilder(std::true_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::true_type* /*unused*/) { // (Lower order elements = Order(ShapeFunctionDisplacement) - 1). using ShapeFunctionPressure = @@ -273,7 +273,7 @@ private: /// Returns nullptr for shape functions whose dimensions are less than the /// global dimension. template <typename ShapeFunctionDisplacement> - static LADataBuilder makeLocalAssemblerBuilder(std::false_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::false_type* /*unused*/) { return nullptr; } diff --git a/ProcessLib/LIE/HydroMechanics/LocalAssembler/HydroMechanicsLocalAssemblerMatrixNearFracture.h b/ProcessLib/LIE/HydroMechanics/LocalAssembler/HydroMechanicsLocalAssemblerMatrixNearFracture.h index be07a6d3fbd7eb0179d5fcda6fcc9c08b4aed364..c44c76d63e2b2c4d56302eeb7789d8b3dbfb213b 100644 --- a/ProcessLib/LIE/HydroMechanics/LocalAssembler/HydroMechanicsLocalAssemblerMatrixNearFracture.h +++ b/ProcessLib/LIE/HydroMechanics/LocalAssembler/HydroMechanicsLocalAssemblerMatrixNearFracture.h @@ -55,8 +55,8 @@ public: private: void assembleWithJacobianConcrete(double const t, - Eigen::VectorXd const& local_u, - Eigen::VectorXd const& local_udot, + Eigen::VectorXd const& local_x, + Eigen::VectorXd const& local_x_dot, Eigen::VectorXd& local_b, Eigen::MatrixXd& local_J) override; diff --git a/ProcessLib/LIE/HydroMechanics/LocalAssembler/LocalDataInitializer.h b/ProcessLib/LIE/HydroMechanics/LocalAssembler/LocalDataInitializer.h index 106070878f6268c7ea04438965eb7046b365a46d..ed9fa66adf58090a742a92c1ebeb1da700adbae5 100644 --- a/ProcessLib/LIE/HydroMechanics/LocalAssembler/LocalDataInitializer.h +++ b/ProcessLib/LIE/HydroMechanics/LocalAssembler/LocalDataInitializer.h @@ -339,7 +339,7 @@ private: /// 1), /// (Line2, 2), (Line2, 3), (Hex20, 3) but not (Hex20, 2) or (Hex20, 1). template <typename ShapeFunctionDisplacement> - static LADataBuilder makeLocalAssemblerBuilder(std::true_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::true_type* /*unused*/) { // (Lower order elements = Order(ShapeFunctionDisplacement) - 1). using ShapeFunctionPressure = @@ -375,7 +375,7 @@ private: /// Returns nullptr for shape functions whose dimensions are less than the /// global dimension. template <typename ShapeFunctionDisplacement> - static LADataBuilder makeLocalAssemblerBuilder(std::false_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::false_type* /*unused*/) { return nullptr; } diff --git a/ProcessLib/LIE/SmallDeformation/LocalAssembler/LocalDataInitializer.h b/ProcessLib/LIE/SmallDeformation/LocalAssembler/LocalDataInitializer.h index bd64e20df2292132f892a9ba2b23005092eff400..f02a619189c34e45db88d90bf062236524683181 100644 --- a/ProcessLib/LIE/SmallDeformation/LocalAssembler/LocalDataInitializer.h +++ b/ProcessLib/LIE/SmallDeformation/LocalAssembler/LocalDataInitializer.h @@ -343,7 +343,7 @@ private: /// combinations of shape functions and global dimensions: (Line2, 1), /// (Line2, 2), (Line2, 3), (Hex20, 3) but not (Hex20, 2) or (Hex20, 1). template <typename ShapeFunction> - static LADataBuilder makeLocalAssemblerBuilder(std::true_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::true_type* /*unused*/) { return [](MeshLib::Element const& e, std::size_t const n_variables, @@ -374,7 +374,7 @@ private: /// Returns nullptr for shape functions whose dimensions are less than the /// global dimension. template <typename ShapeFunction> - static LADataBuilder makeLocalAssemblerBuilder(std::false_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::false_type* /*unused*/) { return nullptr; } diff --git a/ProcessLib/LIE/SmallDeformation/LocalAssembler/SmallDeformationLocalAssemblerFracture.h b/ProcessLib/LIE/SmallDeformation/LocalAssembler/SmallDeformationLocalAssemblerFracture.h index 9174300f014a4dc0f9345bea63c20dab6b092a38..8df89c26179775fc76da200ec4b9867de6aa317e 100644 --- a/ProcessLib/LIE/SmallDeformation/LocalAssembler/SmallDeformationLocalAssemblerFracture.h +++ b/ProcessLib/LIE/SmallDeformation/LocalAssembler/SmallDeformationLocalAssemblerFracture.h @@ -92,7 +92,7 @@ public: } void computeSecondaryVariableConcreteWithVector( - const double t, Eigen::VectorXd const& local_x) override; + const double t, Eigen::VectorXd const& local_u) override; Eigen::Map<const Eigen::RowVectorXd> getShapeMatrix( const unsigned integration_point) const override diff --git a/ProcessLib/ProcessVariable.h b/ProcessLib/ProcessVariable.h index 30b374aa60b0152d5c95e30ab4fcaa0c4787ec84..23838df06f432f8abdafe25611b57b46611dbf5b 100644 --- a/ProcessLib/ProcessVariable.h +++ b/ProcessLib/ProcessVariable.h @@ -51,7 +51,7 @@ public: std::vector<std::unique_ptr<ParameterLib::ParameterBase>> const& parameters); - ProcessVariable(ProcessVariable&&); + ProcessVariable(ProcessVariable&& other); std::string const& getName() const; diff --git a/ProcessLib/RichardsMechanics/LocalDataInitializer.h b/ProcessLib/RichardsMechanics/LocalDataInitializer.h index b6a4eb63db8b809d70a36e6d28a5804631c13c97..8f3dafe35a446c5afc7cc4b9d3b3220fc7f7d967 100644 --- a/ProcessLib/RichardsMechanics/LocalDataInitializer.h +++ b/ProcessLib/RichardsMechanics/LocalDataInitializer.h @@ -255,7 +255,7 @@ private: /// 1), /// (Line2, 2), (Line2, 3), (Hex20, 3) but not (Hex20, 2) or (Hex20, 1). template <typename ShapeFunctionDisplacement> - static LADataBuilder makeLocalAssemblerBuilder(std::true_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::true_type* /*unused*/) { // (Lower order elements = Order(ShapeFunctionDisplacement) - 1). using ShapeFunctionPressure = @@ -273,7 +273,7 @@ private: /// Returns nullptr for shape functions whose dimensions are less than the /// global dimension. template <typename ShapeFunctionDisplacement> - static LADataBuilder makeLocalAssemblerBuilder(std::false_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::false_type* /*unused*/) { return nullptr; } diff --git a/ProcessLib/SmallDeformation/LocalDataInitializer.h b/ProcessLib/SmallDeformation/LocalDataInitializer.h index a266324c43e692277a03985249eab736f7afd04e..47ef8894f02b51d3c79183fc559d210a82076742 100644 --- a/ProcessLib/SmallDeformation/LocalDataInitializer.h +++ b/ProcessLib/SmallDeformation/LocalDataInitializer.h @@ -274,7 +274,7 @@ private: /// combinations of shape functions and global dimensions: (Line2, 1), /// (Line2, 2), (Line2, 3), (Hex20, 3) but not (Hex20, 2) or (Hex20, 1). template <typename ShapeFunction> - static LADataBuilder makeLocalAssemblerBuilder(std::true_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::true_type* /*unused*/) { return [](MeshLib::Element const& e, std::size_t const local_matrix_size, @@ -287,7 +287,7 @@ private: /// Returns nullptr for shape functions whose dimensions are less than the /// global dimension. template <typename ShapeFunction> - static LADataBuilder makeLocalAssemblerBuilder(std::false_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::false_type* /*unused*/) { return nullptr; } diff --git a/ProcessLib/TES/TESReactionAdaptor.h b/ProcessLib/TES/TESReactionAdaptor.h index 331c64bea242b21e55aa64cee1cc44d51a3316d0..a2c6a2b51c922f84444c67a2e72987fbd3e0c780 100644 --- a/ProcessLib/TES/TESReactionAdaptor.h +++ b/ProcessLib/TES/TESReactionAdaptor.h @@ -86,7 +86,7 @@ private: class TESFEMReactionAdaptorInert final : public TESFEMReactionAdaptor { public: - explicit TESFEMReactionAdaptorInert(TESLocalAssemblerData const&); + explicit TESFEMReactionAdaptorInert(TESLocalAssemblerData const& /*data*/); ReactionRate initReaction(const unsigned int_pt) override; @@ -99,7 +99,7 @@ class TESFEMReactionAdaptorSinusoidal final : public TESFEMReactionAdaptor public: explicit TESFEMReactionAdaptorSinusoidal(TESLocalAssemblerData const& data); - ReactionRate initReaction(const unsigned) override; + ReactionRate initReaction(const unsigned /*int_pt*/) override; private: TESLocalAssemblerData const& _d; @@ -110,7 +110,7 @@ class TESFEMReactionAdaptorCaOH2 final : public TESFEMReactionAdaptor public: explicit TESFEMReactionAdaptorCaOH2(TESLocalAssemblerData const& data); - ReactionRate initReaction(const unsigned) override; + ReactionRate initReaction(const unsigned /*int_pt*/) override; private: using Data = TESLocalAssemblerData; diff --git a/ProcessLib/ThermoHydroMechanics/LocalDataInitializer.h b/ProcessLib/ThermoHydroMechanics/LocalDataInitializer.h index f8801c2b3315c5c69a4f8719fb7aeb81870c6069..b624e5c15008db4d560ab57a409cf088e2291cad 100644 --- a/ProcessLib/ThermoHydroMechanics/LocalDataInitializer.h +++ b/ProcessLib/ThermoHydroMechanics/LocalDataInitializer.h @@ -254,7 +254,7 @@ private: /// 1), /// (Line2, 2), (Line2, 3), (Hex20, 3) but not (Hex20, 2) or (Hex20, 1). template <typename ShapeFunctionDisplacement> - static LADataBuilder makeLocalAssemblerBuilder(std::true_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::true_type* /*unused*/) { // (Lower order elements = Order(ShapeFunctionDisplacement) - 1). using ShapeFunctionPressure = @@ -272,7 +272,7 @@ private: /// Returns nullptr for shape functions whose dimensions are less than the /// global dimension. template <typename ShapeFunctionDisplacement> - static LADataBuilder makeLocalAssemblerBuilder(std::false_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::false_type* /*unused*/) { return nullptr; } diff --git a/ProcessLib/Utils/LocalDataInitializer.h b/ProcessLib/Utils/LocalDataInitializer.h index e51b329c2c947e99f38df39b71bd3cddf38bd157..f368b986cf8eb1f7ea18911a8eff5e352fdf2e5d 100644 --- a/ProcessLib/Utils/LocalDataInitializer.h +++ b/ProcessLib/Utils/LocalDataInitializer.h @@ -371,7 +371,7 @@ private: /// combinations of shape functions and global dimensions: (Line2, 1), /// (Line2, 2), (Line2, 3), (Hex20, 3) but not (Hex20, 2) or (Hex20, 1). template <typename ShapeFunction> - static LADataBuilder makeLocalAssemblerBuilder(std::true_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::true_type* /*unused*/) { return [](MeshLib::Element const& e, std::size_t const local_matrix_size, @@ -384,7 +384,7 @@ private: /// Returns nullptr for shape functions whose dimensions are less than the /// global dimension. template <typename ShapeFunction> - static LADataBuilder makeLocalAssemblerBuilder(std::false_type*) + static LADataBuilder makeLocalAssemblerBuilder(std::false_type* /*unused*/) { return nullptr; } diff --git a/ProcessLib/VariableTransformation.h b/ProcessLib/VariableTransformation.h index 2f00a1d20f9985f1474a20a513cf46a871bfeb83..5162e027dc949f7ef34eb91837569038dbc58cc1 100644 --- a/ProcessLib/VariableTransformation.h +++ b/ProcessLib/VariableTransformation.h @@ -65,7 +65,7 @@ struct TrafoTanh struct TrafoScale { - TrafoScale(const double factor) : _factor{factor} {} + explicit TrafoScale(const double factor) : _factor{factor} {} static const bool constrained = false; diff --git a/Tests/AutoCheckTools.h b/Tests/AutoCheckTools.h index f28ebd5ab2ddeb8ff754c434591162257e9e3806..03aec6d7fa0c444d9fd52b389675496e612a28a0 100644 --- a/Tests/AutoCheckTools.h +++ b/Tests/AutoCheckTools.h @@ -122,13 +122,10 @@ struct randomCoordinateIndexGenerator Gen source; using result_type = T; - result_type operator()(std::size_t) - { - return source() % DIM; - } + result_type operator()(std::size_t /*unused*/) { return source() % DIM; } }; -inline double absoluteValue(double&& v, std::size_t) +inline double absoluteValue(double&& v, std::size_t /*unused*/) { return std::abs(v); } diff --git a/Tests/InstanceCounter.h b/Tests/InstanceCounter.h index b1fa755a4663b067241ac2093aa137c551d0ac5a..50a22b2473f2dd706c4e134149bb2c7e5a3be3cd 100644 --- a/Tests/InstanceCounter.h +++ b/Tests/InstanceCounter.h @@ -16,12 +16,8 @@ public: InstanceCounter() { ++_num_constructed; } - InstanceCounter(InstanceCounter<T> const&) { - ++_num_copied; - } - InstanceCounter(InstanceCounter<T>&&) { - ++_num_moved; - } + InstanceCounter(InstanceCounter<T> const& /*unused*/) { ++_num_copied; } + InstanceCounter(InstanceCounter<T>&& /*unused*/) { ++_num_moved; } virtual ~InstanceCounter() { ++_num_destroyed; } diff --git a/Tests/NumLib/SteadyDiffusion2DExample1.h b/Tests/NumLib/SteadyDiffusion2DExample1.h index d8f91bc10ed87b0f43055d9a7807c700c825ac7f..b89f4d5d4bf0614d0de5b0a11ab493b56a4cf3f7 100644 --- a/Tests/NumLib/SteadyDiffusion2DExample1.h +++ b/Tests/NumLib/SteadyDiffusion2DExample1.h @@ -31,10 +31,10 @@ template<typename IndexType>struct SteadyDiffusion2DExample1 class LocalAssemblerData { public: - void init(MeshLib::Element const&, - std::size_t const /*local_matrix_size*/, - LocalMatrixType const& localA, - LocalVectorType const& localRhs) + void init(MeshLib::Element const& /*unused*/, + std::size_t const /*local_matrix_size*/, + LocalMatrixType const& localA, + LocalVectorType const& localRhs) { _localA = &localA; _localRhs = &localRhs;