[cmake] Simplify find_package(Threads).

Applications/DataExplorer/DataExplorer.cmake

@@ -34,7 +34,7 @@ target_link_libraries(
     QtDataView
     QtDiagramView
     VtkVis
-    Threads::Threads
+    $<$<TARGET_EXISTS:Threads::Threads>:Threads::Threads>
     Qt5::Core
     Qt5::Gui
     Qt5::Widgets
@@ -86,9 +86,18 @@ if(MSVC)
     # Install qt libraries
     get_target_property(mocExe Qt5::moc IMPORTED_LOCATION)
     get_filename_component(qtBinDir "${mocExe}" DIRECTORY)
-    find_program(DEPLOYQT_EXECUTABLE windeployqt PATHS "${qtBinDir}" NO_DEFAULT_PATH)
-    set(DEPLOY_OPTIONS [[bin/DataExplorer.exe --dir . --libdir bin --plugindir plugins]])
-    configure_file(${PROJECT_SOURCE_DIR}/scripts/cmake/packaging/deployapp.cmake.in deployapp.cmake @ONLY)
+    find_program(
+        DEPLOYQT_EXECUTABLE windeployqt PATHS "${qtBinDir}" NO_DEFAULT_PATH
+    )
+    set(DEPLOY_OPTIONS
+        [[bin/DataExplorer.exe --dir . --libdir bin --plugindir plugins]]
+    )
+    configure_file(
+        ${PROJECT_SOURCE_DIR}/scripts/cmake/packaging/deployapp.cmake.in
+        deployapp.cmake @ONLY
+    )
     install(SCRIPT ${CMAKE_CURRENT_BINARY_DIR}/deployapp.cmake)
-    install(FILES ${PROJECT_SOURCE_DIR}/scripts/cmake/packaging/qt.conf TYPE BIN)
+    install(FILES ${PROJECT_SOURCE_DIR}/scripts/cmake/packaging/qt.conf
+            TYPE BIN
+    )
 endif()

Tests/CMakeLists.txt

@@ -77,7 +77,7 @@ target_link_libraries(
             ProcessLib
             Processes
             TestInfoLib
-            Threads::Threads
+            $<$<TARGET_EXISTS:Threads::Threads>:Threads::Threads>
             ${VTK_LIBRARIES}
             $<$<TARGET_EXISTS:LIE>:LIE>
             $<$<TARGET_EXISTS:TH2M>:TH2M>

scripts/cmake/Find.cmake

@@ -20,9 +20,7 @@ find_program(GPROF_PATH gprof DOC "GNU profiler gprof" QUIET)
 find_program(CPPCHECK_TOOL_PATH cppcheck)
 
 # Find bash itself ...
-find_program(
-    BASH_TOOL_PATH bash HINTS ${GITHUB_BIN_DIR} DOC "The bash executable"
-)
+find_program(BASH_TOOL_PATH bash DOC "The bash executable")
 
 find_program(CCACHE_TOOL_PATH ccache)
 
@@ -46,15 +44,10 @@ find_program(GMSH gmsh)
 # Find libraries
 # ##############################################################################
 if(OGS_USE_MFRONT)
-    # pthread, is a requirement of mfront ##
-    set(CMAKE_THREAD_PREFER_PTHREAD ON)
+    set(CMAKE_REQUIRE_FIND_PACKAGE_Threads TRUE)
     set(THREADS_PREFER_PTHREAD_FLAG ON)
-    find_package(Threads REQUIRED)
-    if(CMAKE_USE_PTHREADS_INIT)
-        set(HAVE_PTHREADS TRUE)
-        add_definitions(-DHAVE_PTHREADS)
-    endif()
 endif()
+find_package(Threads)
 
 find_package(OpenMP)
 if(OPENMP_FOUND)