wenqing authored 4 months ago and Dmitri Naumov committed 3 months ago

and one comment change

wenqing authored 5 months ago and Dmitri Naumov committed 3 months ago

added a warning to use it for creating local vectors.

Norbert Grunwald authored 5 months ago and Dmitri Naumov committed 4 months ago

Although the expression is generally prevented from becoming negative by a conditional, it can still be negative for specific values, which is why the absolute value of the expression is taken.

implementation, normalize A and rhs

add feature in nonlinear solver

Comment out of writing matrices for debugging

Normalize linear equation system only for rectangular shaped A Matrix

add the switch in NonlinearSolver

add feature in matMultTranspose

only when A is not square

deactivate PETSc implementation

add the check function in EquationSystem

add override functions in ODE

add override functions in TimeDiscretizedODESystem

Lars Bilke authored 10 months ago and Dmitri Naumov committed 10 months ago

Also added <cassert>, former code implicitly used an assert() function
from eigen which was recently renamed to eigen_assert().

Lars Bilke authored 10 months ago and Dmitri Naumov committed 10 months ago

- [cmake] Also use MKLs OpenMP implementation for serial configs.
- [cmake] Renamed OGS_USE_PETSC_MKL_EIGEN_OPENMP to OGS_USE_MKL_EIGEN_OPENMP.
- [cmake] Option OGS_EIGEN_PARALLEL_BACKEND replaces other configs.
  Removed:
  - OGS_USE_MKL_EIGEN_OPENMP
  - OGS_EIGEN_USE_MKL
- Also when OGS_USE_MKL=ON then OGS_EIGEN_PARALLEL_BACKEND defaults to
MKL.
- Updated eigen-unsupported version to inlude fix for MKL backend.
  Fix: https://gitlab.com/libeigen/eigen/-/merge_requests/851
- Moved OGS_EIGEN_PARALLEL_BACKEND initialization.
- [cmake] Only link to OpenMP when eigen backend is set to OpenMP.
- [cmake] Eigen includes OpenMP or MKL depending on backend.

Resolves cppcheck warning about missing return statement.

Return types must be auto, s.t. a cwise-nullary-op is returned.