Shuang Chen authored 5 years ago and Dmitry Yu. Naumov committed 5 years ago

Add overriden control, modified data container
Rename the tespy converge control
remove unused bool variable
Passing this bool variable is not needed

Shuang Chen authored 5 years ago and Dmitry Yu. Naumov committed 5 years ago

- add /file  in the top decription
- iostream dropped for not needed
- modified the phrase in the cmake list
- delete the else branch for no need

HBShaoUFZ authored 5 years ago and Dmitry Yu. Naumov committed 5 years ago

Modified the template typename in BHEInflwoPythonBoundaryCondition.h

fixed unused parameter x problem in BHEInflowPythonBoundaryConditoin
adding missing \file

Shuang Chen authored 5 years ago and Dmitry Yu. Naumov committed 5 years ago

Add BHEinflowPythonBoundaryCondition into following places
1) PythonBoundaryCondition
2) Pybind11_Embedded_Module
3) The CMakeList
4) Switch on the compiling flag OGS_USE_PYTHON when pipe network is present
Add OGS_USE_PYTHON option in HeatTransportBHE process cmakelist

Main reason for modification is the getFlux function, which for
particular processes (ComponentTransport) relies on all solutions being
available.
This modification ripples through all of the code, especially through
the boundary conditions.
Modified `applyNaturalBC`, `preTimestep`, `integrate`, and `assemble`
functions.

preTimestep now accepts a vector of solution together with
a process_id.
In postTimestep only the vector of solutions has been changed.

find *Lib -type f | xargs sed -i 'N;s%\(^\/\*\*\)\n \*$%\1%'

Fixes multiple copyright messages in the doxygen docu.

ag '\\file' -L --ignore=ThirdParty *Lib |xargs  sed -i 's/\(.*\)\\copyright/\1\\file\n\1\\copyright/'

Most of the current .clang-tidy contained checks:
google-explicit-constructor
google-readability-braces-around-statements
modernize-loop-convert
modernize-use-default-member-init
modernize-use-emplace
modernize-use-using
readability-braces-around-statements
readability-else-after-return
readability-named-parameter
*readability-namespace-comments
*readability-inconsistent-*
readability-redundant-member-init
readability-simplify-boolean-expr
readability-string-compare
*explicit-conversions*

In cases when the underlying element is quadratic but the shape function
is of linear order, there is a dimension mismatch between the
NodalVectorType and the return value of the getNodalValuesOnElement.

Taking the first rows of the return matrix ensures correct dimensions.

Pass boundary meshes to findParameter().

This prevents a case of a parameter not being defined
on another mesh then the boundary condition.

[PL] Clang format on HCOpenBoundary

[PL] Review on HCOpenBoundary implemented

ParameterLib

parameter renamed

HCOpenBoundary finds element and face ids automatically

HCOpenBoundary -> HCNonAdvectiveFreeVomponentFlowBoundary

Putting them in own HTBHE namespace.

Passing the bhe type to the BCs is not necessary, just a callback.

Also those where the second and so forth arguments are defaulted.

The MathLib::TemplateVector3 is an exception, because of the many
required changes through the code, which relies on the implicit
conversion from TemplatePoint<T, 3> to TemplateVector3<T>.

clang-tidy '*explicit*' check.

These are almost the same and the difference is in the
handling of the shape functions.