Skip to content
Snippets Groups Projects

Fixed compilation errors after spdlog update

Merged Christoph Lehmann requested to merge chleh/ogs:spdlog-update into spdlog-update

The solution is outlined on https://stackoverflow.com/a/68675384.

Merge request reports

Merged by Lars BilkeLars Bilke 2 years ago (Aug 4, 2022 7:46am UTC)

Merge details

  • Changes merged into with 6bbab85a.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • mentioned in merge request ogs/ogs!4227 (merged)

  • added 1 commit

    • e323ad25 - [PL] Fixed format string errors

    Compare with previous version

  • There are still some errors:

    [Start]  surfing_pyvista.ipynb
    figures folder detected, symlink /home/jovyan/work/Tests/Data/PhaseField/surfing_jupyter_notebook/figures to _out/PhaseField/surfing_jupyter_notebook/surfing_pyvista/figures
    [Failed] surfing_pyvista.ipynb in 2.784407 seconds. --> _out/PhaseField/surfing_jupyter_notebook/surfing_pyvista/surfing_pyvista.ipynb.html <--

    The surfing benchmark fails, because of FileNotFoundError: File (/home/jovyan/work/Tests/Data/PhaseField/surfing_jupyter_notebook/surfing_quad_1x2_NR.vtu) not found.

    Is that a known issue?

    And one Linux and the Mac build report warnings, but run fine apart from that:

    /builds/chleh/build/ci-no-unity/_deps/spdlog-src/include/spdlog/fmt/bundled/core.h:2670:41: warning: 'constexpr fmt::v8::detail::arg_mapper<Context>::cstring_result fmt::v8::detail::arg_mapper<Context>::map(const unsigned char*) [with Context = fmt::v8::basic_format_context<fmt::v8::appender, char>; fmt::v8::detail::arg_mapper<Context>::cstring_result = const char*]' is deprecated [-Wdeprecated-declarations]
    /builds/chleh/build/ci-no-unity/_deps/spdlog-src/include/spdlog/fmt/bundled/core.h:2671:41: warning: 'constexpr fmt::v8::detail::arg_mapper<Context>::cstring_result fmt::v8::detail::arg_mapper<Context>::map(const unsigned char*) [with Context = fmt::v8::basic_format_context<fmt::v8::appender, char>; fmt::v8::detail::arg_mapper<Context>::cstring_result = const char*]' is deprecated [-Wdeprecated-declarations]
    ...

    I assume that this is a library internal issue. Can we ignore these warnings for the moment?

  • Lars Bilke mentioned in commit 6bbab85a

    mentioned in commit 6bbab85a

  • merged

Please register or sign in to reply
Loading