Skip to content
Snippets Groups Projects
Commit f359e53e authored by Dmitri Naumov's avatar Dmitri Naumov
Browse files

Squashed code review changes.

[IO] Replace pointer types with std::vector.

[T] Use Logog formatter pointers. Reduce indent.

[MeL] Remove default NodePartitionedMesh dtor definition.

[MeL] Const correctness of NodePartitionedMesh::isGhostNode().

[IO] Remove default NodePartitionedMeshRead definiton.

[IO] Split long lines.

[IO] Correct doxygen comments.

[IO] Correct private _mpi_comm variable name.

[IO] Correct typo in buildNodeStructTypeMPI() fct name.

[IO] Use NodeData reference instead of pointer.

[IO] Add std namespace identifier for std::getline.

[IO] Remove printMessage().

[IO] Remove unused MPI_status, make message_tag const.

[IO] Add private NodePartitionedMeshReader::readDataFromFile().

This encapsulates MPI IO code.

[MeL] NodePartMesh: Change global node id type to std::size_t.

[IO] Fix some of implicit int type conversions: sign/width.

[IO] Correct doxygen comments.

[IO] Move MPI communicator init to NodePartMeshReader ctor.

[MeL] Use size_t from std namespace.

[IO] Use postfix increment for counters.

[IO] Pass a vector to buildNodeStructType().

[IO] Use std::vector's data() instead of &v[0] in MPI calls.

[IO] Rewrite openASCIIFiles. Scopes and var names.

[IO] Improve const correctness.

[IO] Remove almost unused MeshLib namespace include.

[IO] Improve some comments.

[IO] Add missing includes and remove unused one.

[MeL] Remove unused forward declaration.

[IO] Replace _size_str with on-the-fly conversion.

[IO] Spelling

[IO] Remove duplicate information.

[IO] Improve const-correctness of member fcts.

[IO] Use std::vector in readElementASCII().

[IO] Move up MPI_node deallocation.

[IO] Rename variables.

anode -> node.
s_nodes -> nodes.

_size -> _mpi_comm_size
_rank -> _mpi_rank

[IO] Replace mesh_controls type with std::array.

In the readASCII().

[IO] Variable declaration at definition/use point.

[IO] Rewrite buildNodesStructTypeMPI().

Shorten the code, use MPI blocks for array (of three coordinates).

[IO] Make _mpi_node_type a class variable.

Move initialization to ctor and freeing to dtor.
Function renames.

The reader must exit scope before MPI_FINILIZE
is called.

[IO] Change variable's type long->int; MPI_Send().

[IO] Comment on element types.

[IO] Rename readBinaryDataFromFile(). Change container type.
parent 4da71c74
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment