Dmitri Naumov authored 3 years ago and Tom Fischer committed 3 years ago

spdlog is linked "public" in BaseLib.

Reason is the violation of odr for some globals defined
in the spdlog library.

==1540297==ERROR: AddressSanitizer: odr-violation (0x7f5ea9c9d020):
  [1] size=40 'vtable for spdlog::spdlog_ex' _deps/spdlog-src/src/spdlog.cpp
  [2] size=40 'vtable for spdlog::spdlog_ex' _deps/spdlog-src/src/spdlog.cpp
These globals were registered at these points:
  [1]:
    #0 0x5614686e0dfa in __asan_register_globals.part.0 (/home/naumov/w/ogs/d/bin/ogs+0x1bfdfa)
    #1 0x7f5e6cdbe7eb in asan.module_ctor (/home/naumov/w/ogs/d/bin/../lib/libMeshLib.so+0x17d37eb)

  [2]:
    #0 0x558bd62b6dfa in __asan_register_globals.part.0 (/home/naumov/w/ogs/d/bin/ogs+0x1bfdfa)
    #1 0x7f831c7e54ab in asan.module_ctor (/home/naumov/w/ogs/d/bin/../lib/libBaseLib.so+0x89a4ab)

Data member is used only in constructor, no need to store it.

Adding a single space in incorrectly broken lines.

boost::none -> std::nullopt
boost::make_optional -> std::make_optional
boost::optional<T>::get() -> std::optional<T>::value()

Are already called in `ogs_add_library()`.

Submodule commit b0bc24cfdda39b30145b1f6c2c84b801cd131fef was not available anymore in the master branch of ArashPartow/exprtk.
The branch was maybe rebased? Used commit c7c219480d9678eec7383a4a99030683c4a84d91 instead (same commit date).

Rename a the method from getNumberOfComponents() to getNumberOfGlobalComponents()
in class LocalToGlobalIndexMap.

The error does not pop up when compiling a unity build.

Allows usage of curves in Function type parameters.

The fmt library happily accepts std::string without
any conversions.

This reduces total build time.
Only in BaseLib spdlog is linked public.

Include spdlog via BaseLib/Logging.h, which
provides macro replacements for
ERR/DBUG/WARN/INFO...

This is explicitly allowing the 2d coordinate system
being given (contrary to the transformation<3> specialization).

Moving the code into cpp.

Fixes multiple copyright messages in the doxygen docu.

ag '\\file' -L --ignore=ThirdParty *Lib |xargs  sed -i 's/\(.*\)\\copyright/\1\\file\n\1\\copyright/'

Adding a new function for parameter lookup of optional tags.

Simplifies creation of SpatialPosition object with
multiple parts of it set simultaniously.