Dmitri Naumov authored 3 years ago and Tom Fischer committed 3 years ago

spdlog is linked "public" in BaseLib.

Reason is the violation of odr for some globals defined
in the spdlog library.

==1540297==ERROR: AddressSanitizer: odr-violation (0x7f5ea9c9d020):
  [1] size=40 'vtable for spdlog::spdlog_ex' _deps/spdlog-src/src/spdlog.cpp
  [2] size=40 'vtable for spdlog::spdlog_ex' _deps/spdlog-src/src/spdlog.cpp
These globals were registered at these points:
  [1]:
    #0 0x5614686e0dfa in __asan_register_globals.part.0 (/home/naumov/w/ogs/d/bin/ogs+0x1bfdfa)
    #1 0x7f5e6cdbe7eb in asan.module_ctor (/home/naumov/w/ogs/d/bin/../lib/libMeshLib.so+0x17d37eb)

  [2]:
    #0 0x558bd62b6dfa in __asan_register_globals.part.0 (/home/naumov/w/ogs/d/bin/ogs+0x1bfdfa)
    #1 0x7f831c7e54ab in asan.module_ctor (/home/naumov/w/ogs/d/bin/../lib/libBaseLib.so+0x89a4ab)

Using (const) access functions in two cases of direct
member access.

Move common setID() member from derived classes into
the base class allows for making the _id member private.

Access through getID() in two occasions for in gmsh and gocad
IO interface functions.

Simplifies handling in CMake. Just link to petsc-target.

The Sparse' module parts are used also if unsupported
module support is turned off.

Adding a single space in incorrectly broken lines.

 - formatting
 - system includes vs. project includes
 - use absolute paths

Dmitri Naumov authored 4 years ago and Lars Bilke committed 4 years ago

Use perfect forwarding, store by value.

Scalar product was substituted everywhere with Eigen's
dot() function.

The usage of CPMFindPackage instead of CPMAddPackage searches for
local installs of the package first and falls back to CPM if not
found.

Closes #3100.

This is partially reverting 071c19a9
"[CMake] Use generator expression for target_link_libraries()".

For the ninja build system when using shared libraries the
generator expressions produce erroneous build.ninja file, and
ninja generates an error:

```
CMake Error:
  Running

   '/usr/bin/ninja' '-C' '/home/naumov/w/ogs/r' '-t' 'recompact'

  failed with:

   ninja: error: build.ninja:8128: bad $-escape (literal $ must be written as $$)
```

Reason unknown.

is_same_v<> for is_same<>::value
decay_t<> for decay<>::type
is_integral_v<> for is_integral<>::value
invoke_result_t<> for invoke_result<>::type

Fixes #3075