* doc/guix.texi (Packaging Guidelines): Move to...
* doc/contributing.texi (Packaging Guidelines): ... here.  Turn into a
section.  Adjust references to "Contributing".

* doc/guix.texi (System Installation): Move right after "Installation".

* doc/guix.texi (Introduction): Add note about Guix System.
[Managing Software the Guix Way]: New section heading.
[GNU Distribution]: New subsection of "Introduction".  Mention "Guix
System" rather than "GuixSD" and update the list of supported systems.
(GNU Distribution): Remove as a chapter.
(System Installation, System Configuration, Documentation)
(Installing Debugging Files, Security Updates, Package Modules)
(Packaging Guidelines, Bootstrapping, Porting): Turn these sections
into chapters.

This is because (gnu tests docker) depends on (guix scripts pack).

* guix/self.scm (compiled-guix)[*system-test-modules*]: Add dependency
on *CLI-MODULES*.

* guix/scripts/offload.scm (check-machine-status): Report the time
difference for each MACHINE.

* guix/records.scm (report-duplicate-field-specifier): New procedure.
(make-syntactic-constructor): Call it.
* tests/records.scm ("define-record-type* & duplicate initializers"):
New test.

Co-authored-by: Mark H Weaver <mhw@netris.org>

Previous warnings and errors such as those raised by (guix records)
would not be displayed during the load phase.

* guix/build/compile.scm (load-files): Remove 'parameterize' around
'resolve-interface' call.
(compile-files)[build]: Move 'with-fluids' for *CURRENT-WARNING-PREFIX*
to...
<top level>: ... here.

* gnu/packages/haskell.scm (ghc-case-insensitive): Remove duplicate
'inputs' field.
* gnu/packages/python-xyz.scm (python2-pysnptools): Remove duplicate
'native-inputs' field.
* gnu/tests/install.scm (%separate-home-os): Remove duplicate 'type'
field.

* guix/self.scm: Remove 'reload-guix' export.

* gnu/system/vm.scm: Remove unnecessary (guix scripts pack) import.

* gnu/packages/linux.scm (fakeroot): New variable.

* gnu/packages/linux.scm (genext2fs): New variable.

* gnu/packages/finances.scm (bitcoin-core): Update to 0.17.1.

Signed-off-by: Danny Milosavljevic <dannym@scratchpost.org>

* gnu/packages/finance.scm (bitcoin-core)[arguments]<#:phases>[set-home]:
End phase in #t.

* gnu/packages/finance.scm (bitcoin-core)[arguments]<#:phases>
[make-qt-deterministic]: New phase.

Signed-off-by: Danny Milosavljevic <dannym@scratchpost.org>

* gnu/packages/base.scm (make-glibc-locales, make-glibc-utf8-locales): New
procedures.
(glibc-locales): Express in terms of make-glibc-locales.
(glibc-utf8-locales): Express in terms of make-glibc-utf8-locales.
(glibc-locales-2.27, glibc-utf8-locales-2.27): New variables.

* gnu/packages/pdf.scm (paps): Update to 0.7.0-1.37e6ca1.
[source]: Fetch from git.
[arguments]: Add phase "do-not-run-configure-script-during-bootstrap".
[native-inputs]: Add autoconf, automake, gettext-minimal, glib:bin and
intltool.
[home-page]: Point to Github.

* gnu/packages/python-web.scm (python-websocket-client): Update to 0.54.0.
[properties]: New field.
(python2-websocket-client)[native-inputs]: Add
python2-backport-ssl-match-hostname.

* gnu/packages/python-xyz.scm (python-isort): Update to 4.3.4.
[source]: Use 'git-fetch'.
[properties]: New field.
(python2-isort)[native-inputs]: Add python2-futures.

* gnu/packages/python-xyz.scm (python-wrapt): Update to 1.11.1.

* gnu/packages/python-xyz.scm (python-virtualenv): Update to 16.1.0.
[arguments]: Move custom 'check phase to custom 'disable-failing-test
phase and re-instate standard 'check phase.

* gnu/packages/guile.scm (guile-bytestructures): Update to 1.0.5.

This removes emacs-xyz.scm from the closure of (gnu packages base).

* gnu/packages/package-management.scm (emacs-nix-mode): Move back to...
* gnu/packages/emacs-xyz.scm (emacs-nix-mode): ... here.  New variable.

This is a followup to commit 5f7467f0.

* tests/guix-system.sh: For <bootloader-configuration> records, use
'target' rather than 'device'.

* guix/store.scm (&nix-error): Rename to...
(&store-error): ... this, and adjust users.
(&nix-connection-error): Rename to...
(&store-connection-error): ... this, and adjust users.
(&nix-protocol-error): Rename to...
(&store-protocol-error): ... this, adjust users.
(&nix-error, &nix-connection-error, &nix-protocol-error): Define these
condition types and their getters as deprecrated aliases.
* build-aux/run-system-tests.scm, guix/derivations.scm,
guix/grafts.scm, guix/scripts/challenge.scm,
guix/scripts/graph.scm, guix/scripts/lint.scm,
guix/scripts/offload.scm, guix/serialization.scm,
guix/ssh.scm, guix/tests.scm, guix/ui.scm,
tests/derivations.scm, tests/gexp.scm, tests/guix-daemon.sh,
tests/packages.scm, tests/store.scm, doc/guix.texi: Adjust to use the
new names.

* guix/store.scm (<nix-server>): Rename to...
(<store-connection>): ... this.  Adjust users accordingly.
(nix-server?, nix-server-major-version)
(nix-server-minor-version, nix-server-socket)
(nix-server-version): Define as deprecated aliases.
* guix/inferior.scm: Adjust accordingly.
* guix/ssh.scm: Likewise.

* guix/deprecation.scm (deprecation-warning-port): Default
to (current-error-port).

* guix/deprecation.scm (define-deprecated/alias): New macro.

* gnu/packages/games.scm (fortune-mod)[arguments]: Skip failing tests.

* gnu/packages/video.scm (mediainfo): Update to 18.12.
[arguments]: Remove manual autogen.sh.

* gnu/packages/cpp.scm (libzen)[source]: Fix sha256.
[arguments]: Remove manual autogen.sh.

* guix/import/github.scm (latest-released-version): Use any and cond instead
of a recursive loop and an if-else ladder respectively.

* guix/import/github.scm (latest-released-version): Use preleases when package
has no releases.

* gnu/packages/virtualization.scm (xen): Update comments.

* gnu/packages/virtualization.scm (xen)[arguments]<#:phases>[patch]:
Don't patch etherboot's "Makefile".

When trying to convert a PDF to EPUB, the following error occurs:

File "/gnu/store/kz6bgqw9z7akj11zh20wkx14cgq0s3n2-calibre-3.35.0/lib/calibre/calibre/ebooks/pdf/pdftohtml.py", line 76, in pdftohtml
    _('Could not find pdftohtml, check it is in your PATH'))

Hardcode pdftohtml binary path by patching pdftohtml.py.

* gnu/packages/ebook.scm (calibre)[arguments]: Patch pdftohtml.py in
'configure phase to set hardcode pdftohtml binary path.

* gnu/packages/moreutils.scm (moreutils): Update to 0.63.
[arguments]: All phases return #t.

* gnu/packages/perl.scm (perl-module-scandeps): Update to 1.27.

* gnu/packages/perl.scm (perl-json): Update to 4.01.
[source]: Update source uri.

* gnu/packages/perl.scm (perl-json-xs): Update to 4.0.
[native-inputs]: Add perl-canary-stability.