* gnu/packages/emacs-xyz.scm (emacs-magit-gerrit): New variable.

It was not obvious that another application, Yelp, needed to be installed to
so that opening the help of GnuCash from within the application would work.

Fixes issue #33960 (see: https://issues.guix.info/issue/33960).

* gnu/packages/gnucash.scm (gnucash)[description]: Explain how to enable the
  documentation.

* gnu/packages/gnucash.scm (gnucash): Update to 3.4.
[outputs]: Add debug.
(gnucash-docs): Update to 3.4-1.
[native-inputs]: Update docbook-xml to version 4.5 and drop older versions.

The qof test is also reinstated; it was failing because the needed locales
were not installed.

* gnu/packages/patches/gnucash-disable-failing-tests.patch: Delete file.
* gnu/local.mk (dist_patch_DATA): Unregister it.
* gnu/packages/gnucash.scm (gnucash)[patches]: Remove it.
[phases]{disable-stress-options-test}: Implement it using SUBSTITUTES*.
{install-locales}: New phase.

* gnu/packages/patches/gnucash-price-quotes-perl.patch: Delete file.
* gnu/local.mk (dist_patch_DATA): Unregister it.
* gnu/packages/gnucash.scm (gnucash)[patches]: Remove it.
[phases]{fix-finance-quote-check}: Implement it using SUBSTITUTES*.

* gnu/packages/gnucash.scm (gnucash): Fix indentation.

* gnu/packages/emacs-xyz.scm (emacs-simple-mpc): New variable.

* gnu/packages/guile.scm (guile-wisp)[arguments]: Slightly simplify and fix
indentation.

* gnu/packages/guile.scm (guile-wisp)[home-page]: Use HTTPS.

* gnu/packages/guile.scm (guile-wisp): Update to 0.9.9.

* gnu/packages/emacs-xyz.scm (emacs-emms-mode-line-cycle)[source]: Use
'git-fetch'.

* gnu/packages/emacs-xyz.scm (emacs-ghub): Update to 3.2.0.
[propagated-inputs]: Add emacs-dash, emacs-graphql, emacs-treepy.
[synopsis, description]: Update.
(emacs-magit, emacs-magit-svn)[propagated-inputs]: Add emacs-graphql,
emacs-treepy.
[arguments]: Update accordingly.

* gnu/packages/emacs-xyz.scm (emacs-magit): Update to 2.13.1.
[source]: Use 'git-fetch'.

* gnu/packages/emacs-xyz.scm (emacs-haskell-mode)[source]: Use 'git-fetch'.

* gnu/packages/emacs-xyz.scm (emacs-ghub)[source]: Use 'git-fetch'.

* gnu/packages/emacs-xyz.scm (emacs-magit-svn): Update to 2.2.1.

* gnu/packages/emacs-xyz.scm (emacs-magit-svn)[propagated-inputs]: Add
emacs-ghub, emacs-magit-popup.
[arguments]: Adjust accordingly.

* gnu/packages/emacs-xyz.scm (emacs-magit-svn)[source]: Use 'git-fetch'.
[native-inputs]: Remove tar, gzip.
[arguments]: Adjust code accordingly.

* gnu/packages/emacs-xyz.scm (emacs-git-mode)[source]: Use 'git-fetch'.

* gnu/packages/wine.scm (wine-staging-patchset-data): Update to 4.0.
* gnu/packages/wine.scm (wine-staging): Update to 4.0.

* gnu/packages/wine.scm (wine): Update to 4.0.
[inputs]: Add sdl2 and vulkan-loader.
* gnu/packages/wine.scm (wine-staging)[inputs]: Remove sdl2 and vulkan-loader,
inherit from wine instead.

* gnu/packages/linux.scm (%linux-libre-version): Update to 4.20.4.
(%linux-libre-hash): Update hash.

* gnu/packages/linux.scm (%linux-libre-4.19-version): Update to 4.19.17.
(%linux-libre-4.19-hash): Update hash.

The latest tag is many years old, and the latest upstream branch includes
important fixes such as displaying correctly the backtrace upon encountering
errors (see:
https://github.com/rejeep/ert-runner.el/commit/4b6e6cb81fb3cb9db60046f70256555a9ae97459).

* gnu/packages/emacs-xyz.scm (emacs-ert-runner): Update to the latest upstream
commit.
[origin]: Use GIT-FETCH instead of URL-FETCH to mitigate against GitHub's
dynamically generated tarballs.

* doc/guix.texi (Package Modules): Move to...
(Programming Interface): ... here.  Turn into a section.

* doc/guix.texi (Packaging Guidelines): Move to...
* doc/contributing.texi (Packaging Guidelines): ... here.  Turn into a
section.  Adjust references to "Contributing".

* doc/guix.texi (System Installation): Move right after "Installation".

* doc/guix.texi (Introduction): Add note about Guix System.
[Managing Software the Guix Way]: New section heading.
[GNU Distribution]: New subsection of "Introduction".  Mention "Guix
System" rather than "GuixSD" and update the list of supported systems.
(GNU Distribution): Remove as a chapter.
(System Installation, System Configuration, Documentation)
(Installing Debugging Files, Security Updates, Package Modules)
(Packaging Guidelines, Bootstrapping, Porting): Turn these sections
into chapters.

This is because (gnu tests docker) depends on (guix scripts pack).

* guix/self.scm (compiled-guix)[*system-test-modules*]: Add dependency
on *CLI-MODULES*.

* guix/scripts/offload.scm (check-machine-status): Report the time
difference for each MACHINE.

* guix/records.scm (report-duplicate-field-specifier): New procedure.
(make-syntactic-constructor): Call it.
* tests/records.scm ("define-record-type* & duplicate initializers"):
New test.

Co-authored-by: Mark H Weaver <mhw@netris.org>

Previous warnings and errors such as those raised by (guix records)
would not be displayed during the load phase.

* guix/build/compile.scm (load-files): Remove 'parameterize' around
'resolve-interface' call.
(compile-files)[build]: Move 'with-fluids' for *CURRENT-WARNING-PREFIX*
to...
<top level>: ... here.

* gnu/packages/haskell.scm (ghc-case-insensitive): Remove duplicate
'inputs' field.
* gnu/packages/python-xyz.scm (python2-pysnptools): Remove duplicate
'native-inputs' field.
* gnu/tests/install.scm (%separate-home-os): Remove duplicate 'type'
field.

* guix/self.scm: Remove 'reload-guix' export.

* gnu/system/vm.scm: Remove unnecessary (guix scripts pack) import.

* gnu/packages/linux.scm (fakeroot): New variable.

* gnu/packages/linux.scm (genext2fs): New variable.

* gnu/packages/finances.scm (bitcoin-core): Update to 0.17.1.

Signed-off-by: Danny Milosavljevic <dannym@scratchpost.org>

* gnu/packages/finance.scm (bitcoin-core)[arguments]<#:phases>[set-home]:
End phase in #t.

* gnu/packages/finance.scm (bitcoin-core)[arguments]<#:phases>
[make-qt-deterministic]: New phase.

Signed-off-by: Danny Milosavljevic <dannym@scratchpost.org>