Skip to content

Make geometry search strict

Lars Bilke requested to merge github/fork/chleh/make-geometry-search-strict into master

Created by: chleh

Until now, if a geometry, e.g., for a BC, is not found, a debug (!) message is printed and a nullptr is returned from the respective method. If I remember correctly, this nullptr effectively causes that a Dirichlet BC is set not only on the boundary but on the entire domain (at least I observed such a behaviour some time ago). The search for geometries is one (maybe the only?) weak point in OGS6's project file parsing. This PR changes the behaviour in such a way that an error message is printed if a geometry is not found and the program being aborted afterwards. That's consistent with what we do for all other project file errors. I am aware of the fact that this PR can cause serious trouble for the DataExplorer: Nobody wants it to crash on wrong input. I just want to point to the problem. My solution is simple and effective (too effective for the DE). If you find a better solution than mine, I would appreciate that.

If you want to take over this PR, please do so.

For the time being, here's my PR.

ToDo:

  • fix input files of present end-to-end tests

Merge request reports