Skip to content

BaseLib filename string manipulation rewrite.

Dmitry Yu. Naumov requested to merge github/fork/endJunction/BaseLibIOSimplify into master

Dear all, I rewrote the filename string manipulation part in BaseLib.

I could not fully understand the desired behaviour of the old code. The expected behaviour is reflected in the tests (see Tests/BaseLib/TestFilePathStringManipulation.cpp. (1) This is my first request to verify the unit tests in this file.

Another problem is that there are no tests for the code outside the BaseLib, which is using FileTools. These include:

  • FileIO/XmlIO/XmlStnInterface.cpp
  • FileIO/Legacy/MeshIO.cpp
  • FileIO/Legacy/OGSIOVer4.cpp
  • FileIO/MeshIO/GMSHInterface.cpp
  • FileIO/readMeshFromFile.cpp
  • FileIO/GMSInterface.cpp
  • FileIO/RapidXmlIO/RapidStnInterface.cpp
  • FileIO/RapidXmlIO/RapidVtuInterface.cpp
  • SimpleTests/MeshTests/MeshRead.cpp There are some minor changes in all of this files, (2) and I would like to ask the owners to verify those changes too. It would be better if all of this code would be tested.

Merge request reports