Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • O ogs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 72
    • Issues 72
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 27
    • Merge requests 27
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ogs
  • ogs
  • Merge requests
  • !3857

Vtk mesh converter: safely convert all integer types.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dmitry Yu. Naumov requested to merge endJunction/ogs:VtkIntegerArrayConversion into master Oct 31, 2021
  • Overview 10
  • Commits 7
  • Pipelines 8
  • Changes 3

After a recent update of some package in ArchLinux reading of bulk_node_ids started to fail. This lead to investigation of how the vtk data arrays are converted to OGS mesh properties.

Mainly the vtkLongArray and vtkLongLongArray conversions (and same for unsigned types) were merged because both results in same length integer type of 8 bytes.

Add compile-time tests for conversion of integer types since in OGS we use the char, short, int, long types which are not guaranteed to be of corresponding length of vtk types.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?

Somewhat related to #3053

Edited Nov 04, 2021 by Christoph Lehmann
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: VtkIntegerArrayConversion