Skip to content
GitLab

Use MPL in ThermalTwoPhaseFlowWithPP (Part 2)

Merged Boyan Meng requested to merge boyanmeng/ogs:MPL_in_ThermalTwoPhaseFlowWithPP into master

This MR finalizes the implementation of MPL in ThermalTwoPhaseFlowWithPP. All state variables in the local assembler are replaced with MPL. The implementation largely followed the TH2M process. The old material properties are deleted (including MaterialLib).

Special notes are:

  1. The reference solutions are updated. This is because the computation of dSwdpc is now implemented with MPL. Before it was calculated by the inverse of dpcdSw, thus there are some slight differences in the numerical results. However, such differences are negligible compared to the original reference. Below is the comparison of primary unknowns at t=1.1e6 s (symbols represent new reference). compare

  2. Currently the assumption of ideal gas law is still embedded in the EOS. A generic gas density as suggested by @Scinopode will be implemented later, as the enthalpies also need to be changed.

  3. Feature description was added to the changelog

  4. Tests covering your feature were added?

  5. Any new feature or behavior change was documented?

Edited by Boyan Meng