Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • O ogs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 72
    • Issues 72
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 27
    • Merge requests 27
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ogs
  • ogs
  • Merge requests
  • !4014

Use MPL in ThermalTwoPhaseFlowWithPP (Part 2)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Boyan Meng requested to merge boyanmeng/ogs:MPL_in_ThermalTwoPhaseFlowWithPP into master Feb 23, 2022
  • Overview 13
  • Commits 15
  • Pipelines 9
  • Changes 49

This MR finalizes the implementation of MPL in ThermalTwoPhaseFlowWithPP. All state variables in the local assembler are replaced with MPL. The implementation largely followed the TH2M process. The old material properties are deleted (including MaterialLib).

Special notes are:

  1. The reference solutions are updated. This is because the computation of dSwdpc is now implemented with MPL. Before it was calculated by the inverse of dpcdSw, thus there are some slight differences in the numerical results. However, such differences are negligible compared to the original reference. Below is the comparison of primary unknowns at t=1.1e6 s (symbols represent new reference). compare

  2. Currently the assumption of ideal gas law is still embedded in the EOS. A generic gas density as suggested by @Scinopode will be implemented later, as the enthalpies also need to be changed.

  3. Feature description was added to the changelog

  4. Tests covering your feature were added?

  5. Any new feature or behavior change was documented?

Edited Feb 28, 2022 by Boyan Meng
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: MPL_in_ThermalTwoPhaseFlowWithPP