Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • O ogs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 72
    • Issues 72
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 27
    • Merge requests 27
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ogs
  • ogs
  • Merge requests
  • !4055

Fixing a bug in Process::setInitialConditions under PETSc

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged wenqing requested to merge wenqing/ogs:fix_petsc into master Mar 23, 2022
  • Overview 4
  • Commits 3
  • Pipelines 2
  • Changes 3

In Process::setInitialConditions, MathLib::LinAlg::setLocalAccessibleVector(x) is missed call before x is used for the computation the initial secondary variables. The bug leads to incorrect initial secondary variable assignment for some cases when PETSc is used.

This bug fixing fixes the issue addressed in #3217 (closed). As a verification, the example in #3217 (closed) is added as a benchmark. The new PETSc related benchmark use the existing reference file. The following figures show the comparison of the results solved by Eigen and PETSc linear solver, respectively: TH1

This MR closes #3217 (closed).

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?
Edited Mar 23, 2022 by wenqing
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix_petsc