Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • O ogs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 98
    • Issues 98
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 40
    • Merge requests 40
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ogsogs
  • ogs
  • Merge requests
  • !4115

Test surface normals

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christoph Lehmann requested to merge chleh/ogs:test-normals into master Apr 22, 2022
  • Overview 22
  • Commits 10
  • Pipelines 7
  • Changes 10

While implementing the test the following bugs were found and fixed:

  • One wrongly oriented edge in Quad8.
  • Incomplete implementation of surface unit normal computation for 1D elements.
  • Wrong determination whether a point is contained in a line segment.

The tests are done using reference elements. In the future they can be extended to rotated, scaled and translated elements.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
Edited Apr 25, 2022 by Christoph Lehmann
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: test-normals