Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • O ogs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 112
    • Issues 112
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 43
    • Merge requests 43
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ogsogs
  • ogs
  • Merge requests
  • !4363

TRM: Add a constitutive setting using the extended OGS-MFront interface

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christoph Lehmann requested to merge chleh/ogs:trm-extended-mfront-except-notebook into master Nov 03, 2022
  • Overview 40
  • Commits 15
  • Pipelines 14
  • Changes 92

This MR...

  • Generalizes some functionality of MaterialLib and ProcessLib/Deformation
  • Adds a second constitutive setting SigSatEpsPT in addition to the Original one to the TRM process
  • Adds a template parameter for the constitutive setting to the TRM process.

The constitutive settings SigSatEpsPT and Original are very similar. The new one, SigSatEpsPT, adds lots of code, but the differences to Original are not very large. This can be seen with your favourite diff tool, e.g.:
meld ProcessLib/ThermoRichardsMechanics/ConstitutiveSigSatEpsPT/ ProcessLib/ThermoRichardsMechanics/ConstitutiveOriginal/.
I recommend that you take a look with a diff tool, before you make the MR review. It might save you a lot of work and brain capacity.
I didn't find a good way reduce the copied boilerplate code, yet. Macros might work. Or some compile time template graph metaprogramming magic :-)

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?
Edited Nov 18, 2022 by Christoph Lehmann
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: trm-extended-mfront-except-notebook