Skip to content

Fix latent heat K_Tp terms in TRF/TRM

joergbuchwald requested to merge joergbuchwald/ogs:fixdensities into master

The MR fixes the K_Tp terms in TRF and TRM. The changes have little impact, only TaskCDECOVALEX2023 benchmarks are affected. Here, their changes.

relative_change_saturation

relative_change_temperature

relative_change_pressure

It also improves the convergence:

convergence_TRM

convergence_TRF

I also tested the latent heat implementation of TRM agains TH2M with const. gas pressure using an altered heat pipe benchmark. Without advection (c_p=0) it looks relative good:

latent_heat_test_noadv_10000000.0_temperature

latent_heat_test_noadv_10000000.0_saturation

With advection there are some differences:

latent_heat_test_fulladv_10000000.0_temperature

latent_heat_test_fulladv_10000000.0_saturation

However, total agreement is not expected in both cases as latent heat implantation as well as advection terms differ. (See https://www.sciencedirect.com/science/article/pii/S1365160923002083 for details)

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?
Edited by joergbuchwald

Merge request reports