Skip to content

Fixing off-by-one-timestep error in OGS's output when <linear> is used.

Christoph Lehmann requested to merge chleh/ogs:fix-is-linear-output-off-by-one into master

This MR adds a preOutput() hook to the Process class. That hook computes data used exclusively for output purposes, such as nodal flow rates.
In a future MR the hooks postNonlinearSolver(), postTimestep(), computeSecondaryVariables() and preOutput() should be refactored. Not all of the four are required.

This MR is for ComponentTransport. There will be a second MR for LiquidFlow suffering from the same bug. In subsequent MRs the implementations of all other processes will be changed, too (they have the same underlying off-by-one-iteration problem, but since they don't support <linear> in their cases the consequences are less severe).

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?
Edited by Christoph Lehmann

Merge request reports