Skip to content

Draft: Revert "[PL/THM] Move update CVs to postTimeStep"

Dmitry Yu. Naumov requested to merge endJunction/ogs:THM_eval_CRs into master

In a previous MR [!4907 (merged)] for the THM process the method updateConstitutiveRelations(...) was moved to postTimestepConcrete(...) in order to avoid an initialization problem for restarts. However, this turned out to be not necessary at the end. Moreover, the Darcy velocity field was thus not calculated at the beginning of the time step leading to NaN-values at the start of the simulation.

Consequently, this commit is reverted in the present MR. In addition, for a (T)HM restart test, the (NaN-free) Darcy velocity field at the beginning of part 1 and 2 of the simulation is added. Thus, the appearance of NaN values should be detected in future. However, for this to work another issue has to be solved.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behaviour change was documented?
Edited by Christian Silbermann

Merge request reports