Updated node ordering validation method in NodeReordering
This MR updates the node ordering validation method in NodeReordering to use a numerical approach, specifically checking that det(J) >= 0, which aligns with the method employed in OGS.
Two tests have been removed because they use a triangular mesh embedded in 3D space. Since 2D elements mapped in 3D space always satisfy det(J) >= 0 due to the global-to-local coordinate transformation, these tests no longer provide meaningful validation.
It is the first step toward enabling NodeReordering for higher-order elements.
-
Feature description was added to the changelog -
Tests covering your feature were added? Tested with - A 2D mesh with incorrect node ordering.
- A mesh that contains only one line element, one triangle element, one quadrilateral element, one tetrahedron element, one hexahedron element, one prism element, and one pyramid element, all in linear order. All 3D elements have incorrect node ordering. The test checks whether node reordering works for all element types. Since the mesh is 3D, the line, triangle, and quadrilateral elements mapped in 3D space always satisfy det(J) >= 0 due to the global-to-local coordinate transformation. Therefore, only the 3D elements are reordered in the test.
-
Any new feature or behaviour change was documented?
Edited by wenqing