Review comments.

Applications/Python/ogs.simulator/CMakeLists.txt

@@ -17,5 +17,5 @@ target_link_libraries(
 )
 target_include_directories(simulator PRIVATE ../../CLI)
 
-# Install into Python module root dir (enables 'import ogs.callbacks')
+# Install into Python module root dir (enables 'import ogs.simulator')
 install(TARGETS simulator LIBRARY DESTINATION ogs)

Applications/Python/ogs/_internal/provide_ogs_cli_tools_via_wheel.py

@@ -4,6 +4,8 @@ import subprocess
 import sys
 from pathlib import Path
 
+# Here, we assume that this script is installed, e.g., in a virtual environment
+# alongside a "bin" directory.
 OGS_BIN_DIR = Path(__file__).parent.parent.parent / "bin"
 
 binaries_list = [
@@ -72,7 +74,7 @@ binaries_list = [
 ]
 
 
-def pyproject_get_scripts():
+def pyproject_get_binaries():
     return {
         binary: f"ogs._internal.provide_ogs_cli_tools_via_wheel:{binary}"
         for binary in binaries_list

Applications/Python/ogs/_internal/wrap_cli_tools.py

@@ -3,6 +3,8 @@ from pathlib import Path
 
 from .provide_ogs_cli_tools_via_wheel import binaries_list, ogs_with_args
 
+# Here, we assume that this script is installed, e.g., in a virtual environment
+# alongside a "bin" directory.
 OGS_BIN_DIR = Path(__file__).parent.parent.parent / "bin"
 
 

pyproject.toml

@@ -39,9 +39,9 @@ write_to = "Applications/Python/_version.py"
 write_to_template = '__version__ = "{version}"'
 version_scheme = "no-guess-dev"
 git_describe_command = 'git describe --dirty --tags --long --match "*[0-9]*" --abbrev=8'
-# TODO neither local_scheme callable (https://github.com/pypa/setuptools_scm/issues/832)
-# or env var (https://github.com/pypa/setuptools_scm/issues/455) does not work.
-# Should be node-and-date by default and no-local-version in CI
+# local_scheme should be node-and-date by default and no-local-version in CI.
+# Unfortunately setting via env var does not work.
+# See https://github.com/pypa/setuptools_scm/issues/455.
 local_scheme = "no-local-version"
 
 [tool.pytest.ini_options]

scripts/python/scikit-build-plugins/scripts/__init__.py

 from __future__ import annotations
 
 import sys
-import os
+from pathlib import Path
 
-sys.path.append(os.path.join("Applications", "Python"))
-from ogs._internal.provide_ogs_cli_tools_via_wheel import pyproject_get_scripts
+sys.path.append(str(Path("Applications").joinpath("Python").absolute()))
+from ogs._internal.provide_ogs_cli_tools_via_wheel import pyproject_get_binaries
 
 __all__ = ["dynamic_metadata"]
 
@@ -25,10 +25,4 @@ def dynamic_metadata(
         msg = "No inline configuration is supported"
         raise ValueError(msg)
 
-    # Structure for entry-points
-    # eps = {
-    #    "console_scripts": {"ogs": "ogs._internal.provide_ogs_cli_tools_via_wheel:ogs"}
-    # }
-    # scripts = {"ogs": "ogs._internal.provide_ogs_cli_tools_via_wheel:ogs"}
-
-    return {"scripts": pyproject_get_scripts()}
+    return {"scripts": pyproject_get_binaries()}