Use emplace_back for some of vector.push_back ops.

clang-tidy modernize-use-emplace check.

Applications/DataExplorer/DataView/DirectConditionGenerator.cpp

@@ -53,8 +53,7 @@ DirectConditionGenerator::directToSurfaceNodes(const MeshLib::Mesh& mesh,
         {
             double val(raster->getValueAtPoint(*surface_node));
             val = (val == no_data) ? 0 : val;
-            _direct_values.push_back(
-                std::make_pair(surface_node->getID(), val));
+            _direct_values.emplace_back(surface_node->getID(), val);
         }
         delete raster;
 

MeshLib/IO/VtkIO/PVDFile.cpp

@@ -22,7 +22,7 @@ namespace IO
 
 void PVDFile::addVTUFile(const std::string &vtu_fname, double timestep)
 {
-    _datasets.push_back(std::make_pair(timestep, vtu_fname));
+    _datasets.emplace_back(timestep, vtu_fname);
 
     std::ofstream fh(_pvd_filename.c_str());
     if (!fh) {

ProcessLib/HeatTransportBHE/CreateHeatTransportBHEProcess.cpp

@@ -184,19 +184,21 @@ std::unique_ptr<Process> createHeatTransportBHEProcess(
 
         if (bhe_type == "1U")
         {
-            bhes.push_back(BHE::createBHE1U(bhe_config, curves));
+            bhes.emplace_back(BHE::createBHE1U(bhe_config, curves));
             continue;
         }
 
         if (bhe_type == "CXA")
         {
-            bhes.push_back(BHE::createBHECoaxial<BHE::BHE_CXA>(bhe_config, curves));
+            bhes.emplace_back(
+                BHE::createBHECoaxial<BHE::BHE_CXA>(bhe_config, curves));
             continue;
         }
 
         if (bhe_type == "CXC")
         {
-            bhes.push_back(BHE::createBHECoaxial<BHE::BHE_CXC>(bhe_config, curves));
+            bhes.emplace_back(
+                BHE::createBHECoaxial<BHE::BHE_CXC>(bhe_config, curves));
             continue;
         }
         OGS_FATAL("Unknown BHE type '%s'.", bhe_type.c_str());

ProcessLib/LIE/Common/MeshUtils.cpp

@@ -186,7 +186,7 @@ void findFracutreIntersections(
                     matIDs[1] = matid;  // slave
                 }
             }
-            vec_branch_nodeID_matIDs.push_back(std::make_pair(nodeID, matIDs));
+            vec_branch_nodeID_matIDs.emplace_back(nodeID, matIDs);
         }
         else
         {
@@ -195,8 +195,7 @@ void findFracutreIntersections(
                                  vec_matID_counts.rbegin()->first);
             matIDs[1] = std::max(vec_matID_counts.begin()->first,
                                  vec_matID_counts.rbegin()->first);
-            vec_junction_nodeID_matIDs.push_back(
-                std::make_pair(nodeID, matIDs));
+            vec_junction_nodeID_matIDs.emplace_back(nodeID, matIDs);
         }
     }
 

ProcessLib/Utils/ProcessUtils.cpp

@@ -90,7 +90,7 @@ std::vector<std::reference_wrapper<ProcessVariable>> findProcessVariables(
 
     for (std::string const& var_name : var_names)
     {
-        vars.push_back(findVariableByName(variables, var_name, tag));
+        vars.emplace_back(findVariableByName(variables, var_name, tag));
         cached_var_names.push_back(var_name);
     }
 

Tests/MaterialLib/TestMPLParseMaterial.cpp

@@ -52,7 +52,7 @@ struct Medium
     {
         for (auto p : phases_)
         {
-            phases.push_back(Phase(p));
+            phases.emplace_back(p);
         }
     }
 };