XMLQtInterface::insertStyleFileDefinition

Including
 - usage of static_cast instead of c-style cast,
 - single variable declaration per line,
 - removing const from return types
 - omit unnecessary string to char* conversions,

The used clang-tidy checks are:
google-readability-casting,
readability-const-return-type,
readability-container-size-empty,
readability-delete-null-pointer,
readability-deleted-default,
readability-else-after-return,
readability-function-size,
readability-identifier-naming,
readability-inconsistent-declaration-parameter-name,
readability-isolate-declaration,
readability-misleading-indentation,
readability-misplaced-array-index,
readability-named-parameter,
readability-redundant-*,
readability-simplify-*,
readability-static-accessed-through-instance,
readability-static-definition-in-anonymous-namespace,
readability-string-compare,
readability-uniqueptr-delete-release

Most of the current .clang-tidy contained checks:
google-explicit-constructor
google-readability-braces-around-statements
modernize-loop-convert
modernize-use-default-member-init
modernize-use-emplace
modernize-use-using
readability-braces-around-statements
readability-else-after-return
readability-named-parameter
*readability-namespace-comments
*readability-inconsistent-*
readability-redundant-member-init
readability-simplify-boolean-expr
readability-string-compare
*explicit-conversions*

Avoid unnecessary initialization.

clang-tidy modernize-use-bool-literals check.

Only in ERR/WARN/INFO/DBUG/OGS_FATAL and similar, not in
formatted output like xml files.

1. Changed urls to https which fixed the following error:

xsd/OpenGeoSysGLI.xsd, at line 1, column 66: Document is not a XML schema.
Error XSDError in ..., at line 3, column 194: Loaded schema file is invalid.

If this error ever pops up again try to cut the internet connection! No joke!

2. Local schema files are now copied to bin-directory during CMake configuration and package generatiion (install step).

Clang format run on near-the-header lines.

Happy New Year

Dmitri Naumov authored 7 years ago and Dmitri Naumov committed 7 years ago

If empty, no deletion is done anyway.

This makes the libGeoLib.a by almost 2KiB and the DataExplorer
executable by 498B smaller.

Drop unnecessary args from delete functions.

Especially on iterator types and 'new' allocations.

Move parts from FileIO to GeoLib/IO and BaseLib/IO.