These are almost the same and the difference is in the
handling of the shape functions.

Helps to identify that not everything was built. Prevents empty
artifacts when browsing to
https://jenkins.opengeosys.org/job/ufz/job/ogs/job/master/lastSuccessfulBuild/artifact/

Jenkins link should update on each build but somehow netlify does
not invalidate the cache for it... Only manually deleting the cache
worked so I temporarily set
https://jenkins.opengeosys.org/job/ufz/job/ogs/job/master/lastSuccessfulBuild/artifact/
as the download link.

Fix cppcheck warnings.

Prefer prefix ++/-- operators for non-primitive types.. Prefix ++/--
operators should be preferred for non-primitive types.
Pre-increment/decrement can be more efficient than
post-increment/decrement. Post-increment/decrement usually involves
keeping a copy of the previous value around and adds a little extra
code.

cppcheck warning:
class 'PetrelInterface' does not have a copy constructor which is
recommended since the class contains a pointer to allocated memory.

[Jenkins] clang-tidy checks

Lars Bilke authored 6 years ago and Dmitri Naumov committed 6 years ago

ON for non-ufz/master builds, OFF else.