The use of unique_ptr is not necessary since the vector
will be destroyed when going out of scope in the MarkNodesOutsideOfPolygon.

Tom Fischer authored 3 years ago and Dmitri Naumov committed 3 years ago

Pointer to vector of Point's wasn't cleaned up properly.

In rotatePolygonToXY a pointer to the vector of
polygon points was created. The rotated polygon is
on this vector. When the polygon is returned from
the function it isn't possible to cleanup the vector
properly. So the creation of the polygon is move to
the function markNodesOutSideOfPolygon.

This data isn't required anymore. The type of
station can be obtained via dynamic_cast.

The type ('simple' station or borehole)
of the object can be obtained by dynamic_cast.

Karsten Rink authored 3 years ago and Dmitri Naumov committed 3 years ago

more optimisations, range loops, typos, etc.

The length was used only internaly and
can be computed on the fly. This makes the
cumbersome and errorprone update of the length
unnecessary.

This allows to use MeshLib::Node and GL::Point in
the changed methods.