Simplifies handling in CMake. Just link to petsc-target.

Lars Bilke authored 3 years ago and Dmitri Naumov committed 3 years ago

node->name is an const unsigned char *.

Should be replaced with std::span when the compiler version
gcc >= 10, msvc >= 19.26 are available for development.

Adding a single space in incorrectly broken lines.

 - formatting
 - system includes vs. project includes
 - use absolute paths

Eliminating the function also reveals a copy of the data
being made internally.

Not accessed by derived classes.

Code simplification and one less dereferencing at run time.

The default precision of a Writer is set 10 digits anyway
upon construction.

The extra interface is also not needed, because the
standard provided call 'precision' is doing already
the same.

It is not private, so no underscores.

Since there are no invariants maintained by the XMLInterface
nor is the access restricted, the public memeber serves
same purpose with simpler implementation.

Also fix variable naming.

Dmitri Naumov authored 4 years ago and Dmitri Naumov committed 4 years ago

BaseLib::Counter is used in single place only, so
we can simplify that one place using MeshLib::Mesh
local static counter.

Fixes #3117.

boost::none -> std::nullopt
boost::make_optional -> std::make_optional
boost::optional<T>::get() -> std::optional<T>::value()

Especially useful when all nonlinear iterations should
be output. See <output_iteration_results> tag.

 - The Iterator type is trivial; passing it by const&.
 - The std::string root is invoked only on const& strings, so
moving it does not save anything in this context.