add gmres restart test1

set gmres restart test2

add restart option for all Preconditioners (final)

Saves ca. 35 unneeded includes (out of 260)
and 25s of compilation time (out of 149s).

No INFO/ERR/WARN/DBUG calls in this files.

The fmt library happily accepts std::string without
any conversions.

Dmitri Naumov authored 6 years ago and Dmitri Naumov committed 4 years ago

Include spdlog via BaseLib/Logging.h, which
provides macro replacements for
ERR/DBUG/WARN/INFO...

operator() (IndexType row, IndexType col)

Mostly in the file headers.

find *Lib -type f | xargs sed -i 'N;s%^\s\+\*\n\(\s\+\*/\)%\1%'

Fixes multiple copyright messages in the doxygen docu.

ag '\\file' -L --ignore=ThirdParty *Lib |xargs  sed -i 's/\(.*\)\\copyright/\1\\file\n\1\\copyright/'

If only file name is specified it causes a warning
about the name not to be specific enough if there is
another file with the same name, e.g.:

the name `IdealGasLaw.h' supplied as the second argument
in the \file statement matches the following input
files: ogs/MaterialLib/Fluid/Density/IdealGasLaw.h
ogs/MaterialLib/MPL/Properties/IdealGasLaw.h
Please use a more specific name by including a (larger)
part of the path!

From now on only \file w/o a name or a full path will
be allowed.

find -type f | xargs sed -i 's%\(\\file\).*%\1%'

Including
 - usage of static_cast instead of c-style cast,
 - single variable declaration per line,
 - removing const from return types
 - omit unnecessary string to char* conversions,

The used clang-tidy checks are:
google-readability-casting,
readability-const-return-type,
readability-container-size-empty,
readability-delete-null-pointer,
readability-deleted-default,
readability-else-after-return,
readability-function-size,
readability-identifier-naming,
readability-inconsistent-declaration-parameter-name,
readability-isolate-declaration,
readability-misleading-indentation,
readability-misplaced-array-index,
readability-named-parameter,
readability-redundant-*,
readability-simplify-*,
readability-static-accessed-through-instance,
readability-static-definition-in-anonymous-namespace,
readability-string-compare,
readability-uniqueptr-delete-release

Most of the current .clang-tidy contained checks:
google-explicit-constructor
google-readability-braces-around-statements
modernize-loop-convert
modernize-use-default-member-init
modernize-use-emplace
modernize-use-using
readability-braces-around-statements
readability-else-after-return
readability-named-parameter
*readability-namespace-comments
*readability-inconsistent-*
readability-redundant-member-init
readability-simplify-boolean-expr
readability-string-compare
*explicit-conversions*

CPPCheck warning type: redundantAssignment.

Conversion happened in the constant vectorXi construction.

Only in ERR/WARN/INFO/DBUG/OGS_FATAL and similar, not in
formatted output like xml files.

Dmitri Naumov authored 7 years ago and Dmitri Naumov committed 7 years ago

The default impl., which is not doing anything, is error prone,
because passing an object of not matrix type, e.g. std::unique_ptr<PETScVector>,
the default impl. will be taken.

Clang format run on near-the-header lines.

Happy New Year