Merge pull request #2378 from endJunction/Cleanup

Small fixes.

Applications/FileIO/GocadIO/GocadSGridReader.cpp

@@ -350,7 +350,8 @@ void GocadSGridReader::parseFaceSet(std::string& line, std::istream& in)
                     ERR("****** k coord %d to big for id %d.", c[2], id);
                 std::size_t const cell_id(
                     _index_calculator.getCellIdx(c[0], c[1], c[2]));
-                face_set_property._property_data[cell_id] = face_indicator;
+                face_set_property._property_data[cell_id] =
+                    static_cast<double>(face_indicator);
             }
             face_set_id_cnt++;
         }

ProcessLib/BoundaryCondition/BoundaryConditionConfig.h

@@ -25,16 +25,11 @@ struct BoundaryConditionConfig final
     {
     }
 
-    BoundaryConditionConfig(BoundaryConditionConfig&& other)
-        : config(std::move(other.config)),
-          boundary_mesh(other.boundary_mesh),
-          component_id(other.component_id)
-    {
-    }
+    BoundaryConditionConfig(BoundaryConditionConfig&& other) = default;
 
     BaseLib::ConfigTree config;
     MeshLib::Mesh const& boundary_mesh;
     boost::optional<int> const component_id;
 };
 
-}  // ProcessLib
+}  // namespace ProcessLib

ProcessLib/BoundaryCondition/NeumannBoundaryConditionLocalAssembler.h

@@ -33,7 +33,7 @@ public:
     NeumannBoundaryConditionLocalAssembler(
         MeshLib::Element const& e,
         std::size_t const local_matrix_size,
-        bool is_axially_symmetric,
+        bool const is_axially_symmetric,
         unsigned const integration_order,
         Parameter<double> const& neumann_bc_parameter)
         : Base(e, is_axially_symmetric, integration_order),

ProcessLib/Parameter/ConstantParameter.cpp

@@ -24,8 +24,8 @@ std::unique_ptr<ParameterBase> createConstantParameter(
     // If the 'value' tag is found, use it and return. Otherwise continue with
     // then required tag 'values'.
     {
-        //! \ogs_file_param{prj__parameters__parameter__Constant__value}
         auto const value =
+            //! \ogs_file_param{prj__parameters__parameter__Constant__value}
             config.getConfigParameterOptional<std::vector<double>>("value");
 
         if (value)

ProcessLib/ProcessVariable.cpp

@@ -139,7 +139,8 @@ ProcessVariable::ProcessVariable(
     }
     else
     {
-        INFO("No boundary conditions found.");
+        INFO("No boundary conditions for process variable '%s' found.",
+             _name.c_str());
     }
 
     // Source terms
@@ -166,7 +167,7 @@ ProcessVariable::ProcessVariable(
     }
     else
     {
-        INFO("No source terms found.");
+        INFO("No source terms for process variable '%s' found.", _name.c_str());
     }
 }
 

ProcessLib/RichardsFlow/RichardsFlowFEM.h

@@ -13,7 +13,6 @@
 
 #include "MathLib/InterpolationAlgorithms/PiecewiseLinearInterpolation.h"
 #include "MathLib/LinAlg/Eigen/EigenMapTools.h"
-#include "MeshLib/CoordinateSystem.h"
 #include "NumLib/DOF/DOFTableUtil.h"
 #include "NumLib/Extrapolation/ExtrapolatableElement.h"
 #include "NumLib/Fem/FiniteElement/TemplateIsoparametric.h"