Fix constness of arguments and variables.

Use const references where necessary.

Applications/FileIO/TetGenInterface.cpp

@@ -293,7 +293,7 @@ bool TetGenInterface::readNodesFromStream (std::ifstream &ins,
     return false;
 }
 
-bool TetGenInterface::parseNodesFileHeader(std::string& line,
+bool TetGenInterface::parseNodesFileHeader(std::string const& line,
                                            std::size_t& n_nodes,
                                            std::size_t& dim,
                                            std::size_t& n_attributes,

Applications/FileIO/TetGenInterface.h

@@ -122,7 +122,7 @@ private:
      * @param boundary_markers  have the nodes boundary information (output)
      * @return true, if the file header is read, false if the method detects an error
      */
-    static bool parseNodesFileHeader(std::string& line,
+    static bool parseNodesFileHeader(std::string const& line,
                                      std::size_t& n_nodes,
                                      std::size_t& dim,
                                      std::size_t& n_attributes,

Applications/Utils/MeshEdit/CreateBoundaryConditionsAlongPolylines.cpp

@@ -85,8 +85,8 @@ void writeLiquidFlowPointBC(std::ostream & bc_out, std::string const& pnt_name)
 // set on, geo_name is the name the geometry can be accessed with, out_fname is
 // the base file name the gli and bc as well as the gml file will be written to.
 void writeBCsAndGeometry(GeoLib::GEOObjects& geometry_sets,
-                         std::string& geo_name, std::string const& out_fname,
-                         std::string const& bc_type, bool write_gml)
+                         std::string const& geo_name, std::string const& out_fname,
+                         std::string const& bc_type, bool const write_gml)
 {
     if (write_gml) {
         INFO("write points to '{:s}.gml'.", geo_name);

Applications/Utils/MeshEdit/swapNodeCoordinateAxes.cpp

@@ -22,7 +22,8 @@
 #include "MeshLib/IO/readMeshFromFile.h"
 #include "MeshLib/IO/writeMeshToFile.h"
 
-static void swapNodeCoordinateAxes(MeshLib::Mesh &mesh, std::array<int, 3> const& new_axes_indices)
+static void swapNodeCoordinateAxes(MeshLib::Mesh const& mesh,
+                                   std::array<int, 3> const& new_axes_indices)
 {
     double new_coords[3] = {};
     for (MeshLib::Node* node : mesh.getNodes())

Applications/Utils/ModelPreparation/PartitionMesh/NodeWiseMeshPartitioner.cpp

@@ -381,7 +381,7 @@ bool copyPropertyVector(
     MeshLib::Properties& partitioned_properties,
     std::vector<Partition> const& partitions,
     MeshLib::PropertyVector<T> const* const pv,
-    std::map<MeshLib::MeshItemType, std::size_t> const total_number_of_tuples)
+    std::map<MeshLib::MeshItemType, std::size_t> const& total_number_of_tuples)
 {
     if (pv == nullptr)
     {

ChemistryLib/PhreeqcIO.cpp

@@ -128,7 +128,7 @@ static double averageReactantMolality(
 }
 }  // namespace
 
-PhreeqcIO::PhreeqcIO(std::string const project_file_name,
+PhreeqcIO::PhreeqcIO(std::string const& project_file_name,
                      std::string&& database,
                      std::unique_ptr<ChemicalSystem>&& chemical_system,
                      std::vector<ReactionRate>&& reaction_rates,

ChemistryLib/PhreeqcIO.h

@@ -34,7 +34,7 @@ struct UserPunch;
 class PhreeqcIO final : public ChemicalSolverInterface
 {
 public:
-    PhreeqcIO(std::string const project_file_name,
+    PhreeqcIO(std::string const& project_file_name,
               std::string&& database,
               std::unique_ptr<ChemicalSystem>&& chemical_system,
               std::vector<ReactionRate>&& reaction_rates,

MaterialLib/FractureModels/CreateCohesiveZoneModeI.cpp

@@ -28,19 +28,19 @@ std::unique_ptr<FractureModelBase<DisplacementDim>> createCohesiveZoneModeI(
     config.checkConfigParameter("type", "CohesiveZoneModeI");
     DBUG("Create CohesiveZoneModeI material");
 
-    auto& Kn = ParameterLib::findParameter<double>(
+    auto const& Kn = ParameterLib::findParameter<double>(
         //! \ogs_file_param_special{material__fracture_model__CohesiveZoneModeI__normal_stiffness}
         config, "normal_stiffness", parameters, 1);
 
-    auto& Ks = ParameterLib::findParameter<double>(
+    auto const& Ks = ParameterLib::findParameter<double>(
         //! \ogs_file_param_special{material__fracture_model__CohesiveZoneModeI__shear_stiffness}
         config, "shear_stiffness", parameters, 1);
 
-    auto& Gc = ParameterLib::findParameter<double>(
+    auto const& Gc = ParameterLib::findParameter<double>(
         //! \ogs_file_param_special{material__fracture_model__CohesiveZoneModeI__fracture_toughness}
         config, "fracture_toughness", parameters, 1);
 
-    auto& t_np = ParameterLib::findParameter<double>(
+    auto const& t_np = ParameterLib::findParameter<double>(
         //! \ogs_file_param_special{material__fracture_model__CohesiveZoneModeI__peak_normal_traction}
         config, "peak_normal_traction", parameters, 1);
 

MaterialLib/FractureModels/CreateLinearElasticIsotropic.cpp

@@ -27,11 +27,11 @@ createLinearElasticIsotropic(
     config.checkConfigParameter("type", "LinearElasticIsotropic");
     DBUG("Create LinearElasticIsotropic material");
 
-    auto& Kn = ParameterLib::findParameter<double>(
+    auto const& Kn = ParameterLib::findParameter<double>(
         //! \ogs_file_param_special{material__fracture_model__LinearElasticIsotropic__normal_stiffness}
         config, "normal_stiffness", parameters, 1);
 
-    auto& Ks = ParameterLib::findParameter<double>(
+    auto const& Ks = ParameterLib::findParameter<double>(
         //! \ogs_file_param_special{material__fracture_model__LinearElasticIsotropic__shear_stiffness}
         config, "shear_stiffness", parameters, 1);
 

MeshGeoToolsLib/BoundaryElementsAlongPolyline.cpp

@@ -32,7 +32,7 @@ BoundaryElementsAlongPolyline::BoundaryElementsAlongPolyline(
     auto node_ids_on_poly = mshNodeSearcher.getMeshNodeIDs(ply);
     MeshLib::ElementSearch es(_mesh);
     es.searchByNodeIDs(node_ids_on_poly);
-    auto& ele_ids_near_ply = es.getSearchedElementIDs();
+    auto const& ele_ids_near_ply = es.getSearchedElementIDs();
 
     // check all edges of the elements near the polyline
     for (auto ele_id : ele_ids_near_ply)

MeshGeoToolsLib/MeshNodesAlongSurface.cpp

@@ -28,7 +28,7 @@ MeshNodesAlongSurface::MeshNodesAlongSurface(MeshLib::Mesh const& mesh,
                                              SearchAllNodes search_all_nodes)
     : _mesh(mesh), _sfc(sfc)
 {
-    auto& mesh_nodes = _mesh.getNodes();
+    auto const& mesh_nodes = _mesh.getNodes();
     const std::size_t n_nodes(search_all_nodes == SearchAllNodes::Yes
                                   ? _mesh.getNumberOfNodes()
                                   : _mesh.getNumberOfBaseNodes());

ProcessLib/ComponentTransport/ComponentTransportFEM.h

@@ -185,7 +185,7 @@ public:
         bool is_axially_symmetric,
         unsigned const integration_order,
         ComponentTransportProcessData const& process_data,
-        std::vector<std::reference_wrapper<ProcessVariable>>
+        std::vector<std::reference_wrapper<ProcessVariable>> const&
             transport_process_variables)
         : _element(element),
           _process_data(process_data),

ProcessLib/Output/Output.cpp

@@ -302,7 +302,7 @@ void Output::doOutputAlways(Process const& process,
         return;
     }
 
-    auto output_bulk_mesh = [&](MeshLib::Mesh& mesh) {
+    auto output_bulk_mesh = [&](MeshLib::Mesh const& mesh) {
         MeshLib::IO::PVDFile* pvd_file = nullptr;
         if (_output_file_type == ProcessLib::OutputType::vtk)
         {

ProcessLib/PhaseField/CreatePhaseFieldProcess.cpp

@@ -112,42 +112,42 @@ std::unique_ptr<Process> createPhaseFieldProcess(
         config.getConfigSubtree("phasefield_parameters");
 
     // Residual stiffness
-    auto& residual_stiffness = ParameterLib::findParameter<double>(
+    auto const& residual_stiffness = ParameterLib::findParameter<double>(
         phasefield_parameters_config,
         //! \ogs_file_param_special{prj__processes__process__PHASE_FIELD__phasefield_parameters__residual_stiffness}
         "residual_stiffness", parameters, 1);
     DBUG("Use '{:s}' as residual stiffness.", residual_stiffness.name);
 
     // Crack resistance
-    auto& crack_resistance = ParameterLib::findParameter<double>(
+    auto const& crack_resistance = ParameterLib::findParameter<double>(
         phasefield_parameters_config,
         //! \ogs_file_param_special{prj__processes__process__PHASE_FIELD__phasefield_parameters__crack_resistance}
         "crack_resistance", parameters, 1);
     DBUG("Use '{:s}' as crack resistance.", crack_resistance.name);
 
     // Crack length scale
-    auto& crack_length_scale = ParameterLib::findParameter<double>(
+    auto const& crack_length_scale = ParameterLib::findParameter<double>(
         phasefield_parameters_config,
         //! \ogs_file_param_special{prj__processes__process__PHASE_FIELD__phasefield_parameters__crack_length_scale}
         "crack_length_scale", parameters, 1);
     DBUG("Use '{:s}' as crack length scale.", crack_length_scale.name);
 
     // Kinetic coefficient
-    auto& kinetic_coefficient = ParameterLib::findParameter<double>(
+    auto const& kinetic_coefficient = ParameterLib::findParameter<double>(
         phasefield_parameters_config,
         //! \ogs_file_param_special{prj__processes__process__PHASE_FIELD__phasefield_parameters__kinetic_coefficient}
         "kinetic_coefficient", parameters, 1);
     DBUG("Use '{:s}' as kinetic coefficient.", kinetic_coefficient.name);
 
     // Solid density
-    auto& solid_density = ParameterLib::findParameter<double>(
+    auto const& solid_density = ParameterLib::findParameter<double>(
         config,
         //! \ogs_file_param_special{prj__processes__process__PHASE_FIELD__solid_density}
         "solid_density", parameters, 1);
     DBUG("Use '{:s}' as solid density parameter.", solid_density.name);
 
     // History field
-    auto& history_field = ParameterLib::findParameter<double>(
+    auto const& history_field = ParameterLib::findParameter<double>(
         phasefield_parameters_config,
         //! \ogs_file_param_special{prj__processes__process__PHASE_FIELD__phasefield_parameters__history_field}
         "history_field", parameters, 1);

ProcessLib/PhaseField/PhaseFieldProcessData.h

@@ -43,7 +43,7 @@ struct PhaseFieldProcessData
     ParameterLib::Parameter<double> const& crack_length_scale;
     ParameterLib::Parameter<double> const& kinetic_coefficient;
     ParameterLib::Parameter<double> const& solid_density;
-    ParameterLib::Parameter<double>& history_field;
+    ParameterLib::Parameter<double> const& history_field;
     Eigen::Matrix<double, DisplacementDim, 1> const specific_body_force;
     bool propagating_crack = false;
     bool crack_pressure = false;

ProcessLib/Process.cpp

@@ -110,7 +110,7 @@ void Process::initialize()
 
 void Process::setInitialConditions(
     std::vector<GlobalVector*>& process_solutions,
-    std::vector<GlobalVector*>& process_solutions_prev,
+    std::vector<GlobalVector*> const& process_solutions_prev,
     double const t,
     int const process_id)
 {

ProcessLib/Process.h

@@ -84,7 +84,7 @@ public:
 
     void setInitialConditions(
         std::vector<GlobalVector*>& process_solutions,
-        std::vector<GlobalVector*>& process_solutions_prev,
+        std::vector<GlobalVector*> const& process_solutions_prev,
         double const t,
         int const process_id);
 

ProcessLib/ProcessVariable.cpp

@@ -331,7 +331,7 @@ std::vector<std::unique_ptr<SourceTerm>> ProcessVariable::createSourceTerms(
     std::vector<std::unique_ptr<SourceTerm>> source_terms;
 
     transform(cbegin(_source_term_configs), cend(_source_term_configs),
-              back_inserter(source_terms), [&](auto& config) {
+              back_inserter(source_terms), [&](auto const& config) {
                   return createSourceTerm(config, dof_table, config.mesh,
                                           variable_id, integration_order,
                                           _shapefunction_order, parameters);

ProcessLib/RichardsComponentTransport/CreateRichardsComponentTransportProcess.cpp

@@ -86,7 +86,7 @@ std::unique_ptr<Process> createRichardsComponentTransportProcess(
         MaterialLib::Fluid::createFluidProperties(fluid_config);
 
     // Parameter for the density of the fluid.
-    auto& fluid_reference_density = ParameterLib::findParameter<double>(
+    auto const& fluid_reference_density = ParameterLib::findParameter<double>(
         config,
         //! \ogs_file_param_special{prj__processes__process__RichardsComponentTransport__fluid_reference_density}
         "fluid_reference_density", parameters, 1, &mesh);

ProcessLib/SmallDeformation/CreateSmallDeformationProcess.cpp

@@ -72,7 +72,7 @@ std::unique_ptr<Process> createSmallDeformationProcess(
             parameters, local_coordinate_system, config);
 
     // Solid density
-    auto& solid_density = ParameterLib::findParameter<double>(
+    auto const& solid_density = ParameterLib::findParameter<double>(
         config,
         //! \ogs_file_param_special{prj__processes__process__SMALL_DEFORMATION__solid_density}
         "solid_density", parameters, 1, &mesh);