Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • O ogs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 98
    • Issues 98
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 40
    • Merge requests 40
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ogsogs
  • ogs
  • Merge requests
  • !4247

MPL: Reimplement VariableArray as own class

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dmitry Yu. Naumov requested to merge endJunction/ogs:ShrinkVariableArray into master Aug 23, 2022
  • Overview 18
  • Commits 6
  • Pipelines 7
  • Changes 132
  • Reducing the size of the VariableArray structure; new size is 408 bytes, old size is 1344 bytes.
  • allowing less types/stricter types,
  • simplified access to variables.

It also seems to be faster for at least one test: 4.138/4.345 \approx 95.2\%

  • master:
Benchmark 1: bin/ogs ../s/Tests/Data/ThermoRichardsMechanics/PointHeatSource/point_heat_source_2D.prj
  Time (mean ± σ):      4.345 s ±  0.034 s    [User: 4.632 s, System: 0.154 s]
  Range (min … max):    4.264 s …  4.422 s    100 runs
  • This MR:
Benchmark 1: bin/ogs ../s/Tests/Data/ThermoRichardsMechanics/PointHeatSource/point_heat_source_2D.prj
  Time (mean ± σ):      4.138 s ±  0.020 s    [User: 4.375 s, System: 0.150 s]
  Range (min … max):    4.094 s …  4.180 s    100 runs
  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?
Edited Aug 26, 2022 by Dmitry Yu. Naumov
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ShrinkVariableArray